Your message dated Wed, 23 Aug 2023 04:33:59 +0000
with message-id <e1qyfz9-00gqrw...@fasolo.debian.org>
and subject line Bug#1038486: fixed in devscripts 2.23.6
has caused the Debian Bug report #1038486,
regarding devscripts: FTBFS + autopkgtest failure with libgitlab-api-v4-perl
0.27-1
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1038486: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1038486
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: devscripts
Version: 2.23.5
Severity: serious
Tags: patch ftbfs trixie sid
Justification: fails to build from source (but built successfully in the past)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Since the upload of libgitlab-api-v4-perl 0.27-1, devscripts has test
failures both in autopkgtests and during build, c.f.
https://ci.debian.net/data/autopkgtest/testing/i386/d/devscripts/34359109/log.gz
Undefined subroutine &JSON::to_json called at ./t/salsa.pm line 49.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 1.
t/salsa.t .........
Dubious, test returned 255 (wstat 65280, 0xff00)
All 1 subtests passed
make[1]: *** [Makefile:44: test_perl.test_installed] Error 1
make: *** [Makefile:47: test-installed] Error 2
The reason is that test/t/salsa.pm calls JSON::to_json without
importing the JSON module (and without a dependency); this has
worked so far because libgitlab-api-v4-perl dependend on and loaded
JSON, but 0.27 has switched to JSON::MaybeXS.
Trivial and tested patch attached.
Cheers,
gregor
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmSPKnZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx
RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ
qgZ69BAAlCCHtwE+ZqffD+umkpcPwY9s892wrLhhKCYOqpEWqN+Ykarz6UMjBisH
RubNjUVceR+rsoWUqWcenjvPSTvqU3ctp9FeFAElh9DD161oOogmljqYGovR9ZaA
ZCgNCZcNHuKBVzIScFK8pnI2C4mAq8KHC3US/ewu7cv1U0ijY+N6bJQ7Ge1HiAN8
nRZSEwLFTLZ84GKsm/1nHNrays/2Q6G/QhZr1q0lllLvFQdViv3O8m4Xp76YMNF7
Bk2rcQjHx3q28B5avj4aze+Mx66QCVHKMv7CA7R6RmKvPpMdrdOfTCzwbsydWowc
0Sh7ecrrnCuwSwFyDcofssMwEdDOD3gLvvvDOqcNb6OCxtZYHILhsm+SEA7eNsPK
XRWptGINYKd1lNoY/1mQ1kaj9z6PU++v0skcgnA4NYqcohjKRjtBdLSJUkFH6DRS
4D/CQNtgHYM0yNOqYuZdhTDAZYD4G4YXJWsP6FPRkKnZ8nM4RugWtY05F6Ez4gQ4
IhJ0ousPUiY+G38mIVypdz1PmkMVehhEglyrM8ZuXpslZopHGHzfOojlAnlwUWEX
RFrkF4eHYw4DI34TVfNut3MxekMcWqwLXhzx1cr3msI4KtrMqT2PKNaxDW0cXuO1
OhmseAgrdWqWRV2u6g3Jf7gdjlsrUhSDvqVbwd+zUnZoVk/wUv8=
=3FK+
-----END PGP SIGNATURE-----
diff --git a/debian/control b/debian/control
index fce9de12..c494055d 100644
--- a/debian/control
+++ b/debian/control
@@ -29,6 +29,7 @@ Build-Depends:
libgit-wrapper-perl <!nocheck>,
libgitlab-api-v4-perl (>= 0.13) <!nocheck>,
libipc-run-perl <!nocheck>,
+ libjson-perl <!nocheck>,
liblist-compare-perl <!nocheck>,
libmoo-perl <!nocheck>,
libstring-shellquote-perl <!nocheck>,
diff --git a/debian/tests/control b/debian/tests/control
index eb8095b0..2b09c1de 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -9,6 +9,7 @@ Depends:
libdistro-info-perl,
libgitlab-api-v4-perl,
libipc-run-perl,
+ libjson-perl,
libtest-output-perl,
libwww-perl,
mozilla-devscripts,
diff --git a/test/t/salsa.pm b/test/t/salsa.pm
index 800d1e59..b737e262 100644
--- a/test/t/salsa.pm
+++ b/test/t/salsa.pm
@@ -3,6 +3,7 @@
package MockRESTClient;
use URI;
use Moo;
+ use JSON;
extends 'GitLab::API::v4::RESTClient';
has _mocks => (
--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.23.6
Done: Yadd <y...@debian.org>
We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1038...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Yadd <y...@debian.org> (supplier of updated devscripts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 23 Aug 2023 07:51:13 +0400
Source: devscripts
Architecture: source
Version: 2.23.6
Distribution: unstable
Urgency: medium
Maintainer: Devscripts Maintainers <devscri...@packages.debian.org>
Changed-By: Yadd <y...@debian.org>
Closes: 1038486
Changes:
devscripts (2.23.6) unstable; urgency=medium
.
* Team upload
.
[ Yadd ]
* fix salsa test (Closes: #1038486)
* add dependency to libjson-perl
.
[ gregor herrmann ]
* test/t/salsa.pm: use JSON (Closes: #1038486)
Checksums-Sha1:
88ac43b5f2722a2c91bdb3ecbe1ee3dca9deec77 3384 devscripts_2.23.6.dsc
ab17218aced30c3833db751054cedbe361e92f01 991208 devscripts_2.23.6.tar.xz
Checksums-Sha256:
2a0984cc84aad33cc47145ee06c76546f48cf87205b10f8cf2c9824ef6b09b34 3384
devscripts_2.23.6.dsc
358b6072348954eca333120801bf7d7a7eeb1e917224e6f49c0c68dd9f1854b1 991208
devscripts_2.23.6.tar.xz
Files:
8b476dfe46d4907b23bca2af3f348221 3384 devel optional devscripts_2.23.6.dsc
6b67898d0e6843ea24338e42621eb60f 991208 devel optional devscripts_2.23.6.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAmTlhiIACgkQ9tdMp8mZ
7um6Rw/+PKlusPsh7lk9lxEhGHD5unEcNu3P/cvIIQXmxNCnZIv7irl5uRGMUq4R
Ke3B9rVy9lpUh1SKM2qn5cV9e3/AZl5ie7qeDN1Yw8b2XCQ/tnLdaG4P5UXQj4zW
Q3iCw0NR4DVJM+e2t3b5n9MkHOSZ8gi09CSU5lrBdUY4bdyWRxquHQ68k8aYRflJ
/caUP49SgY7+bE5bgXZaXkCHawJoUwGK3cePLKeDuIXBq0Db1DBGFCbZtyR9XOp5
dKU+rDx0wgfGrXo+WpG/21/BpqJh3k8gAzYkaatsunPqtYlqcOdAtFrOQczTOgZN
Q4I2apHLUdKBe8NipAqBNz0dnh1PgmADQO3+lQ8ucvoRs5Qx4hQEEAVu/dFeIFlh
ipavelhD7LBW6NdI9QCwXD45eXl9nd7KsYs8yT3Mb415Sc43XfrBrSvqInrnPgVH
Dd37dWdchqtI+7tZs8y/uf3mzpHX3/QM3+EAON1wdPVmGKr8r5XFM+ZPYwi7N8e/
2oZJHyGqWYYhk9bbuWW9S6OVlMbogRW0w3tyfpyZasIdmDF3ClwzeYavqJIiMiTM
LQE9Nd4XSMQUI7tfMKmW2H8kgxJJqYKxnZaqM7LxWW/eZMut03xrOpfySIBEUTpZ
Qb987okiOBLu8T1auMZtHgnbLfpVo0nNdHcDcVbiPHJUi3TU2fg=
=z081
-----END PGP SIGNATURE-----
--- End Message ---
