tags 615719 patch
tags 609079 fixed-upstream
thanks

Hello Radu and Matei,
I was looking about the following debian bug report:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=615719
http://wiki.debian.org/ToolChain/DSOLinking

As described in the wiki page above, the linker now doesn't try to guess
what libraries could be needed but uses only those passed on the command
line. As the indi part of gcx uses zlib but doesn't link explicitely to
it, this causes a failure to build the sources on all "recent" debian
systems.
I've written the attached patch to fix the issue (adding zlib to configure
checks). If you like it, would you import in the cvs.

Also, as Matei fixed the issue reported in:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=609079
(and I'm also attaching a patch fixing minor typos in messages), would you
be so kind to release a new version of gcx with those two bugs (and typos)
fixed?
(even if would be faster for me to release a new debian package with all
those fixes, I prefer if you release a new version, so other people using
gcx from sources will also receive the patches)

regards,
Riccardo
--- gcx-1.3/configure.ac	2010-03-13 23:38:06.000000000 +0100
+++ gcx-1.3.zlib/configure.ac	2011-07-23 23:41:55.000000000 +0200
@@ -17,6 +17,8 @@
 
 
 AM_PATH_GTK_2_0(2.4.0, , AC_MSG_ERROR(Cannot find GTK: is pkg-config in path?))
+AC_CHECK_HEADERS([zlib.h])
+AC_CHECK_LIB(z, inflate)
 
 AC_CONFIG_FILES([
 	makedeb
diff -u gcx-1.3/src/cameragui.c gcx-1.3.zlib/src/cameragui.c
--- gcx-1.3/src/cameragui.c	2009-10-08 13:18:53.000000000 +0200
+++ gcx-1.3.zlib/src/cameragui.c	2011-07-24 00:03:31.000000000 +0200
@@ -797,7 +797,7 @@
 	if (!ret) {
 		status_message(data, "Synchronised");
 	} else {
-		err_printf("Failed to syncronize\n");
+		err_printf("Failed to synchronize\n");
 	}
 }
 
diff -u gcx-1.3/src/helpmsg.c gcx-1.3.zlib/src/helpmsg.c
--- gcx-1.3/src/helpmsg.c	2009-06-28 22:03:28.000000000 +0200
+++ gcx-1.3.zlib/src/helpmsg.c	2011-07-24 00:02:21.000000000 +0200
@@ -121,7 +121,7 @@
 "-c, --demosaic                     Enable demosaicing using the method set in\n"
 "                                     the parameters file;  If no color-field array\n"
 "                                     is specified by the input file, the default\n"
-"                                     specified in the paramters file is used\n"
+"                                     specified in the parameters file is used\n"
 
 "\n    When any of the CCD reduction options is set and the -i flag\n"
 "    is not specified, the reduction operations are run in batch mode\n"
Common subdirectories: gcx-1.3/src/libindiclient and gcx-1.3.zlib/src/libindiclient
diff -u gcx-1.3/src/tele_indi.c gcx-1.3.zlib/src/tele_indi.c
--- gcx-1.3/src/tele_indi.c	2009-09-16 18:42:55.000000000 +0200
+++ gcx-1.3.zlib/src/tele_indi.c	2011-07-24 00:03:03.000000000 +0200
@@ -164,7 +164,7 @@
 		elem = indi_prop_set_switch(tele->speed_prop, "Guide", TRUE);
 		break;
 	default:
-		err_printf("Unkown speed: %d\n", type);
+		err_printf("Unknown speed: %d\n", type);
 		return;
 	}
 	if (! elem) {

Attachment: signature.asc
Description: Digital signature

Reply via email to