tags 632349 + pending thanks Dear maintainer,
I've prepared an NMU for gcompris (versioned as 9.3-1.2) and uploaded it to DELAYED/5. Please feel free to tell me if I should delay it longer.
-- Jakub Wilk
diffstat for gcompris_9.3-1.1 gcompris_9.3-1.2 gcompris-9.3/debian/changelog | 9 +++++++++ src/advanced_colors-activity/advanced_colors.c | 2 -- src/algebra_by-activity/algebra.c | 3 --- src/awele-activity/awele.c | 5 +---- src/babymatch-activity/shapegame.c | 2 +- src/boards/goocanvas.c | 3 +-- src/boards/py-mod-admin.c | 3 +-- src/boards/py-mod-skin.c | 3 +-- src/boards/py-mod-utils.c | 3 +-- src/click_on_letter-activity/click_on_letter.c | 4 ---- src/clockgame-activity/clockgame.c | 7 +++---- src/crane-activity/crane.c | 5 ++--- src/fifteen-activity/fifteen.c | 3 +-- src/gcompris/about.c | 2 -- src/gcompris/bar.c | 9 --------- src/gcompris/dialog.c | 5 ----- src/gcompris/file_selector.c | 18 ++---------------- src/gcompris/gameutil.c | 7 ------- src/gcompris/gcompris_confirm.c | 4 +--- src/gcompris/images_selector.c | 3 +-- src/gcompris/skin.c | 3 --- src/gcompris/wordlist.c | 3 --- src/goocanvas/src/goocanvasgroup.c | 4 ---- src/magic_hat_minus-activity/magic_hat.c | 6 ++---- src/money-activity/money_widget.c | 4 +++- src/scalesboard-activity/scale.c | 9 ++++----- src/tangram-activity/gtans.c | 17 ----------------- src/traffic-activity/traffic.c | 3 --- src/wordsgame-activity/wordsgame.c | 4 +--- 29 files changed, 35 insertions(+), 118 deletions(-) diff -u gcompris-9.3/debian/changelog gcompris-9.3/debian/changelog --- gcompris-9.3/debian/changelog +++ gcompris-9.3/debian/changelog @@ -1,3 +1,12 @@ +gcompris (9.3-1.2) unstable; urgency=low + + * Non-maintainer upload. + * Backport upstream patch to fix build failure with + -Werror=unused-but-set-variable (closes: #632349). Thanks to Dan Chen for + finding the patch. + + -- Jakub Wilk <jw...@debian.org> Mon, 15 Aug 2011 15:45:18 +0200 + gcompris (9.3-1.1) unstable; urgency=medium * Non-maintainer upload. only in patch2: unchanged: --- gcompris-9.3.orig/src/crane-activity/crane.c +++ gcompris-9.3/src/crane-activity/crane.c @@ -581,7 +581,6 @@ // Draw the drak frame (horizontal and vertical lines) that helps positionning elements static void draw_frame(int x, int y) { - GooCanvasItem *item_frame = NULL; int i; GooCanvasPoints *track; @@ -594,7 +593,7 @@ track->coords[2] = x + i * CRANE_FRAME_CELL; track->coords[3] = y + (CRANE_FRAME_LINE * CRANE_FRAME_CELL) - CRANE_FRAME_BORDER; - item_frame = goo_canvas_polyline_new (boardRootItem, FALSE, 0, + goo_canvas_polyline_new (boardRootItem, FALSE, 0, "points", track, "fill-color", "black", NULL); @@ -607,7 +606,7 @@ track->coords[2] = x + (CRANE_FRAME_COLUMN * CRANE_FRAME_CELL) - CRANE_FRAME_BORDER; track->coords[3] = y + (i * CRANE_FRAME_CELL); - item_frame = goo_canvas_polyline_new (boardRootItem, FALSE, 0, + goo_canvas_polyline_new (boardRootItem, FALSE, 0, "points", track, "fill-color", "black", NULL); only in patch2: unchanged: --- gcompris-9.3.orig/src/goocanvas/src/goocanvasgroup.c +++ gcompris-9.3/src/goocanvas/src/goocanvasgroup.c @@ -172,12 +172,10 @@ ...) { GooCanvasItem *item; - GooCanvasGroup *group; va_list var_args; const char *first_property; item = g_object_new (GOO_TYPE_CANVAS_GROUP, NULL); - group = (GooCanvasGroup*) item; va_start (var_args, parent); first_property = va_arg (var_args, char*); @@ -894,12 +892,10 @@ ...) { GooCanvasItemModel *model; - GooCanvasGroupModel *gmodel; va_list var_args; const char *first_property; model = g_object_new (GOO_TYPE_CANVAS_GROUP_MODEL, NULL); - gmodel = (GooCanvasGroupModel*) model; va_start (var_args, parent); first_property = va_arg (var_args, char*); only in patch2: unchanged: --- gcompris-9.3.orig/src/fifteen-activity/fifteen.c +++ gcompris-9.3/src/fifteen-activity/fifteen.c @@ -342,13 +342,12 @@ { GooCanvasItem **board; GooCanvasItem *text; - int num, pos, newpos; + int pos, newpos; int x, y; double dx = 0.0, dy = 0.0; int move; board = g_object_get_data (G_OBJECT (goo_canvas_item_get_parent(item)), "board"); - num = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (item), "piece_num")); pos = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (item), "piece_pos")); text = g_object_get_data (G_OBJECT (item), "text"); only in patch2: unchanged: --- gcompris-9.3.orig/src/magic_hat_minus-activity/magic_hat.c +++ gcompris-9.3/src/magic_hat_minus-activity/magic_hat.c @@ -437,7 +437,6 @@ // Draw a frame with empty small squares static void draw_frame(frame *my_frame) { - GooCanvasItem *item_frame = NULL; int i, j; double x = my_frame->coord_x; double y = my_frame->coord_y; @@ -460,7 +459,7 @@ track->coords[8] = x + (j * (ITEM_SIZE + SPACE_BETWEEN_ITEMS)); track->coords[9] = y + (i * (ITEM_SIZE + SPACE_BETWEEN_ITEMS)); - item_frame = goo_canvas_polyline_new (boardRootItem, FALSE, 0, + goo_canvas_polyline_new (boardRootItem, FALSE, 0, "points", track, "line-width", 1.0, "fill-color", "#948d85", @@ -476,7 +475,6 @@ // Draw the table (line) static void draw_table() { - GooCanvasItem *item_frame = NULL; GooCanvasPoints *track; track = goo_canvas_points_new(2); @@ -486,7 +484,7 @@ track->coords[2] = MH_HAT_X + MH_HAT_WIDTH; track->coords[3] = MH_HAT_Y + MH_HAT_HEIGHT + 5; - item_frame = goo_canvas_polyline_new (boardRootItem, FALSE, 0, + goo_canvas_polyline_new (boardRootItem, FALSE, 0, "points", track, "line-width", 1.0, "fill-color", "black", only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/file_selector.c +++ gcompris-9.3/src/gcompris/file_selector.c @@ -161,8 +161,6 @@ FileSelectorCallBack iscb, void *user_context) { - GooCanvasItem *item; - gchar *name = NULL; gchar *full_rootdir; mode = the_mode; @@ -179,13 +177,12 @@ gc_board_pause(TRUE); - name = gcomprisBoard->name; fileSelectorCallBack=iscb; rootitem = goo_canvas_group_new (goo_canvas_get_root_item(gc_get_canvas()), NULL); - item = goo_canvas_svg_new (rootitem, + goo_canvas_svg_new (rootitem, gc_skin_rsvg_get(), "svg-id", "#FILE_SELECTOR", "pointer-events", GOO_CANVAS_EVENTS_NONE, @@ -197,7 +194,7 @@ if(mode==MODE_SAVE) gtk_entry_set_max_length(GTK_ENTRY(widget_entry), 30); - item = goo_canvas_widget_new (rootitem, + goo_canvas_widget_new (rootitem, GTK_WIDGET(widget_entry), control_area_x1, control_area_y1, @@ -281,7 +278,6 @@ display_files(GooCanvasItem *root_item, gchar *rootdir) { GooCanvasItem *item; - double iw, ih; const gchar *one_dirent; GDir *dir; @@ -383,10 +379,6 @@ gc_skin_get_color("gcompris/fileselectcol"), NULL); - - iw = IMAGE_WIDTH; - ih = IMAGE_HEIGHT; - /* Insert all files in a sorted list */ while((one_dirent = g_dir_read_name(dir)) != NULL) @@ -673,11 +665,5 @@ static void entry_enter_callback( GtkWidget *widget, GtkWidget *entry ) { - gchar *entry_text; - - if(!rootitem) - return; - - entry_text = (char *)gtk_entry_get_text(GTK_ENTRY(entry)); } only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/about.c +++ gcompris-9.3/src/gcompris/about.c @@ -41,7 +41,6 @@ { GdkPixbuf *pixmap = NULL; gdouble y_start = 0; - gdouble x_start = 0; gint y = 0; GooCanvasItem *item; gint plane_y; @@ -76,7 +75,6 @@ GooCanvasBounds bounds; goo_canvas_item_get_bounds(item, &bounds); - x_start = bounds.x1; y_start = bounds.y1; y = bounds.y2 - 26; only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/dialog.c +++ gcompris-9.3/src/gcompris/dialog.c @@ -47,9 +47,6 @@ */ void gc_dialog(gchar *str, DialogBoxCallBack dbcb) { - gint y_start; - gint x_start; - g_warning("Dialog=%s\n", str); /* If we are already running do nothing */ @@ -82,8 +79,6 @@ GooCanvasBounds bounds; goo_canvas_item_get_bounds(itemDialogText, &bounds); - x_start = bounds.x1; - y_start = bounds.y1; goo_canvas_text_new (rootDialogItem, str, only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/bar.c +++ gcompris-9.3/src/gcompris/bar.c @@ -151,14 +151,9 @@ bar_start (GooCanvas *theCanvas) { GcomprisProperties *properties = gc_prop_get(); - gint16 height; - gint16 buttony; - double zoom; RsvgHandle *svg_handle; GooCanvasBounds bounds; - height = BARHEIGHT-2; - _default_y = BOARDHEIGHT - BARHEIGHT; _default_zoom = 1.0; @@ -174,10 +169,6 @@ NULL); SET_ITEM_LOCATION(bar_item, 0, 0); - goo_canvas_item_get_bounds(bar_item, &bounds); - zoom = (double)(height-BAR_GAP)/(bounds.y2 - bounds.y1); - buttony = (height-(bounds.y2 - bounds.y1)*zoom)/2 - 20; - /* * The Order in which buttons are created represents * also the order in which they will be displayed only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/skin.c +++ gcompris-9.3/src/gcompris/skin.c @@ -446,9 +446,6 @@ gc_skin_get_gdkcolor_default(gchar* id, guint32 def, GdkColor *gdkcolor) { gchar *tmp; - guint32 color; - - color = gc_skin_get_color_default(id, def); tmp = g_strdup_printf("#%06X", gc_skin_get_color(id) >> 8); gdk_color_parse(tmp, gdkcolor); only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/images_selector.c +++ gcompris-9.3/src/gcompris/images_selector.c @@ -108,7 +108,6 @@ void *user_context) { - GooCanvasItem *item; gint y_start = 0; gchar *dataseturl = NULL; @@ -129,7 +128,7 @@ images_selector_displayed = TRUE; - item = goo_canvas_svg_new (rootitem, + goo_canvas_svg_new (rootitem, gc_skin_rsvg_get(), "svg-id", "#IMAGE_SELECTOR", "pointer-events", GOO_CANVAS_EVENTS_NONE, only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/gcompris_confirm.c +++ gcompris-9.3/src/gcompris/gcompris_confirm.c @@ -153,8 +153,6 @@ gchar *no_text, ConfirmCallBack iscb) { - GooCanvasItem *item; - if(rootitem) return; @@ -188,7 +186,7 @@ rootitem = goo_canvas_group_new (goo_canvas_get_root_item(gc_get_canvas()), NULL); - item = goo_canvas_svg_new (rootitem, + goo_canvas_svg_new (rootitem, gc_skin_rsvg_get(), "svg-id", "#DIALOG", "pointer-events", GOO_CANVAS_EVENTS_NONE, only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/wordlist.c +++ gcompris-9.3/src/gcompris/wordlist.c @@ -69,8 +69,6 @@ GcomprisWordlist *wordlist; xmlChar *text; - GSList *words = NULL; - if (!format) return NULL; @@ -161,7 +159,6 @@ node = wlNode->children; while((node!=NULL)) { - words = NULL; if (node->type!=XML_ELEMENT_NODE){ node = node->next; continue; only in patch2: unchanged: --- gcompris-9.3.orig/src/gcompris/gameutil.c +++ gcompris-9.3/src/gcompris/gameutil.c @@ -289,7 +289,6 @@ { GooCanvasItem *highlight_item; GooCanvasBounds bounds; - gboolean already_created = FALSE; if(!target_item) target_item = source_item; @@ -306,7 +305,6 @@ if(highlight_item) { - already_created = TRUE; goo_canvas_item_remove(highlight_item); } @@ -440,7 +438,6 @@ { double x1, x2, y1, y2; double tx1, tx2, ty1, ty2; - double cx, cy; // goo_canvas_item_get_bounds( item, &x1, &y1, &x2, &y2 ); /* WARNING: Do not use goo_canvas_item_get_bounds which gives unpredictable results */ @@ -478,10 +475,6 @@ x2 = MAX(tx1,tx2); y2 = MAX(ty1,ty2); - - cx = (x2+x1)/2; - cy = (y2+y1)/2; - goo_canvas_item_rotate(item, angle, x1+(x2-x1)/2, y1+(y2-y1)/2); only in patch2: unchanged: --- gcompris-9.3.orig/src/tangram-activity/gtans.c +++ gcompris-9.3/src/tangram-activity/gtans.c @@ -1770,7 +1770,6 @@ void taninitstart(void){ int i; - char* accurstr; for (i = PXSTART; i<PXNBR+PXSTART; i++){ tabpxnam[i] = NULL; @@ -1797,22 +1796,6 @@ create_mainwindow(boardRootItem); - switch (accuracy){ - case 0: - accurstr = "maccuracy1"; - break; - case 2: - accurstr = "maccuracy3"; - break; - default : - accurstr = "maccuracy2"; - } - - if (rotstepnbr==TOUR/256) - accurstr = "mrotcont"; - else - accurstr = "mrotstp"; - tanloadfigtab(figfilename); } only in patch2: unchanged: --- gcompris-9.3.orig/src/advanced_colors-activity/advanced_colors.c +++ gcompris-9.3/src/advanced_colors-activity/advanced_colors.c @@ -280,7 +280,6 @@ { GdkPixbuf *pixmap; char *str = NULL; - int i; boardRootItem = goo_canvas_group_new (goo_canvas_get_root_item(gcomprisBoard->canvas), NULL); @@ -303,7 +302,6 @@ g_object_set (highlight_image_item, "visibility", GOO_CANVAS_ITEM_INVISIBLE, NULL); - i = g_random_int_range(0,LAST_COLOR); gdk_pixbuf_unref(pixmap); only in patch2: unchanged: --- gcompris-9.3.orig/src/money-activity/money_widget.c +++ gcompris-9.3/src/money-activity/money_widget.c @@ -139,11 +139,13 @@ static void class_init (Money_WidgetClass *class) { +#if 0 GtkObjectClass *object_class; object_class = (GtkObjectClass*) class; - //2 object_class->destroy = finalize; + object_class->destroy = finalize; +#endif } static void only in patch2: unchanged: --- gcompris-9.3.orig/src/boards/py-mod-admin.c +++ gcompris-9.3/src/boards/py-mod-admin.c @@ -384,8 +384,7 @@ void python_gcompris_admin_module_init(void) { - PyObject* module; - module = Py_InitModule("_gcompris_admin", PythonGcomprisAdminModule); + Py_InitModule("_gcompris_admin", PythonGcomprisAdminModule); } /* Some usefull code parts ... */ only in patch2: unchanged: --- gcompris-9.3.orig/src/boards/goocanvas.c +++ gcompris-9.3/src/boards/goocanvas.c @@ -4452,7 +4452,6 @@ PyObject *kwargs) { static char *kwlist[] = { "cr", NULL }; - int ret; GooCanvasBounds bounds; PycairoContext *cr; @@ -4461,7 +4460,7 @@ kwlist, &PycairoContext_Type, &cr)) return NULL; - ret = goo_canvas_item_get_requested_area(GOO_CANVAS_ITEM(self->obj), + goo_canvas_item_get_requested_area(GOO_CANVAS_ITEM(self->obj), cr->ctx, &bounds); return pygoo_canvas_bounds_new(&bounds); only in patch2: unchanged: --- gcompris-9.3.orig/src/boards/py-mod-utils.c +++ gcompris-9.3/src/boards/py-mod-utils.c @@ -440,8 +440,7 @@ void python_gcompris_utils_module_init(void) { - PyObject* module; - module = Py_InitModule("_gcompris_utils", PythonGcomprisUtilsModule); + Py_InitModule("_gcompris_utils", PythonGcomprisUtilsModule); } /* Some usefull code parts ... */ only in patch2: unchanged: --- gcompris-9.3.orig/src/boards/py-mod-skin.c +++ gcompris-9.3/src/boards/py-mod-skin.c @@ -194,8 +194,7 @@ void python_gc_skin_module_init(void) { - PyObject* module; - module = Py_InitModule("_gcompris_skin", PythonGcomprisSkinModule); + Py_InitModule("_gcompris_skin", PythonGcomprisSkinModule); } /* Some usefull code parts ... */ only in patch2: unchanged: --- gcompris-9.3.orig/src/babymatch-activity/shapegame.c +++ gcompris-9.3/src/babymatch-activity/shapegame.c @@ -1860,7 +1860,7 @@ else drag_previous = 0; - gc_board_config_combo_drag(bconf, drag_mode); + gc_board_config_combo_drag(bconf, drag_previous); } only in patch2: unchanged: --- gcompris-9.3.orig/src/clockgame-activity/clockgame.c +++ gcompris-9.3/src/clockgame-activity/clockgame.c @@ -379,7 +379,6 @@ static void clockgame_create_item(GooCanvasItem *parent) { - GooCanvasItem *item; double needle_size = clock_size; double min_point_size = clock_size*0.05; double hour_point_size = clock_size*0.1; @@ -421,7 +420,7 @@ canvasPoints->coords[2]=cx + needle_size * sin(ang); canvasPoints->coords[3]=cy - needle_size * cos(ang); - item = goo_canvas_polyline_new (boardRootItem, FALSE, 2, + goo_canvas_polyline_new (boardRootItem, FALSE, 2, canvasPoints->coords[0], canvasPoints->coords[1], canvasPoints->coords[2], @@ -434,7 +433,7 @@ if(gcomprisBoard->level<5) { mtext = g_strdup_printf("%d", min); - item = goo_canvas_text_new (boardRootItem, + goo_canvas_text_new (boardRootItem, mtext, (double) cx + (needle_size+10) * sin(ang), (double) cy - (needle_size+10) * cos(ang), @@ -451,7 +450,7 @@ if(min%5==0) { mtext = g_strdup_printf( "%d", min/5); - item = goo_canvas_text_new (boardRootItem, + goo_canvas_text_new (boardRootItem, mtext, (double) cx + (needle_size-30) * sin(ang), (double) cy - (needle_size-30) * cos(ang), only in patch2: unchanged: --- gcompris-9.3.orig/src/click_on_letter-activity/click_on_letter.c +++ gcompris-9.3/src/click_on_letter-activity/click_on_letter.c @@ -478,10 +478,6 @@ GdkEvent *event, gpointer data) { int pos = GPOINTER_TO_INT(data); - double item_x, item_y; - item_x = event->button.x; - item_y = event->button.y; - //goo_canvas_convert_to_item_space(item->parent, &item_x, &item_y); if(board_paused) return FALSE; only in patch2: unchanged: --- gcompris-9.3.orig/src/awele-activity/awele.c +++ gcompris-9.3/src/awele-activity/awele.c @@ -715,7 +715,7 @@ { char buffer[3]; //Manipulation chaines de caracteres - int i, j, k, idxTabBeans = 0; //Compteur Boucle Manipulation Elements graphiques + int i, j, idxTabBeans = 0; //Compteur Boucle Manipulation Elements graphiques static short int nbActiveBean = NBTOTALBEAN; //nbre graine restant sur plateau static short int nbOldActiveBean; //nbre graine restant sur plateau au tour precedent BEANHOLE_LINK *ptBeansHoleLink = NULL; //pointeur sur structures stockant les item graines et la case dans laquelle elles se trouvent. @@ -774,9 +774,6 @@ j < staticAwale->board[i] && idxTabBeans < nbActiveBean; j++, idxTabBeans++) { - - k = 0 + g_random_int() % 4; - g_object_set (ptBeansHoleLink[idxTabBeans].beanPixbuf, "x", (double) caseCoord[i] + g_random_int() % 50, only in patch2: unchanged: --- gcompris-9.3.orig/src/algebra_by-activity/algebra.c +++ gcompris-9.3/src/algebra_by-activity/algebra.c @@ -712,14 +712,11 @@ static gboolean solution_found() { ToBeFoundItem *firstToBeFoundItem = currentToBeFoundItem; - ToBeFoundItem *toBeFoundItem; /* Go to the leftmost digit */ while(firstToBeFoundItem->previous!=NULL) firstToBeFoundItem = firstToBeFoundItem->previous; - toBeFoundItem = firstToBeFoundItem; - /* Check the numbers one by one */ while(firstToBeFoundItem != NULL) { only in patch2: unchanged: --- gcompris-9.3.orig/src/traffic-activity/traffic.c +++ gcompris-9.3/src/traffic-activity/traffic.c @@ -610,12 +610,9 @@ GdkEventButton *event, car *thiscar) { - GooCanvas *canvas; double item_x, item_y; GdkCursor *cursor; - canvas = goo_canvas_item_get_canvas (item); - item_x = event->x; item_y = event->y; goo_canvas_convert_to_item_space(goo_canvas_item_get_canvas(item), only in patch2: unchanged: --- gcompris-9.3.orig/src/wordsgame-activity/wordsgame.c +++ gcompris-9.3/src/wordsgame-activity/wordsgame.c @@ -590,7 +590,6 @@ static GooCanvasItem *wordsgame_create_item(GooCanvasItem *parent) { - GooCanvasItem *item2; LettersItem *item; gchar *word = gc_wordlist_random_word_get(gc_wordlist, gcomprisBoard->level); GtkAnchorType direction_anchor = GTK_ANCHOR_NW; @@ -616,8 +615,7 @@ /* To 'erase' words, I create 2 times the text item. One is empty now */ /* It will be filled each time the user enters the right key */ - item2 = \ - goo_canvas_text_new (item->rootitem, + goo_canvas_text_new (item->rootitem, item->word, (double) 0, (double) 0, only in patch2: unchanged: --- gcompris-9.3.orig/src/scalesboard-activity/scale.c +++ gcompris-9.3/src/scalesboard-activity/scale.c @@ -921,7 +921,6 @@ scale_next_level() { GdkPixbuf *pixmap, *pixmap2; - GooCanvasItem *item, *balance; gdouble balance_x; gc_bar_set_level(gcomprisBoard); @@ -949,7 +948,7 @@ NULL); gdk_pixbuf_unref(pixmap2); - balance = goo_canvas_image_new(boardRootItem, + goo_canvas_image_new(boardRootItem, pixmap, balance_x, balance_left_y, @@ -978,7 +977,7 @@ pixmap = gc_pixmap_load("scale/plateau.png"); - item = goo_canvas_image_new(group_g, + goo_canvas_image_new(group_g, pixmap, 0, PLATE_Y, @@ -994,7 +993,7 @@ pixmap = gc_pixmap_load("scale/plateau.png"); pixmap2 = gdk_pixbuf_flip(pixmap, TRUE); - item = goo_canvas_image_new(group_d, + goo_canvas_image_new(group_d, pixmap2, 0, PLATE_Y, @@ -1179,7 +1178,7 @@ else drag_previous = 0; - gc_board_config_combo_drag(bconf, drag_mode); + gc_board_config_combo_drag(bconf, drag_previous); }