Your message dated Sun, 27 Mar 2016 09:52:28 +0000
with message-id <e1ak7my-0004r9...@franck.debian.org>
and subject line Bug#817071: fixed in rsnapshot 1.4.2-1
has caused the Debian Bug report #817071,
regarding Backup fails if sync_first is used and some files are modified while 
rsync runs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
817071: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=817071
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: rsnapshot
Version: 1.4.1-1
Severity: grave
Tags: upstream patch

Hi,

I just noticed that my backups are broken since a while. rsnapshot happily makes
backups of an old state of its .sync directory. Symptoms on stderr are:

[snip]
----------------------------------------------------------------------------
rsnapshot encountered an error! The program was invoked with these options:
/usr/bin/rsnapshot sync 
----------------------------------------------------------------------------
ERROR: /usr/bin/rsync returned 0.09375 while processing /
WARNING: Rolling back "hdd/"
[/snip]

(Notice that it says it's Rolling back, thus I get lots of disk activity and
think that it does a backup. Also, the mtimes in the backup directory suggest as
well that everything works. Oh and I had this error in the past, too, without
any problems. Hence the severity.)

Google found the following upstream report on this bug:

 https://github.com/rsnapshot/sourceforge-issues/issues/8

And indeed I see in /usr/bin/rsnapshot that first in line 3921, result is set
via

  $result = $? >> 8;

and then line 3929 does (where the function get_retval() just divides by its
argument by 256). As you see in the output above, this results in $retval being
set to 0.09375.

  my $retval = get_retval($result);

The fix should be the following chunk of an otherwise weirdly wrong commit
upstream:

https://github.com/rsnapshot/rsnapshot/commit/778ab47d8eb4891f464677a0e26c38b186a376c8#diff-70276296f2bdcc3adb72b3d823d07361L3922

Cheers,
Uli
-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-proposed-updates'), (50, 
'experimental'), (50, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.3.0-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages rsnapshot depends on:
ii  liblchown-perl  1.01-3+b1
ii  logrotate       3.8.7-2
ii  perl            5.22.1-8
ii  rsync           3.1.1-3

Versions of packages rsnapshot recommends:
ii  openssh-client [ssh-client]  1:7.1p2-2

rsnapshot suggests no packages.

-- Configuration Files:
/etc/logrotate.d/rsnapshot changed:
/var/log/rsnapshot.log /var/log/rsnapshot {
        rotate 6
        monthly
        compress
        missingok
}

/etc/rsnapshot.conf changed:
config_version  1.2
snapshot_root   /media/backup/
no_create_root  1
cmd_cp          /bin/cp
cmd_rm          /bin/rm
cmd_rsync       /usr/bin/rsync
cmd_logger      /usr/bin/logger
cmd_du          /usr/bin/du
cmd_rsnapshot_diff      /usr/bin/rsnapshot-diff
retain  daily   8
retain  weekly  5
retain  monthly 12
verbose         2
loglevel        3
logfile /var/log/rsnapshot.log
lockfile        /var/run/rsnapshot.pid
exclude kuja.in_home
exclude /proc
exclude /sys
exclude /tmp
exclude /var/tmp
exclude .ccache
exclude /dev/.udev
exclude /dev/pts
exclude /dev/shm
exclude /var/cache
link_dest       1
sync_first      1
backup  /               hdd/


-- no debconf information

--- End Message ---
--- Begin Message ---
Source: rsnapshot
Source-Version: 1.4.2-1

We believe that the bug you reported is fixed in the latest version of
rsnapshot, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 817...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillaume Delacour <g...@iroqwa.org> (supplier of updated rsnapshot package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 26 Mar 2016 11:23:26 +0100
Source: rsnapshot
Binary: rsnapshot
Architecture: source all
Version: 1.4.2-1
Distribution: unstable
Urgency: medium
Maintainer: Guillaume Delacour <g...@iroqwa.org>
Changed-By: Guillaume Delacour <g...@iroqwa.org>
Description:
 rsnapshot  - local and remote filesystem snapshot utility
Closes: 817071
Changes:
 rsnapshot (1.4.2-1) unstable; urgency=medium
 .
   * New upstream release (Closes: #817071), refresh patches
   * Bump Standards-Version to 3.9.7, no changes needed
   * Use https for Vcs-Browser
Checksums-Sha1:
 edadf12a7cd5d13d7e267d90bdb965dc558d47c9 2034 rsnapshot_1.4.2-1.dsc
 df6d7866e6341b092b5e75cf9006068760aa3fce 487959 rsnapshot_1.4.2.orig.tar.gz
 4d8b6043a4ee41719671357558b595c19737b8a5 15644 rsnapshot_1.4.2-1.debian.tar.xz
 5d033d55c108ea008edbe1c01541325adaed1e5b 130368 rsnapshot_1.4.2-1_all.deb
Checksums-Sha256:
 d91a0784c89f4b75f29f9f3fcfd37e7d433af4e3bf7570f946ec07d0133954d9 2034 
rsnapshot_1.4.2-1.dsc
 042a81c45b325296b21c363f417985d857f083f87c5c27f5a64677a052f24e16 487959 
rsnapshot_1.4.2.orig.tar.gz
 01a6d71467a83b17023a31cd3df7794e352dac40ba64fe35af2f55cabebe7858 15644 
rsnapshot_1.4.2-1.debian.tar.xz
 d49470c4700aba2b00187d6ff68781f869856ff1ef9aa98dcd73b672ffffa866 130368 
rsnapshot_1.4.2-1_all.deb
Files:
 33bf4f9b5074ed14e71eec20a2272612 2034 utils optional rsnapshot_1.4.2-1.dsc
 860382f19e38fc649f9447397b54e442 487959 utils optional 
rsnapshot_1.4.2.orig.tar.gz
 a2449acde617ac066bbc0f313cce643c 15644 utils optional 
rsnapshot_1.4.2-1.debian.tar.xz
 c59245553c1650df72039c44348347cf 130368 utils optional 
rsnapshot_1.4.2-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Signed by Ana Guerrero

iQIcBAEBCAAGBQJW96cQAAoJELNGT4lqoVlI+oUP/2mywSMeIk5saQPrwZlIjn8H
fba2yaF4E1+O5G7WiKEuUAubjOabUFbjUMldmXh6e6hnDljjLo73OoqI3XNKhAkG
hHihe7wkVjfYTp3L6gv9HBxMcp1A7zKw3Cb/kupJeDXoXPnBwVEMgRLtBQ9JbdiY
j8LJZpBJqpHxPaCurUReBafbJGYt6ePWdxCA6gi7/PBPCe1k899X9i4PvZHHNI2H
RjuY9wiPVCX4B7n70Z8F7V/kI2qEoMPxMSaYbkB1ClvDgcotSbfPIB7u/D0OYfzr
15sfq7VtlcFkwCj093kYGvRG7k0rY3u28EJiEQKU7V77La+kzu8guTvEWVSH04Z6
jH099sGtV4M/isRo/6kkXaWCCSZpLewx5t+ZgOIym6nVrgem0YC/t1PjHM00TOCm
GIZ53rXNxUOnIxGlYCw37pDzigCZxwoLUrp6ExaCs2SSxvMK7SSE5GRRDUV85okk
9Y5cxVOWAtJsGToVonIJXERzZG4qq+UhVODdedWHMeZXcudP8StQSUsjE8x8s+96
l+RvCT+7XIiet0DmNWTLRF6Ff9rkV2HJsPQoZ7tsIV+5K4+5Inard45PQgYT4zEZ
ACTebs5q43bVYs+6MkNvmsueWM8CACMMNe4RXw26mPjwus9zKK0cNKWp2rYKQye1
jbjkfyIFlfP6VTweXMiX
=43nE
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to