Your message dated Mon, 26 Jun 2017 14:33:44 -0700
with message-id <20170626213237.ga161...@aiede.mtv.corp.google.com>
and subject line Re: dgit clone dies with "setup_git_env called without
repository"
has caused the Debian Bug report #865872,
regarding git config --local in non-repo now bombs out
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
865872: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=865872
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
package: dgit
version: 3.10
dgit problem:
% dgit -D clone network-manager-strongswan sid
fatal: BUG: setup_git_env called without repository
dgit: failed command: git config -z --get-regexp --local '.*'
dgit: subprocess failed with error exit status 128
Output of "printenv | sort" is attached.
Regards
Harri
CCACHE_DIR=/var/tmp/.ccache
CCACHE_HARDLINKS=1
CCACHE_TEMPDIR=/var/tmp/.ccache
CCACHE_UMASK=0
CHROMIUM_FLAGS=--ssl-version-min=tls1
--cipher-suite-blacklist=0xc007,0xc011,0x0005,0x0004
DBUS_SESSION_BUS_ADDRESS=unix:abstract=/tmp/dbus-6D94iG3gEN,guid=04875397619c644082d8d560594f375b
DEBEMAIL=ha...@afaics.de
DEBFULLNAME=Harald Dunkel
DEBKEY=1F657AD782DB47FBB53BE6B50A9E2A9E66D381CB
DEBSIGN_KEYID=1F657AD782DB47FBB53BE6B50A9E2A9E66D381CB
DEB_SIGN_KEYID=1F657AD782DB47FBB53BE6B50A9E2A9E66D381CB
DISPLAY=:4
DOMAINNAME=afaics.de
EDITOR=/usr/bin/emacs
EMACS=/usr/bin/emacs
EMAIL=ha...@afaics.de
FVWM_DATADIR=/usr/share/fvwm
FVWM_MODULEDIR=/usr/lib/fvwm/2.6.7
FVWM_USERDIR=/home/harri/.fvwm
GDK_CORE_DEVICE_EVENTS=1
GPGKEY=1F657AD782DB47FBB53BE6B50A9E2A9E66D381CB
GPG_TTY=/dev/pts/5
HOME=/home/harri
HOSTDISPLAY=cecil.afaics.de:4
HUSHLOGIN=TRUE
INITRD_OK=true
KEMAIL=ha...@afaics.de
LANG=C
LC_ALL=C
LESS=-iMXRS
LESSCHARSET=iso8859
LESSCLOSE=/usr/bin/lesspipe %s %s
LESSOPEN=| /usr/bin/lesspipe %s
LOGNAME=harri
MAIL=/var/mail/harri
MAILHOST=tweety
MANPATH=/home/harri/man:/usr/share/man
OLDPWD=/home/harri
ORIGPATH=/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
PAGER=/usr/bin/less
PATH=/home/harri/bin:/usr/local/bin:/usr/local/sbin:/usr/bin:/usr/sbin:/bin:/sbin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
PILOTPORT=usb:
PRINTER=lp
PWD=/tmp
QUILT_PATCHES=debian/patches
QUILT_REFRESH_ARGS=-p ab --no-timestamps --no-index
QUOTING_STYLE=literal
RSYNC_RSH=ssh -S none -x
SHELL=/bin/bash
SHLVL=4
SIGNCHANGES=true
SSH_AGENT_PID=2135
SSH_AUTH_SOCK=/tmp/ssh-LT5dDN4iFldX/agent.2133
S_COLORS=auto
TAPE=/dev/null
TERM=xterm
USER=harri
VIRSH_DEFAULT_CONNECT_URI=qemu:///system
VISUAL=/usr/bin/emacs
WINDOWID=41943076
WINDOWPATH=2
WINEDITOR=/usr/bin/emacs
XAUTHORITY=/home/harri/.Xauthority
XDG_CACHE_HOME=/tmp/harri/.cache
XDG_CURRENT_DESKTOP=GNOME
XRSH_RSH=ssh
XTERM_LOCALE=C
XTERM_SHELL=/bin/bash
XTERM_VERSION=XTerm(330)
_=/usr/bin/printenv
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Version: 1:2.13.2
severity 865863 serious
quit
Hi Ian,
Ian Jackson wrote:
> Control: clone -1 -2
> Control: reassign -2 git
> Control: severity -2 serious
> Control: retitle -2 git config --local in non-repo now bombs out
> Control: retitle -1 dgit 3.10 and earlier not compatible with git 2.12-ish
Please cc g...@packages.debian.org the next time you do this. Otherwise
the message doesn't show up in mail.
> Hi. We have tripped over an accidental and incompatible change in the
> behaviour of git config --local:
>
> $ pwd
> /home/ian
> $ dpkg -s git | grep '^Version'
> Version: 1:2.13.1-1
> $ git config --local --get-regexp '.*'
> fatal: BUG: setup_git_env called without repository
> $ echo $?
> 128
Thanks for reporting. This is fixed by v2.13.2~26^2~1:
commit 25cd291963e4b0fae0eabe7fe02be693702d79bb
Author: Jeff King <p...@peff.net>
Date: Fri May 12 23:29:31 2017 -0400
config: complain about --local outside of a git repo
The "--local" option instructs git-config to read or modify
the repository-level config. This doesn't make any sense if
you're not actually in a repository.
Older versions of Git would blindly try to read or write
".git/config". For reading, this would result in a quiet
failure, since there was no config to read (and thus no
matching config value). Writing would generally fail
noisily, since ".git" was unlikely to exist. But since
b1ef400ee (setup_git_env: avoid blind fall-back to ".git",
2016-10-20), we catch this in the call to git_pathdup() and
die with an assertion.
Dying is the right thing to do, but we should catch the
problem early and give a more human-friendly error message.
Note that even without --local, git-config will sometimes
default to using local repository config (e.g., when
writing). These cases are already protected by similar
checks, and covered by a test in t1308.
Signed-off-by: Jeff King <p...@peff.net>
Signed-off-by: Junio C Hamano <gits...@pobox.com>
[...]
> Please would you consider returning to the previous behaviour, for
> compatibility with other existing callers of git.
I don't think that that is the right thing to do. The old behavior
was accidental and broken. If you simply omit the --local option then
I think that will give you the behavior you are looking for (if I
understand what you are looking for correctly).
That said, I am happy to add a 'Breaks' to ensure smooth upgrades.
Let me know what version to add a Breaks against and I'll add it.
Also, if you have ideas for clarifying the documentation then that
would also be welcome.
Thanks, sincerely,
Jonathan
--- End Message ---
