Bug#918916: [DRE-maint] Bug#918916: Unicorn not reporting proper version for gemfile?

2019-01-13 Thread Hleb Valoshka
On 1/13/19, Julian Calaby wrote: > As a workaround, changing _both_ versions in the shipped gemspec and the > version in the filename from 0 to 5.4.1 fixes packages which depend on > this, e.g. gitlab. Thanks for the hint. Actually the problem was in d/rules file.

Bug#918916: Unicorn not reporting proper version for gemfile?

2019-01-12 Thread Julian Calaby
Package: unicorn Version: 5.4.1-1 Followup-For: Bug #918916 For reference: As a workaround, changing _both_ versions in the shipped gemspec and the version in the filename from 0 to 5.4.1 fixes packages which depend on this, e.g. gitlab. Detailed steps: 1. Edit /usr/share/rubygems-integration/2

Bug#918916: Unicorn not reporting proper version for gemfile?

2019-01-12 Thread Hleb Valoshka
On 1/12/19, Dominik George wrote: >>The problem is not in Unicorn. The problem is in gem2deb which >>generated incorrect unicorn-0.gemspec for the package. > > OK... But, why was it fixed when I rebuilt with the patch? Different gem2deb versions? Have you tried to rebuild it without that patch?

Bug#918916: Unicorn not reporting proper version for gemfile?

2019-01-12 Thread Dominik George
>I've checked debian's git, this patch was introduced when >ENV["VERSION"] was required to use the gemspec. Now as the upstream >gemspec provides the same it's not required. > >The problem is not in Unicorn. The problem is in gem2deb which >generated incorrect unicorn-0.gemspec for the package. OK

Bug#918916: Unicorn not reporting proper version for gemfile?

2019-01-12 Thread Hleb Valoshka
On 1/10/19, Eric Wong wrote: >> +- s.version = (ENV['VERSION'] || '5.4.1').dup >> ++ s.version = '5.4.1' > > Why is ignoring ENV['VERSION'] necessary for the Debian build? > I can probably remove that check if desired from the upstream > package before the 5.5.0 release. I've checked debian's g

Bug#918916: Unicorn not reporting proper version for gemfile?

2019-01-10 Thread Eric Wong
(unicorn upstream here, adding unicorn-public to Cc, for context: ) Dominik George wrote: > +--- a/unicorn.gemspec > b/unicorn.gemspec > +@@ -11,7 +11,7 @@ end.compact > + > + Gem::Specification.new do |s| > + s.name = %q{unicorn} > +- s.version = (ENV['