Your message dated Thu, 19 May 2022 15:48:46 +0000
with message-id <e1nriom-0002xi...@fasolo.debian.org>
and subject line Bug#976439: fixed in cwiid 0.6.91-4
has caused the Debian Bug report #976439,
regarding wminput: Aborts with "undefined symbol: PyVarObject_CallFunction"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
976439: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976439
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: wminput
Version: 0.6.91-2+b1
Severity: important
X-Debbugs-Cc: f...@debian.org

Hello Georges,

First of all, thank you so much for adopting cwiid and trying to port it
to Python 3.

I was trying get my Wiimote to work with RetroArch / RetroPie, and was
following guides such as https://retropie.org.uk/docs/Wiimote-Controller/
to get it working, but when it comes time to run wminput, I was greeted
with the following error:

    $ wminput
    ImportError: 
/usr/lib/python3/dist-packages/cwiid.cpython-39-x86_64-linux-gnu.so:
    undefined symbol: PyVarObject_CallFunction

After some investigation, I suspect PyObject_CallFunction is not
supposed to be renamed to PyVarObject_CallFunction even for porting
from Python 2 to Python 3.

Looking further, it seems that the port to Python 3 has already been
done by Thomas Vitureau (a.k.a. azzra):

 Port of python-cwiid compatible with Python3
  * https://pypi.org/project/cwiid/
  * https://github.com/azzra/python3-wiimote

Azzra based his work on Cwiid author Donnie Smith's own repository
on GitHub at https://github.com/abstrakraft/cwiid , though probably for
simplicity sake or for building a pure Python 3 module, Azzra decided to
"Delete lswm, wmdemo, wminput, wmgui" from his python3-wiimote fork.

Incidentally, there is a fork of Cwiid by Ivica Ico Bukvic and friends
from Virgina Tech's L2Ork (Linux Laptop Orchestra):

  * https://github.com/pd-l2ork/cwiid

though unfortunately it was forked before Donnie Smith converted his
repo from svn to git, and there is essentially no commit history found
in pd-l2ork/cwiid, and despite some contributed Python 3 related pull
request, it fails to build successfully with Python 3 out of the box.


So, what is the way forward?

As a working Python 3 port already exists, I propose updating the Debian
cwiid package with these existing works, though I admit that it would
require some work to cherry-pick from azzra's python3-wiimote repo and
to get wminput working with the Python-related code changes.

Here are my recommendation:

 1. Start by upgrading Debian's cwiid with Donnie Smith's latest code.
    I suggest modifying debian/watch to track his repo like so:

        version=4
        opts="mode=git, pgpmode=none, pretty=0.6.91+git%cd.%h" \
            https://github.com/abstrakraft/cwiid.git \
            HEAD debian

    and run e.g. "gbp import-orig --sign-tags --uscan" to upgrade to
    this latest upstream snapshot from 2010.

 2. Then, choose one of the following:

     a) Cherry-pick and modify the new commits from
        https://github.com/azzra/python3-wiimote/commits/master
        and place them in debian/patches/, or

     b) Fork https://github.com/abstrakraft/cwiid as
        https://github.com/Debian/cwiid (for example)
        to merge azzra/python3-wiimote while keeping lswm, wminput, etc.

     c) Build Debian's cwiid (from abstrakraft/cwiid) without Python 3
        support, and package azzra/python3-wiimote as a separate source
        package producing the python3-cwiid binary package.

What do you think?  :-)

If you like, I would be very happy to collaborate too if time allows.

Cheers,

Anthony

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.9.0-3-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages wminput depends on:
ii  libbluetooth3  5.55-1
ii  libc6          2.31-4
ii  libcwiid1      0.6.91-2+b1
ii  libpython3.9   3.9.0-5
ii  python3-cwiid  0.6.91-2+b1

wminput recommends no packages.

wminput suggests no packages.

-- Configuration Files:
/etc/cwiid/wminput/gamepad changed [not included]

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: cwiid
Source-Version: 0.6.91-4
Done: Georges Khaznadar <georg...@debian.org>

We believe that the bug you reported is fixed in the latest version of
cwiid, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 976...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Georges Khaznadar <georg...@debian.org> (supplier of updated cwiid package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 19 May 2022 17:04:35 +0200
Source: cwiid
Architecture: source
Version: 0.6.91-4
Distribution: unstable
Urgency: medium
Maintainer: Georges Khaznadar <georg...@debian.org>
Changed-By: Georges Khaznadar <georg...@debian.org>
Closes: 976439
Changes:
 cwiid (0.6.91-4) unstable; urgency=medium
 .
   * applied Bernd Zeimetz' merge request, thanks! Closes: #976439
Checksums-Sha1:
 ce9ca63446e023b2c93593fa8cc6bdc58100e604 2181 cwiid_0.6.91-4.dsc
 2078cc18fee9cf222dc4bf1ca6f3cc1f8ad825cb 26688 cwiid_0.6.91-4.debian.tar.xz
 71b8d6e005d41b6a508f2b69594cd124ddf43130 13808 cwiid_0.6.91-4_amd64.buildinfo
Checksums-Sha256:
 e1d6f7864795aaff4a68364fa62d0a5f53ee296d864221a93bc1d0f825f7e43f 2181 
cwiid_0.6.91-4.dsc
 fdb08df25a4b35d50b9f6a94b75777aa2f3d145dfdf1d0490cb5a8b297486bb8 26688 
cwiid_0.6.91-4.debian.tar.xz
 384e8e67e439f9be78a80cfd132a87031774823cd40693709e2141210d6501eb 13808 
cwiid_0.6.91-4_amd64.buildinfo
Files:
 f5549b58529106f53f75655889fc7379 2181 utils optional cwiid_0.6.91-4.dsc
 80aad97aa6f2337d53118abb60a12968 26688 utils optional 
cwiid_0.6.91-4.debian.tar.xz
 a3232d4459d2d6213104c857c1a64a42 13808 utils optional 
cwiid_0.6.91-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEM0CzZP9nFT+3zK6FHCgWkHE2rjkFAmKGYVoACgkQHCgWkHE2
rjkx0g//RzFP6j8lJFrto1kyEwnd2LQ1D6Z0KIPWvYwJTmxo0mnq5jhzC9QuetZZ
32kb8dObxkICsOhGVJchV97k5SEA6GEwdOchr5q+ntcxsZGTb4GFve/73DHFAAr5
g639i2abfC5KifKPyYahsrIgBeDvnraSC8b53JqLFe2uxaS3r3l1tsnSkUArUYUx
4YnjhXm0wPhKeTCyecYyF42/2R361bo1JKu56HRfTEeRp1UjkJYbt6bsUvPYnxCZ
oVv3vOUo4wAmjB3cjjU2nBBQTT3LA3ALf9/TuMqYSW4ARsgdfPZQ2145T+YS6fA0
U4eI9/5/RfNf+XMaJYtOBpoVrQGffLI37i1SMscu+1koiq319VwQRnLjrchgD3lD
ctx4B0eWmvmFFSiGaJCDhB1EvFHOT/aBdDciykr2pNgTTf3jA01wfu/vEAs/PlgI
b3dTr+3onhR9OBZCt3V6y/xg34lvk2jVDYCuqO6GoFpnAgKw/MqozxGcwiX0E92O
Eps3+N0htTq5PLM+MnGKE2BC7l6tXeZ4Xe3aWb3iQkGkWe/IJY1xT7D4jQ0JKEdB
TwDu7naboRLGPaM6Dbbtx5EiSWeFbDVURIPCofZCUSWMfiz5eKKhDMW2dS49Ba5e
JGrQAEFwxl1Onqt9ol0JfR9ji9AeZQt88tAnzqn/Wzl0ubPxaEo=
=JjAz
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to