Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-28 Thread Sébastien Villemot
On Tue, Nov 28, 2017 at 03:53:24AM -0500, Anthony DeRobertis wrote: > On 11/26/2017 02:38 PM, Sean Whitton wrote: > > > > However, the preferred format of modification is in fact present in the > > zxcvbn-c source package, which builds dict-src.h as part of its package > > build. So I wonder if

Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-28 Thread Anthony DeRobertis
On 11/26/2017 02:38 PM, Sean Whitton wrote: However, the preferred format of modification is in fact present in the zxcvbn-c source package, which builds dict-src.h as part of its package build. So I wonder if you could refer to that package in README.source and it would be enough for the

Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-26 Thread Sean Whitton
Hello Paul, On Sun, Nov 26 2017, Paul Gevers wrote: > If this dict-src.h is (re)build during the building of the package, > there isn't an issue right? That is what I understood was happening. I > may have understood wrong, hence the request for clarification to > Julian. I am pretty sure it is

Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-26 Thread Paul Gevers
Hi Sean, [No need to CC me, I am subscribed to d-devel]. I didn't check the source of keepassxc, so my earlier remark was based on assumptions. On 26-11-17 20:39, Sean Whitton wrote: > On Sun, Nov 26 2017, Paul Gevers wrote: > >> I would copy the directory to some tmp folder in debian/ during

Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-26 Thread Sean Whitton
Hello Julian, On Sun, Nov 26 2017, Julian Andres Klode wrote: > The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, > generated from smaller files. The directory is removed during build. I see that you are linking against libzxcvbn0. So, just to confirm, the whole src/zxcvbn/

Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-26 Thread Sean Whitton
Hello Paul, On Sun, Nov 26 2017, Paul Gevers wrote: > I would copy the directory to some tmp folder in debian/ during the > configure step (if not done before) and move it back during the clean > step (and copy it from debian/ in the step where you are building > src/zxcvbn/dict-src.h). > > I

Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-26 Thread Julian Andres Klode
On Sun, Nov 26, 2017 at 07:45:13AM +0100, Paul Gevers wrote: > Hi Julian, > > On 26-11-17 01:29, Julian Andres Klode wrote: > > The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, > > generated from smaller files. The directory is removed during build. > > Are you saying that

Re: Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-25 Thread Paul Gevers
Hi Julian, On 26-11-17 01:29, Julian Andres Klode wrote: > The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, > generated from smaller files. The directory is removed during build. Are you saying that these smaller files are in the tar ball, but after one build the files are

Bug#882723: src:keepassxc: Generated file without preferred form of source: src/zxcvbn/dict-src.h

2017-11-25 Thread Julian Andres Klode
Package: src:keepassxc Severity: serious The file src/zxcvbn/dict-src.h is an autogenerated dictionary file, generated from smaller files. The directory is removed during build. I'm not entirely sure if I need to repackage the source tarball or not, given that the file is removed during clean,