Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-26 Thread Jonas Smedegaard
Quoting Thomas Goirand (2022-02-26 00:08:47) > On 2/25/22 11:38, Philip Hands wrote: > > Having looked at how it was done, I applaud Andreas for doing a > > proper job. > > +1 > > Anyone complaining about this kind of contribution to Debian is a > moron and a barrier to progress. We really

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Thomas Goirand
On 2/25/22 11:38, Philip Hands wrote: Having looked at how it was done, I applaud Andreas for doing a proper job. +1 Anyone complaining about this kind of contribution to Debian is a moron and a barrier to progress. We really need to get rid of this toxic mentality in Debian. Jonas, I

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Andreas Tille
Hi Paul, Am Fri, Feb 25, 2022 at 08:49:00PM +0100 schrieb Paul Gevers: > On 25-02-2022 15:02, Andreas Tille wrote: > > My point was rather that the suggested salvage procedure might not raise > > any signal and I'm pretty sure that I would have lost track on this. > > Everybody is now free to

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Paul Gevers
Hi all, Thanks Andreas, for taking care. On 25-02-2022 15:02, Andreas Tille wrote: My point was rather that the suggested salvage procedure might not raise any signal and I'm pretty sure that I would have lost track on this. Everybody is now free to help and fix the autopkgtest regression

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Andreas Tille
Am Fri, Feb 25, 2022 at 12:09:26PM +0100 schrieb Jonas Smedegaard: > > Please note that "has no RC bugs" is *NOT* the threshold for NMUs, and > certainly not if your approach to doing the NMU involved package > refactoring: When you do an NMU, it is your responsibility to ensure > that your

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Jonas Smedegaard
Quoting Philip Hands (2022-02-25 11:38:25) > Jonas Smedegaard writes: > > ... > > Yes, which means you can fast-track for *THAT* reason - unrelated to > > code smell, which is specifically what I was talking about. > > I understand that you were reacting to the idea that one can just > stomp

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Jonas Smedegaard
Quoting Andreas Tille (2022-02-25 10:43:42) > Am Fri, Feb 25, 2022 at 10:35:43AM +0100 schrieb Johannes Schauer > Marin Rodrigues: > > Is this not something that can be solved by salvaging [1] the > > package in question? > > My question is targeting in this direction since salvaging is what we

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Jonas Smedegaard
Quoting Philip Hands (2022-02-25 10:09:29) > Andreas Tille writes: > > > Am Thu, Feb 24, 2022 at 11:58:12PM +0900 schrieb Osamu Aoki: > >> > This is probably very academic now since Andreas Tille has > >> > uploaded a fixed xdelta3 package today. > >> > >> Now that I know that the new xdelta3

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Philip Hands
Jonas Smedegaard writes: ... > Yes, which means you can fast-track for *THAT* reason - unrelated to > code smell, which is specifically what I was talking about. I understand that you were reacting to the idea that one can just stomp on the existing packaging simply because it "smells bad",

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Jonas Smedegaard
Quoting Bastian Blank (2022-02-25 10:04:46) > On Fri, Feb 25, 2022 at 09:50:18AM +0100, Jonas Smedegaard wrote: > > I would certainly be frustrated if someone fast-tracked an NMU with > > structural changes like switching to short-form dh, with the > > reasoning that "the packaged had a smell to

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Andreas Tille
Am Fri, Feb 25, 2022 at 09:50:18AM +0100 schrieb Jonas Smedegaard: > > Given the fact that there was a nearly 4 year old patch (#895957) made > > me feel that I'm not alone with this but on the other hand the creator > > of the patch (thanks Jeremy for doing at least half of the necessary > >

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Andreas Tille
Hi Philip, Am Fri, Feb 25, 2022 at 10:09:29AM +0100 schrieb Philip Hands: > > FWIW I also started work on xdelta3 when I saw the removal warning for > installation-guide, but when I got to the point of creating a repo on > salsa you'd beaten me to it by about an hour :-) Nice. ;-) May be I

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Andreas Tille
Am Fri, Feb 25, 2022 at 10:35:43AM +0100 schrieb Johannes Schauer Marin Rodrigues: > Is this not something that can be solved by salvaging [1] the package in > question? My question is targeting in this direction since salvaging is what we somehow agreed upon. > Do a tiny NMU fixing an RC bug

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Johannes Schauer Marin Rodrigues
Quoting Andreas Tille (2022-02-25 09:22:38) > I had to decide between a "proper NMU" and an "upload that fits the packaging > standards I apply to what I upload" (which includes maintained on Salsa, > usage of dh, DEP5 copyright ... basically removing the smell from the > package). I decided for

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Bastian Blank
Hi On Fri, Feb 25, 2022 at 09:50:18AM +0100, Jonas Smedegaard wrote: > I would certainly be frustrated if someone fast-tracked an NMU with > structural changes like switching to short-form dh, with the reasoning > that "the packaged had a smell to it", for a package that I maintain. Well, do

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Philip Hands
Andreas Tille writes: > Am Thu, Feb 24, 2022 at 11:58:12PM +0900 schrieb Osamu Aoki: >> > This is probably very academic now since Andreas Tille has uploaded a >> > fixed >> > xdelta3 package today. >> >> Now that I know that the new xdelta3 is uploaded, I am OK.   > > BTW, I stumbled upon

Re: Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Jonas Smedegaard
Quoting Andreas Tille (2022-02-25 09:22:38) > Am Thu, Feb 24, 2022 at 11:58:12PM +0900 schrieb Osamu Aoki: > > > This is probably very academic now since Andreas Tille has > > > uploaded a fixed xdelta3 package today. > > > > Now that I know that the new xdelta3 is uploaded, I am OK.   > > BTW,

Is removing smell from packages OK? (Was: Why? "Marked for autoremoval on 24 March due to xdelta3: #965883")

2022-02-25 Thread Andreas Tille
Am Thu, Feb 24, 2022 at 11:58:12PM +0900 schrieb Osamu Aoki: > > This is probably very academic now since Andreas Tille has uploaded a fixed > > xdelta3 package today. > > Now that I know that the new xdelta3 is uploaded, I am OK.   BTW, I stumbled upon xdelta3 since also a package of mine