Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-22 Thread Bas Wijnen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, Mar 22, 2016 at 09:26:45PM +0100, Santiago Vila wrote: > I think the issue is not really whether HAVE_DOT=yes is good or not > in general, but whether this is an issue that should be decided on a > per package basis or not. I agree, that is

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-22 Thread Santiago Vila
On Tue, Mar 22, 2016 at 04:44:07PM +, Bas Wijnen wrote: > On Tue, Mar 22, 2016 at 05:04:50PM +0100, Santiago Vila wrote: > > So the number of affected packages if the default HAVE_DOT is changed > > to "no" would be quite low. > > > > If, instead, doxygen is changed to depend on graphviz,

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-22 Thread Bas Wijnen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, Mar 22, 2016 at 05:04:50PM +0100, Santiago Vila wrote: > So the number of affected packages if the default HAVE_DOT is changed > to "no" would be quite low. > > If, instead, doxygen is changed to depend on graphviz, there would be > nothing

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-22 Thread Santiago Vila
On Tue, Mar 22, 2016 at 10:45:46AM +0100, Santiago Vila wrote: > many packages which currently call "dot" during the build will > probably stop doing so. I confirm this. From the 60 packages posted by Adam, there are 57 of them which are also in testing. I've rebuilt those using a modified

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-22 Thread Santiago Vila
On Tue, Mar 22, 2016 at 07:08:39AM +0100, Adam Borowski wrote: > On Sun, Mar 20, 2016 at 08:07:55PM +0100, Adam Borowski wrote: > > I've started a rebuild of all 552 packages in unstable that build-depend on > > doxygen > > Here are the results: 60 packages call /usr/bin/dot without depending on

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-22 Thread Adam Borowski
On Sun, Mar 20, 2016 at 08:07:55PM +0100, Adam Borowski wrote: > > In other words, my solution to this bug would be to make doxygen exit with > > an > > error code when calling dot fails. Then make will fail, it's an FTBFS, it > > gets > > fixed, and everyone is happy. > > I've started a

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-21 Thread Bas Wijnen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, Mar 21, 2016 at 11:26:16AM +0100, Santiago Vila wrote: > > Yes, so that's a bug in those programs, not in doxygen. It would be > > "fixed" by > > adding graphviz as a Depends to doxygen, but that would be incorrect. > > Please note that it

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-21 Thread Santiago Vila
On Mon, Mar 21, 2016 at 05:04:24AM +, Bas Wijnen wrote: > On Sun, Mar 20, 2016 at 08:07:55PM +0100, Adam Borowski wrote: > > On Sun, Mar 20, 2016 at 06:51:23PM +, Bas Wijnen wrote: > > > That also means that programs calling dot will need graphviz in their > > > Build-Depends, no matter

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-20 Thread Bas Wijnen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sun, Mar 20, 2016 at 08:07:55PM +0100, Adam Borowski wrote: > On Sun, Mar 20, 2016 at 06:51:23PM +, Bas Wijnen wrote: > > That also means that programs calling dot will need graphviz in their > > Build-Depends, no matter what the default is. >

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-20 Thread Adam Borowski
On Sun, Mar 20, 2016 at 06:51:23PM +, Bas Wijnen wrote: > That also means that programs calling dot will need graphviz in their > Build-Depends, no matter what the default is. As is, a number of them do call dot without the build-dependency. > > But this is inconsistent with having graphviz

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-20 Thread Bas Wijnen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I think you are mistaken about a few things. On Sun, Mar 20, 2016 at 06:04:55PM +0100, Santiago Vila wrote: > The maintainer points out that the default value for HAVE_DOT is NO, > so he's reluctant to add the build-dependency. If the program can be

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-20 Thread Santiago Vila
Ok, this is postponed for now. One of the bugs I was going to report was already reported: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=778478 The maintainer points out that the default value for HAVE_DOT is NO, so he's reluctant to add the build-dependency. But this is only true in

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-20 Thread Santiago Vila
On Sun, Mar 20, 2016 at 02:31:23PM +0100, Christian Seiler wrote: > There are 358 packages in unstable that currently have B-D/B-D-I: doxygen > but no B-D/B-D-I: graphviz. But my guess is that not all of them (probably > not even most of them) actually run dot during Doxygen build. > > Of those,

Re: Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-20 Thread Christian Seiler
On 03/20/2016 01:52 PM, Santiago Vila wrote: > There seems to be more than ten packages which: > > * Have doxygen in Build-Depends. > * Do not have graphviz in Build-Depends. > * Try to run "dot" during the build. > * The build does not fail because doxygen keeps working as if > nothing bad

Mass Bug Filing: Missing Build-Depends: graphviz

2016-03-20 Thread Santiago Vila
Greetings. There seems to be more than ten packages which: * Have doxygen in Build-Depends. * Do not have graphviz in Build-Depends. * Try to run "dot" during the build. * The build does not fail because doxygen keeps working as if nothing bad happened, violating Policy 4.6. (This is already