Re: Require packages to build without any configured DNS

2021-09-14 Thread Scott Kitterman
On September 14, 2021 5:16:51 PM UTC, Johannes Schauer Marin Rodrigues wrote: >Quoting Mattia Rizzolo (2021-09-14 15:34:36) >> On Tue, Sep 14, 2021 at 10:05:01AM +0200, Johannes Schauer Marin Rodrigues >> wrote: >> > Hi, >> > >> > Quoting Mattia Rizzolo (2021-09-06 16:39:39) >> > > As the pb

Re: Require packages to build without any configured DNS

2021-09-14 Thread Johannes Schauer Marin Rodrigues
Quoting Mattia Rizzolo (2021-09-14 15:34:36) > On Tue, Sep 14, 2021 at 10:05:01AM +0200, Johannes Schauer Marin Rodrigues > wrote: > > Hi, > > > > Quoting Mattia Rizzolo (2021-09-06 16:39:39) > > > As the pbuilder maintainer, I've been asked to make it serve a non-working > > > /etc/resolv.conf j

Re: Require packages to build without any configured DNS

2021-09-14 Thread Mattia Rizzolo
On Tue, Sep 14, 2021 at 10:05:01AM +0200, Johannes Schauer Marin Rodrigues wrote: > Hi, > > Quoting Mattia Rizzolo (2021-09-06 16:39:39) > > As the pbuilder maintainer, I've been asked to make it serve a non-working > > /etc/resolv.conf just to make that bug above moot, so I'm quite biased on >

Re: Require packages to build without any configured DNS

2021-09-14 Thread Adrian Bunk
On Mon, Sep 13, 2021 at 04:05:57PM -0700, Don Armstrong wrote: > On Fri, 10 Sep 2021, Adrian Bunk wrote: > > On Wed, Sep 08, 2021 at 09:01:31AM -0700, Josh Triplett wrote: > > >... > > > I think dnspython's previous approach was correct: just like glibc, musl, > > > and > > > other libraries, if /

Re: Require packages to build without any configured DNS

2021-09-14 Thread Johannes Schauer Marin Rodrigues
Hi, Quoting Mattia Rizzolo (2021-09-06 16:39:39) > As the pbuilder maintainer, I've been asked to make it serve a non-working > /etc/resolv.conf just to make that bug above moot, so I'm quite biased on the > matter myself :) sbuild already disables network access for all chroot backends that supp

Re: Require packages to build without any configured DNS

2021-09-13 Thread Don Armstrong
On Fri, 10 Sep 2021, Adrian Bunk wrote: > On Wed, Sep 08, 2021 at 09:01:31AM -0700, Josh Triplett wrote: > >... > > I think dnspython's previous approach was correct: just like glibc, musl, > > and > > other libraries, if /etc/resolv.conf is missing they should treat that as > > though it specifie

Re: Require packages to build without any configured DNS

2021-09-12 Thread Josh Triplett
Thomas Goirand wrote: > On 9/10/21 10:53 AM, Josh Triplett wrote: > > Thomas Goirand wrote: > >> On 9/8/21 6:01 PM, Josh Triplett wrote: > >>> Now, that said, if the build process actually wants a DNS server to > >>> run tests against, it should provide or depend on such a DNS server, > >>> and con

Re: Require packages to build without any configured DNS

2021-09-12 Thread Thomas Goirand
On 9/10/21 10:53 AM, Josh Triplett wrote: > Thomas Goirand wrote: >> On 9/8/21 6:01 PM, Josh Triplett wrote: >>> Now, that said, if the build process actually wants a DNS server to >>> run tests against, it should provide or depend on such a DNS server, >>> and configure it for such tests. >> >> Ju

Re: Require packages to build without any configured DNS

2021-09-12 Thread Thomas Goirand
On 9/9/21 9:07 AM, Adrian Bunk wrote: > On Thu, Sep 09, 2021 at 04:45:35AM +, Paul Wise wrote: >> ... >> That seems like a bug in the test cases, they shouldn't be testing the >> build time environment like that, since it could differ from the >> runtime environment. > > These are usually not

Re: Require packages to build without any configured DNS

2021-09-10 Thread Adrian Bunk
On Wed, Sep 08, 2021 at 09:01:31AM -0700, Josh Triplett wrote: >... > I think dnspython's previous approach was correct: just like glibc, musl, and > other libraries, if /etc/resolv.conf is missing they should treat that as > though it specified a nameserver on localhost. How libraries implement a

Re: Require packages to build without any configured DNS

2021-09-10 Thread Josh Triplett
Thomas Goirand wrote: > On 9/8/21 6:01 PM, Josh Triplett wrote: > > Now, that said, if the build process actually wants a DNS server to > > run tests against, it should provide or depend on such a DNS server, > > and configure it for such tests. > > Just to be 100% sure we're on the same page: tha

Re: Require packages to build without any configured DNS

2021-09-09 Thread Adrian Bunk
On Thu, Sep 09, 2021 at 04:45:35AM +, Paul Wise wrote: >... > That seems like a bug in the test cases, they shouldn't be testing the > build time environment like that, since it could differ from the > runtime environment. These are usually not the tests of dnspython. dnspython even has some

Re: Require packages to build without any configured DNS

2021-09-08 Thread Paul Wise
On Wed, Sep 8, 2021 at 9:51 PM Pirate Praveen wrote: > I don't think the default autopkgtest environment should be as > restrictive as the build environment. So adding this to default > autopkgtest enviroment is not the same as adding it to default build > environment. It is already the case that

Re: Require packages to build without any configured DNS

2021-09-08 Thread Paul Wise
On Wed, Sep 8, 2021 at 8:23 PM Thomas Goirand wrote: > Later on, the class calls the method read_resolv_conf that has: It also fails if the file exists but has no nameservers: if len(self.nameservers) == 0: raise NoResolverConfiguration > So, any test case that does that fai

Re: Require packages to build without any configured DNS

2021-09-08 Thread Pirate Praveen
On ബു, സെപ്റ്റം 8 2021 at 06:10:56 വൈകു +0300 +0300, Adrian Bunk wrote: On Wed, Sep 08, 2021 at 07:57:20PM +0530, Pirate Praveen wrote: On ബു, സെപ്റ്റം 8 2021 at 04:18:46 വൈകു +0200 +0200, Thomas Goirand wrote: > Therefore, I am in the opinion that we should let the package run its > t

Re: Require packages to build without any configured DNS

2021-09-08 Thread Thomas Goirand
On 9/8/21 5:44 PM, Helmut Grohne wrote: > As such, I err on dnspython being in need of a fix. Dnspython isn't broken in any ways, it doesn't do any network access. The only thing you're going to achieve is: - more work for the maintainers (who will need to disable or patch the tests). - probably l

Re: Require packages to build without any configured DNS

2021-09-08 Thread Adrian Bunk
On Wed, Sep 08, 2021 at 05:44:34PM +0200, Helmut Grohne wrote: > On Mon, Sep 06, 2021 at 04:39:39PM +0200, Mattia Rizzolo wrote: > > Do anybody on the list have any opinion on where is the bug, on > > dnspython, or on the build environment? > > I concur that the absence of /etc/resolv.conf is a se

Re: Require packages to build without any configured DNS

2021-09-08 Thread Josh Triplett
Mattia Rizzolo wrote: > during the year, a src:dnspython change made it so that any software > importing that library now requires a valid /etc/resolv.conf with at > least one nameserver configured. > > This also made it so that something between 50-100 packages now fail to > build if the build sy

Re: Require packages to build without any configured DNS

2021-09-08 Thread Helmut Grohne
On Mon, Sep 06, 2021 at 04:39:39PM +0200, Mattia Rizzolo wrote: > Do anybody on the list have any opinion on where is the bug, on > dnspython, or on the build environment? I concur that the absence of /etc/resolv.conf is a sensible configuration. Indeed, it is my method-of-choice for implementing

Re: Require packages to build without any configured DNS

2021-09-08 Thread Adrian Bunk
On Wed, Sep 08, 2021 at 07:57:20PM +0530, Pirate Praveen wrote: > On ബു, സെപ്റ്റം 8 2021 at 04:18:46 വൈകു +0200 +0200, Thomas Goirand > wrote: > > Therefore, I am in the opinion that we should let the package run its > > test as much as possible, especially considering that it's not doing > > act

Re: Require packages to build without any configured DNS

2021-09-08 Thread Pirate Praveen
On ബു, സെപ്റ്റം 8 2021 at 04:18:46 വൈകു +0200 +0200, Thomas Goirand wrote: Therefore, I am in the opinion that we should let the package run its test as much as possible, especially considering that it's not doing actual network outbound connections. Can't we run these tests as autopkgtest

Re: Require packages to build without any configured DNS

2021-09-08 Thread Thomas Goirand
On 9/6/21 4:39 PM, Mattia Rizzolo wrote: > Hi, > > during the year, a src:dnspython change made it so that any software > importing that library now requires a valid /etc/resolv.conf with at > least one nameserver configured. > > This also made it so that something between 50-100 packages now fai

Re: Require packages to build without any configured DNS

2021-09-08 Thread Adrian Bunk
On Tue, Sep 07, 2021 at 04:41:49PM -0700, Don Armstrong wrote: > On Mon, 06 Sep 2021, Mattia Rizzolo wrote: > > It must be noted that no actual network operation happen, so this > > doesn't fall into the "no network activity" bucket. > > > > This is the bug that was filed against dnspython: > > h

Re: Require packages to build without any configured DNS

2021-09-07 Thread Don Armstrong
On Mon, 06 Sep 2021, Mattia Rizzolo wrote: > It must be noted that no actual network operation happen, so this > doesn't fall into the "no network activity" bucket. > > This is the bug that was filed against dnspython: > https://bugs.debian.org/989171 > > Do anybody on the list have any opinion

Require packages to build without any configured DNS

2021-09-06 Thread Mattia Rizzolo
Hi, during the year, a src:dnspython change made it so that any software importing that library now requires a valid /etc/resolv.conf with at least one nameserver configured. This also made it so that something between 50-100 packages now fail to build if the build system doesn't have any working