Re: get-orig-source: possible MBF

2009-10-16 Thread Jonathan Wiltshire
On Thu, Oct 15, 2009 at 11:04:48PM -0300, Felipe Sateler wrote: | This target may be invoked in any directory, and should take care | to clean up any temporary files it may have left. I'm not sure if it is my english at fault here, but don't read this as a must requirement (that

Re: get-orig-source: possible MBF

2009-10-16 Thread Jakub Wilk
* Ben Finney ben+deb...@benfinney.id.au, 2009-10-16, 10:08: c) 15 packages call interactive programs (like lynx); Does your test determine whether this usage is actually invoking the programs interactively? e.g. ‘lynx -dump $URL’ is not interactive. I determined failure reasons by manually

get-orig-source: possible MBF

2009-10-15 Thread Jakub Wilk
I performed an experiment, in which I tried to check if source packages are providing get-orig-source targets that comply with the Debian Policy. Let me quote: | `get-orig-source' (optional) | This target fetches the most recent version of the original | source package from a

Re: get-orig-source: possible MBF

2009-10-15 Thread Bernd Zeimetz
Jakub Wilk wrote: I performed an experiment, in which I tried to check if source packages are providing get-orig-source targets that comply with the Debian Policy. Let me quote: | `get-orig-source' (optional) As long as the policy says optional I can't see a

Re: get-orig-source: possible MBF

2009-10-15 Thread Stefano Zacchiroli
On Thu, Oct 15, 2009 at 01:36:30PM +0200, Bernd Zeimetz wrote: | `get-orig-source' (optional) As long as the policy says optional I can't see a reason for a MBF. I disagree, optionality in policy means that you are not forced to have the g-o-s target. But if

Re: get-orig-source: possible MBF

2009-10-15 Thread Jonathan Wiltshire
On Thu, Oct 15, 2009 at 01:08:19PM +0200, Jakub Wilk wrote: d) 21 packages unnecessarily call dh_testroot; accidentally, all of these packages put tarballs in a wrong directory; f) 368 packages use uscan without --destdir (or even with --destdir ../) [2]; These might be good candidates for a

Re: get-orig-source: possible MBF

2009-10-15 Thread Ben Finney
Jakub Wilk uba...@users.sf.net writes: c) 15 packages call interactive programs (like lynx); Does your test determine whether this usage is actually invoking the programs interactively? e.g. ‘lynx -dump $URL’ is not interactive. -- \ “It is the integrity of each individual human that is

Re: get-orig-source: possible MBF

2009-10-15 Thread Felipe Sateler
On Thu, 2009-10-15 at 14:07 +0200, Stefano Zacchiroli wrote: On Thu, Oct 15, 2009 at 01:36:30PM +0200, Bernd Zeimetz wrote: | `get-orig-source' (optional) As long as the policy says optional I can't see a reason for a MBF. I disagree, optionality in

Re: get-orig-source: possible MBF

2009-10-15 Thread Luke Cycon
On Thu, 2009-10-15 at 23:04 -0300, Felipe Sateler wrote: Note that the policy also says: | This target may be invoked in any directory, and should take care | to clean up any temporary files it may have left. I'm not sure if it is my english at fault here, but don't read this as