Re: service failures should not fail dpkg installation [was: Re: promoting virtualbox-dkms to virtualbox pre-depends]

2015-09-26 Thread Jeroen Dekkers
At Thu, 24 Sep 2015 08:11:48 -0400, Marvin Renich wrote: > > * Jeroen Dekkers [150924 07:23]: > > At Wed, 23 Sep 2015 13:53:11 -0400, > > Marvin Renich wrote: > > > I think it should be documented in the developers reference that if you > > > attempt to start or restart a

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-24 Thread Jeroen Dekkers
At Wed, 23 Sep 2015 13:53:11 -0400, Marvin Renich wrote: > I think it should be documented in the developers reference that if you > attempt to start or restart a service in postinst, you should guard it > so that a failure in the service does not propagate to a failure of the > postinst. But

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-24 Thread Thomas Goirand
On 09/22/2015 06:40 PM, Gianfranco Costamagna wrote: > Pre-Depends: dpkg (>= 1.15.6~) This pre-depend is for ancient version of dpkg (ie: only useful for Precise which did not support xz compression). I'd advise to drop it at this point (I've been dropping it on all of my packages on each

service failures should not fail dpkg installation [was: Re: promoting virtualbox-dkms to virtualbox pre-depends]

2015-09-24 Thread Marvin Renich
* Jeroen Dekkers [150924 07:23]: > At Wed, 23 Sep 2015 13:53:11 -0400, > Marvin Renich wrote: > > I think it should be documented in the developers reference that if you > > attempt to start or restart a service in postinst, you should guard it > > so that a failure in the

Re: service failures should not fail dpkg installation [was: Re: promoting virtualbox-dkms to virtualbox pre-depends]

2015-09-24 Thread Henrique de Moraes Holschuh
On Thu, 24 Sep 2015, Marvin Renich wrote: > How does failing the upgrade solve anything? The upgrade should only > fail if the failure of the service to start was because something in the > upgrade itself was broken; this is rarely the case. ... > What makes this even worse is that when

Re: service failures should not fail dpkg installation [was: Re: promoting virtualbox-dkms to virtualbox pre-depends]

2015-09-24 Thread Paul Gevers
Hi On 24-09-15 18:21, Henrique de Moraes Holschuh wrote: > On Thu, 24 Sep 2015, Marvin Renich wrote: > What we really want is a "do not fail upgrade, BUT report that some services > *that were previously running* failed to restart after the upgrade run". > > ESPECIALLY if you are going to take

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Ritesh Raj Sarraf
On Wed, 2015-09-23 at 13:23 +0200, Ansgar Burchardt wrote: > Gianfranco Costamagna writes: > > the problem actually is that virtualbox-dkms should be configured > > *before* configuring virtualbox > > Why should this need Pre-Depends instead of Depends assuming >

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marc Haber
On Wed, 23 Sep 2015 12:31:22 +0200, Gianfranco Costamagna wrote: >well, in that case you can download the source package, build the dkms >module and then install virtualbox, right? > >if you run a custom kernel you should know how to build a dkms module. Do we now

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Ansgar Burchardt
Gianfranco Costamagna writes: > the problem actually is that virtualbox-dkms should be configured > *before* configuring virtualbox Why should this need Pre-Depends instead of Depends assuming virtualbox depends on the -dkms package? Ansgar

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marvin Renich
* Ritesh Raj Sarraf [150923 07:47]: > On Wed, 2015-09-23 at 13:23 +0200, Ansgar Burchardt wrote: > > Gianfranco Costamagna writes: > > > the problem actually is that virtualbox-dkms should be configured > > > *before* configuring virtualbox > > >

Re: Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Gianfranco Costamagna
well, in that case you can download the source package, build the dkms module and then install virtualbox, right? if you run a custom kernel you should know how to build a dkms module. cheers, G.

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marvin Renich
* Ritesh Raj Sarraf [150923 04:06]: > Adding Moritz from the DSA. > > On Tue, 2015-09-22 at 19:59 +0200, Julien Cristau wrote: > > On Tue, Sep 22, 2015 at 15:00:35 +, Gianfranco Costamagna wrote: > > > > > As shown in policy 7.2 > > > > > > "You should not specify a

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marvin Renich
* Marvin Renich [150923 07:52]: > What might work, ..., and then use dpkg triggers to start the > vbox service after all packages in the dpkg installation run have been > configured. If I understand correctly how dpkg triggers work, this could cause a restart of vbox before the

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Ritesh Raj Sarraf
On Wed, 2015-09-23 at 08:18 -0400, Marvin Renich wrote: > If I understand correctly how dpkg triggers work, this could cause a > restart of vbox before the module is installed, but then it should > also > cause a second restart after it is installed. (I.e. you could get a > spurious failing

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Ritesh Raj Sarraf
On Wed, 2015-09-23 at 15:02 +0200, Marc Haber wrote: > Do we now require DKMS, which requires a fully-blown build system on > the target box? Wouldn't it be much better to be able to build a > virtualbox-modules-$KERNELFLAVOUR.deb? What was so bad with > module-assistant? I think it is still

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Ritesh Raj Sarraf
On Wed, 2015-09-23 at 08:18 -0400, Marvin Renich wrote: > * Marvin Renich [150923 07:52]: > > What might work, ..., and then use dpkg triggers to start the > > vbox service after all packages in the dpkg installation run have > been > > configured. > > If I understand correctly

Re: Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Gianfranco Costamagna
Hi, confirmed: it is still there. cheers, Gianfranco

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Ritesh Raj Sarraf
On Wed, 2015-09-23 at 08:07 -0400, Marvin Renich wrote: > > Also, the same has been discussed in following bug reports. > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798979 > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=798527 > > The logs (that I snipped) were from an installation

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marvin Renich
[please do not CC me; I am subscribed] * Ritesh Raj Sarraf [150923 11:50]: > Okay!! But, btw, can someone enlighten the use case for Pre-Depends ?? If you need to use something from another package in your preinst script, you will need a Pre-Depends. For example, cron

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marc Haber
On Wed, 23 Sep 2015 21:14:13 +0530, Ritesh Raj Sarraf wrote: >On Wed, 2015-09-23 at 15:02 +0200, Marc Haber wrote: >> Do we now require DKMS, which requires a fully-blown build system on >> the target box? Wouldn't it be much better to be able to build a >>

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marvin Renich
* Ritesh Raj Sarraf [150923 12:54]: > > Each call to dpkg will cause the triggers to be run, so if > > apt(itude) happens to separate the vbox and vbox-dkms installations > > into separate runs of dpkg, vbox might be restarted the first time > > with the wrong module, but it will

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Adam Borowski
On Wed, Sep 23, 2015 at 08:17:44PM +0200, Eduard Bloch wrote: > And DKMS... oh, dear. Did they eventually manage to fix it, to not > blindly rely on /lib/modules/.../source (or build) symlinks as the > one and only source of information? Not having those links is like a > normal case with

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Marc Haber
[module-assistant] On Wed, 23 Sep 2015 18:24:54 +0200, Gianfranco Costamagna wrote: >Hi, confirmed: it is still there. The Question is: Is it still supported? Greetings Marc -- -- !! No courtesy copies, please !! - Marc

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Andrey Rahmatullin
On Wed, Sep 23, 2015 at 01:35:21PM +0530, Ritesh Raj Sarraf wrote: > > A pre-depends is very much the wrong hammer here, userspace can't > > usefully rely on a kernel package or module through package > > dependencies. > > Can you please elaborate here ? > > > Problem is: virtualbox is picky

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Ritesh Raj Sarraf
Adding Moritz from the DSA. On Tue, 2015-09-22 at 19:59 +0200, Julien Cristau wrote: > On Tue, Sep 22, 2015 at 15:00:35 +, Gianfranco Costamagna wrote: > > > As shown in policy 7.2 > > > > "You should not specify a Pre-Depends entry for a package before > this has been discussed on the

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-23 Thread Eduard Bloch
Hallo, * Marc Haber [Wed, Sep 23 2015, 07:55:58PM]: > [module-assistant] > > On Wed, 23 Sep 2015 18:24:54 +0200, Gianfranco Costamagna > wrote: > >Hi, confirmed: it is still there. > > The Question is: Is it still supported? I just typed "m-a a-i virtualbox" and

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-22 Thread Sune Vuorela
On 2015-09-22, Gianfranco Costamagna wrote: > -Pre-Depends: dpkg (>= 1.15.6~) > +Pre-Depends: dpkg (>= 1.15.6~), virtualbox-dkms (= ${source:Version}) | > virtualbox-source (= ${source:Version}) I don't see what it would fix to have virtualbox-source installed at

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-22 Thread Julien Cristau
On Tue, Sep 22, 2015 at 15:00:35 +, Gianfranco Costamagna wrote: > As shown in policy 7.2 > > "You should not specify a Pre-Depends entry for a package before this has > been discussed on the debian-devel mailing > list and a consensus about doing that has been reached. See Dependencies, >

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-22 Thread James Cowgill
Hi, On Tue, 2015-09-22 at 16:40 +, Gianfranco Costamagna wrote: > Hi James! > > > This should work with a normal Depends relation (reread Policy 7.2). > > > > This commit helped since it prevented a circular dependency involving > > the two packages: > >

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-22 Thread Gianfranco Costamagna
Hi James! >This should work with a normal Depends relation (reread Policy 7.2). > >This commit helped since it prevented a circular dependency involving >the two packages: >https://anonscm.debian.org/cgit/pkg-virtualbox/virtualbox.git/commit/?id=68f57408199e304df63285910a360bc2f6ae2372 > >So

promoting virtualbox-dkms to virtualbox pre-depends

2015-09-22 Thread Gianfranco Costamagna
As shown in policy 7.2 "You should not specify a Pre-Depends entry for a package before this has been discussed on the debian-devel mailing list and a consensus about doing that has been reached. See Dependencies, Section 3.5." the problem actually is that virtualbox-dkms should be configured

Re: promoting virtualbox-dkms to virtualbox pre-depends

2015-09-22 Thread James Cowgill
Hi, On Tue, 2015-09-22 at 15:00 +, Gianfranco Costamagna wrote: > As shown in policy 7.2 > > "You should not specify a Pre-Depends entry for a package before this > has been discussed on the debian-devel mailing > list and a consensus about doing that has been reached. See > Dependencies,