Re: Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-19 Thread Simon McVittie
On Tue, 19 Jan 2021 at 05:02:29 +0100, Guillem Jover wrote: > On Mon, 2021-01-11 at 00:48:42 +1100, Stuart Prescott wrote: > > SOURCE_BASE_DIR has a delightful symmetry to SOURCE_DATE_EPOCH and the > > algorithm for use is similar: if it is in the environment then use it, if > > not, > > fall ba

Re: Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-18 Thread Guillem Jover
Hi! On Mon, 2021-01-11 at 00:48:42 +1100, Stuart Prescott wrote: > Sune Stolborg Vuorela wrote: > > Can you provide some kind of hook in the environment so we at least can work > > around it in the users, so that the internal functions (where the output of > > __FILE__ is forwarded to) can glue e.

Re: Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-10 Thread Stuart Prescott
Sune Stolborg Vuorela wrote: > Can you provide some kind of hook in the environment so we at least can work > around it in the users, so that the internal functions (where the output of > __FILE__ is forwarded to) can glue e.g. the content of an environment > variable in front of the usage of the _

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Sune Stolborg Vuorela
On Saturday, January 9, 2021 12:49:50 AM CET Guillem Jover wrote: > Disabling this option in these few places gives you room to possibly > look for a fix, or not, w/o the pressure of the freeze, while not > affecting the other packages. Hi Guillem Can you provide some kind of hook in the environm

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Vagrant Cascadian
On 2021-01-09, Lisandro Damián Nicanor Pérez Meyer wrote: > Note: in case we do not agree on this topic this will be the text I'll > send to the > tech-ctte. Thanks for taking the time to draft some text. If we can come closer to agreement on the proposed text, that would probably take a bit of th

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Lisandro Damián Nicanor Pérez Meyer
Hi (again)! On Sat, 9 Jan 2021 at 17:53, Vagrant Cascadian wrote: > > On 2021-01-09, Lisandro Damián Nicanor Pérez Meyer wrote: > > Oh, I have sadly forgotten to mention another thing. > > > > On Sat, 9 Jan 2021 at 15:53, Lisandro Damián Nicanor Pérez Meyer > > wrote: > >> # __FILE__ is a public

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Vagrant Cascadian
On 2021-01-09, Lisandro Damián Nicanor Pérez Meyer wrote: > Oh, I have sadly forgotten to mention another thing. > > On Sat, 9 Jan 2021 at 15:53, Lisandro Damián Nicanor Pérez Meyer > wrote: >> # __FILE__ is a public, well defined API > > According to: > Adrian Bunks mentions it in > https://bugs.

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! On Sat, 9 Jan 2021 at 16:39, Samuel Thibault wrote: > > Lisandro Damián Nicanor Pérez Meyer, le sam. 09 janv. 2021 15:53:41 -0300, a > ecrit: > > # __FILE__ is a public, well defined API > > ? My copy of C11 says > > “ > __FILE__ The presumed name of the current source file (a character stri

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! On Sat, 9 Jan 2021 at 16:52, Mattia Rizzolo wrote: > > On Sat, Jan 09, 2021 at 08:37:48PM +0100, Samuel Thibault wrote: > > Lisandro Damián Nicanor Pérez Meyer, le sam. 09 janv. 2021 15:53:41 -0300, > > a ecrit: > > > # __FILE__ is a public, well defined API > > > > ? My copy of C11 says > >

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Mattia Rizzolo
On Sat, Jan 09, 2021 at 08:37:48PM +0100, Samuel Thibault wrote: > Lisandro Damián Nicanor Pérez Meyer, le sam. 09 janv. 2021 15:53:41 -0300, a > ecrit: > > # __FILE__ is a public, well defined API > > ? My copy of C11 says > > “ > __FILE__ The presumed name of the current source file (a charact

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Samuel Thibault
Lisandro Damián Nicanor Pérez Meyer, le sam. 09 janv. 2021 15:53:41 -0300, a ecrit: > # __FILE__ is a public, well defined API ? My copy of C11 says “ __FILE__ The presumed name of the current source file (a character string literal) ” that's not so well-defined. I would not expect it to nece

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Lisandro Damián Nicanor Pérez Meyer
Oh, I have sadly forgotten to mention another thing. On Sat, 9 Jan 2021 at 15:53, Lisandro Damián Nicanor Pérez Meyer wrote: > # __FILE__ is a public, well defined API According to: Adrian Bunks mentions it in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876901#10 Holger Levsen in https://b

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Lisandro Damián Nicanor Pérez Meyer
Note: in case we do not agree on this topic this will be the text I'll send to the tech-ctte. Let me start by noting that I have nothing against reproducibility. In fact quite the opposite: I love the idea... as long as it's properly implemented. The problem here is that __FILE__ is a public, wel

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-09 Thread Vagrant Cascadian
On 2021-01-08, Lisandro Damián Nicanor Pérez Meyer wrote: > On Fri, 8 Jan 2021 at 21:15, Lisandro Damián Nicanor Pérez Meyer > wrote: > In fact most of those packages would not be unreproducible if the > environment would be the same as the original build. That includes the > build path. True, th

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Lisandro Damián Nicanor Pérez Meyer
On Fri, 8 Jan 2021 at 21:15, Lisandro Damián Nicanor Pérez Meyer wrote: > > Hi! Explicitely CCing my bug, since it seems it missed my previous reply. > > On Fri, 8 Jan 2021 at 20:49, Guillem Jover wrote: > > > > On Fri, 2021-01-08 at 19:23:13 -0300, Lisandro Damián Nicanor Pérez Meyer > > wrote:

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! Explicitely CCing my bug, since it seems it missed my previous reply. On Fri, 8 Jan 2021 at 20:49, Guillem Jover wrote: > > On Fri, 2021-01-08 at 19:23:13 -0300, Lisandro Damián Nicanor Pérez Meyer > wrote: > > [snip] > > > We did a full archive rebuild testing this change, and I provided >

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Guillem Jover
On Fri, 2021-01-08 at 19:23:13 -0300, Lisandro Damián Nicanor Pérez Meyer wrote: > [snip] > > We did a full archive rebuild testing this change, and I provided > > patches to all known affected packages several months ago. It is a > > one-line change in debian/rules in most cases: > > > > > > ht

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Lisandro Damián Nicanor Pérez Meyer
The code that relies on __FILE__ can be found at https://sources.debian.org/src/qtbase-opensource-src/5.15.2+dfsg-2/src/testlib/qtestcase.h/#L216 So maybe we can try and get a fix there and push this change in the next stable release, after appropriately tested. -- Lisandro Damián Nicanor Pérez

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! [snip] > > We did a full archive rebuild testing this change, and I provided > patches to all known affected packages several months ago. It is a > one-line change in debian/rules in most cases: > > > https://udd.debian.org/cgi-bin/bts-usertags.cgi?user=reproducible-builds%40lists.alioth.de

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Vagrant Cascadian
On 2021-01-08, Lisandro Damián Nicanor Pérez Meyer wrote: > On Fri, 13 Nov 2020 at 17:40, Vagrant Cascadian > wrote: >> >> On 2020-11-13, Sune Vuorela wrote: >> > On 2020-10-27, Vagrant Cascadian wrote: >> >> Though, of course, identifying the exact reproducibility problem would >> >> be preferab

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Lisandro Damián Nicanor Pérez Meyer
On Fri, 8 Jan 2021 at 10:29, Lisandro Damián Nicanor Pérez Meyer wrote: > > Hi! Sorry for this late reply, but it just came into my view. > > On Fri, 13 Nov 2020 at 17:40, Vagrant Cascadian > wrote: > > > > On 2020-11-13, Sune Vuorela wrote: > > > On 2020-10-27, Vagrant Cascadian wrote: > > >> T

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2021-01-08 Thread Lisandro Damián Nicanor Pérez Meyer
Hi! Sorry for this late reply, but it just came into my view. On Fri, 13 Nov 2020 at 17:40, Vagrant Cascadian wrote: > > On 2020-11-13, Sune Vuorela wrote: > > On 2020-10-27, Vagrant Cascadian wrote: > >> Though, of course, identifying the exact reproducibility problem would > >> be preferable.

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2020-11-15 Thread Guillem Jover
On Sat, 2020-11-14 at 11:15:03 -0800, Vagrant Cascadian wrote: > On 2020-11-14, Sune Vuorela wrote: > > Unfortunately, only like 10% of the relevant packages have test suites > > enabled and run, because gettings things to work reliable is sometimes > > hard. > So, based on your estimate and the c

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2020-11-14 Thread Vagrant Cascadian
On 2020-11-14, Sune Vuorela wrote: > On 2020-11-13, Vagrant Cascadian wrote: >> If it could be fixed at the core for QFINDTESTDATA, that would be nicer >> than fixing 20-30 packages individually, though we're not there right >> now. > > Unfortunately, only like 10% of the relevant packages have te

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2020-11-13 Thread Vagrant Cascadian
On 2020-11-13, Sune Vuorela wrote: > On 2020-10-27, Vagrant Cascadian wrote: >> Though, of course, identifying the exact reproducibility problem would >> be preferable. One of the common issues is test suites relying on the >> behavior of __FILE__ returning a full path to find fixtures or other >>

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2020-11-09 Thread Graham Inggs
Hi On Mon, 9 Nov 2020 at 22:06, Vagrant Cascadian wrote: > Given no objections or concerns of any kind raised in the last two > weeks, I've submitted a bug against dpkg: > > https://bugs.debian.org/974087 There was a query from one of our upstreams in #972294 to which I have not seen a respons

Re: Updating dpkg-buildflags to enable reproducible=+fixfilepath by default

2020-11-09 Thread Vagrant Cascadian
On 2020-10-27, Vagrant Cascadian wrote: > The dpkg-buildflags feature reproducible=+fixfilepath was added to dpkg > in 2018. ... > The result of enabling this feature by default will be to make several > hundred packages reproducible with varying build-path and reduce the > differences in many othe