Re: Review of controllib-removal branch requested

2008-01-17 Thread Raphael Hertzog
On Thu, 17 Jan 2008, Guillem Jover wrote: > > What would you suggest then ? Shall I add $substvar->set("Format", > > $changes_format) in dpkg-genchanges ? > > Sure, and also override the Format field if such substvar is present > as documented in the man page. Ok, done. > In this case I think th

Re: Review of controllib-removal branch requested

2008-01-16 Thread Guillem Jover
On Wed, 2008-01-16 at 08:18:12 +0100, Raphael Hertzog wrote: > On Wed, 16 Jan 2008, Guillem Jover wrote: > > The Format substvar is not set anymore. > > Indeed, that was on purpose. It wasn't used by the code as a substitution > but only like a general purpose variable (which I really created as i

Re: Review of controllib-removal branch requested

2008-01-15 Thread Raphael Hertzog
Hi, On Wed, 16 Jan 2008, Guillem Jover wrote: > On Tue, 2008-01-01 at 21:15:02 +0100, Raphael Hertzog wrote: > > I just finished the necessary work to get rid off controllib.pl. I pushed > > it in a new branch controllib-removal: > > http://git.debian.org/?p=dpkg/dpkg.git;a=shortlog;h=controllib-r

Re: Review of controllib-removal branch requested

2008-01-15 Thread Guillem Jover
Hi, On Tue, 2008-01-01 at 21:15:02 +0100, Raphael Hertzog wrote: > I just finished the necessary work to get rid off controllib.pl. I pushed > it in a new branch controllib-removal: > http://git.debian.org/?p=dpkg/dpkg.git;a=shortlog;h=controllib-removal > I welcome some review on the changes (it

Review of controllib-removal branch requested

2008-01-01 Thread Raphael Hertzog
Hello, I just finished the necessary work to get rid off controllib.pl. I pushed it in a new branch controllib-removal: http://git.debian.org/?p=dpkg/dpkg.git;a=shortlog;h=controllib-removal This branch also includes the parsechangelog branch of djpig and does one more change on top of it by addi