Bug#635683: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Niko Tyni
On Wed, Aug 10, 2011 at 02:58:07PM -0500, Jonathan Nieder wrote: Niko Tyni wrote: Looks like dpkg tries to sync /usr/bin/perl5.12.4.dpkg-new when a hard link has already been renamed to /usr/bin/perl and presumably gotten executed by someone else. Does this help? + * Open extracted

Bug#570934: [DPKG-DEB] possibility to hook a program at the start of dpkg-deb --build

2011-08-12 Thread Guillem Jover
Hi! On Mon, 2010-02-22 at 12:11:53 +0100, Raphaël Hertzog wrote: Package: dpkg Version: 1.15.6 Severity: wishlist Given that Debian packages are not all built with the same helper in debian/rules, it's difficult to hook something in the build process of all packages. debuild offers hooks

Bug#635683: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Guillem Jover
Hi! On Fri, 2011-08-12 at 13:33:22 +0300, Niko Tyni wrote: On Wed, Aug 10, 2011 at 02:58:07PM -0500, Jonathan Nieder wrote: Niko Tyni wrote: Looks like dpkg tries to sync /usr/bin/perl5.12.4.dpkg-new when a hard link has already been renamed to /usr/bin/perl and presumably gotten

Bug#635683: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Raphael Hertzog
On Fri, 12 Aug 2011, Niko Tyni wrote: However, are sync_file_range() and fsync() effective with an O_RDONLY file descriptor? From fsync(2): EBADF fd is not a valid file descriptor open for writing. but https://bugzilla.kernel.org/show_bug.cgi?id=29972 suggests this is

Bug#570934: [DPKG-DEB] possibility to hook a program at the start of dpkg-deb --build

2011-08-12 Thread Raphael Hertzog
Hi, On Fri, 12 Aug 2011, Guillem Jover wrote: In addition such an interface cannot be expected to be used realiably by maintainers for all builds of their packages on buildds and similar or user systems, as it needs an additional setup step. It's definitely not meant for maintainers... but it

Bug#635683: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Jonathan Nieder
Niko Tyni wrote: From fsync(2): EBADF fd is not a valid file descriptor open for writing. *digs* Looks like that description was added between man-pages-1.10 (16-Jan-1996) and man-pages-1.11 (15-Apr-1996). From a look at Linux 0.99.10, I think fsync has just looked at the dirent and

Bug#635683: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Jonathan Nieder
Guillem Jover wrote: This is misleading on Linux, but it's not a safe portable assumption to make on POSIX in general as that behaviour is not specified and as such is implementation specific, some Unix systems do actually fail on read-only file descriptors, for example:

Bug#637564: dpkg-dev: dpkg-gencontrol simplification of Breaks is broken, simply keeps first found version

2011-08-12 Thread Andreas Metzler
Package: dpkg-dev Version: 1.15.8.11 Severity: important (SID)ametzler@argenau:/tmp/GNUTLS/gnutls-2.12.7$ grep sipsak debian/control Breaks: sipsak (= 0.9.6-2.1), sipsak (= 0.9.6-2.2) (SID)ametzler@argenau:/tmp/GNUTLS/gnutls-2.12.7$ dpkg-gencontrol \ -plibgnutls26

Bug#635683: [PATCH/RFC v3] Re: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Jonathan Nieder
Guillem Jover wrote: This is misleading on Linux, but it's not a safe portable assumption to make on POSIX in general as that behaviour is not specified and as such is implementation specific Ok, here's a patch with better behavior. On Linux and similar platforms, it just opens the file for

Bug#635683: [PATCH/RFC v3] Re: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Jonathan Nieder
Jonathan Nieder wrote: To fix that, we should fsync() each file with multiple hard links only once and then rename all links, so the logic to skip fsync would be no longer needed. ... and here's a patch on top implementing that. --- debian/changelog | 13 ++--- src/archives.c |

Bug#635683: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Raphael Hertzog
On Fri, 12 Aug 2011, Guillem Jover wrote: This is misleading on Linux, but it's not a safe portable assumption to make on POSIX in general as that behaviour is not specified and as such is implementation specific, some Unix systems do actually fail on read-only file descriptors, for example:

Bug#635683: [PATCH/RFC v3] Re: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Raphael Hertzog
tag 635683 + patch thanks Hi, On Fri, 12 Aug 2011, Jonathan Nieder wrote: Ok, here's a patch with better behavior. On Linux and similar platforms, it just opens the file for reading. If fsync fails with errno == EBADF, it falls back to opening for writing, and if that fails with errno ==

Processed: Re: Bug#635683: [PATCH/RFC v3] Re: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: tag 635683 + patch Bug #635683 [dpkg] dpkg --unpack: »/usr/bin/perl5.12.4.dpkg-new« cannot be opened: The program cannot be executed or altered/changed (busy) Added tag(s) patch. thanks Stopping processing here. Please contact me if you need

Processed: Bug#637564 marked as pending

2011-08-12 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: tag 637564 pending Bug #637564 [dpkg-dev] dpkg-dev: dpkg-gencontrol simplification of Breaks is broken, simply keeps first found version Added tag(s) pending. thanks Stopping processing here. Please contact me if you need assistance. --

Bug#637564: marked as pending

2011-08-12 Thread Raphaël Hertzog
tag 637564 pending thanks Hello, Bug #637564 reported by you has been fixed in the Git repository. You can see the changelog below, and you can check the diff of the fix at: http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=5c1da3f --- commit 5c1da3f8c2806490f9a7bed32c0a5b3a24d06d55

Bug#635683: [PATCH/RFC v3] Re: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Jonathan Nieder
Hi, Raphael Hertzog wrote: Instead of making yet another exception for hardlinks, it's time to decide that deferred rename is the norm and only directories should be exempted from this. Makes perfect sense. Thanks! Here's the remainder of the train of thought I sent before. I

Bug#635683: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Guillem Jover
On Fri, 2011-08-12 at 21:10:20 +0200, Raphael Hertzog wrote: On Fri, 12 Aug 2011, Guillem Jover wrote: This is misleading on Linux, but it's not a safe portable assumption to make on POSIX in general as that behaviour is not specified and as such is implementation specific, some Unix

Processed: Bug#635683 marked as pending

2011-08-12 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: tag 635683 pending Bug #635683 [dpkg] dpkg --unpack: »/usr/bin/perl5.12.4.dpkg-new« cannot be opened: The program cannot be executed or altered/changed (busy) Ignoring request to alter tags of bug #635683 to the same tags previously set thanks

Processed: Bug#635683 marked as pending

2011-08-12 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: tag 635683 pending Bug #635683 [dpkg] dpkg --unpack: »/usr/bin/perl5.12.4.dpkg-new« cannot be opened: The program cannot be executed or altered/changed (busy) Added tag(s) pending. thanks Stopping processing here. Please contact me if you

Bug#635683: marked as pending

2011-08-12 Thread Guillem Jover
tag 635683 pending thanks Hello, Bug #635683 reported by you has been fixed in the Git repository. You can see the changelog below, and you can check the diff of the fix at: http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=efcf279 --- commit efcf279a50aba3369b24d062017d581006d47d9b

Bug#635683: marked as pending

2011-08-12 Thread Guillem Jover
tag 635683 pending thanks Hello, Bug #635683 reported by you has been fixed in the Git repository. You can see the changelog below, and you can check the diff of the fix at: http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=3fe96e3 --- commit 3fe96e302867a6e983c1c469a2751dfc050ecb1f

Bug#635683: [PATCH/RFC v3] Re: sid perl update problem with 5.12.4-2: text file busy

2011-08-12 Thread Guillem Jover
On Fri, 2011-08-12 at 22:09:55 +0200, Raphael Hertzog wrote: On Fri, 12 Aug 2011, Jonathan Nieder wrote: --- a/src/archives.c +++ b/src/archives.c @@ -851,7 +851,8 @@ tarobject(void *ctx, struct tar_entry *ti) * in .dpkg-new. */ - if (ti-type == tar_filetype_file ||

Bug#570934: [DPKG-DEB] possibility to hook a program at the start of dpkg-deb --build

2011-08-12 Thread Guillem Jover
On Fri, 2011-08-12 at 14:35:58 +0200, Raphael Hertzog wrote: On Fri, 12 Aug 2011, Guillem Jover wrote: In addition such an interface cannot be expected to be used realiably by maintainers for all builds of their packages on buildds and similar or user systems, as it needs an additional