70c449652412aab2b96cc3831bef2f7fff11b896 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2024 17:25:23 +0200
Subject: [PATCH 1/2] scripts/mk: reduce the number of subprocess again
In architecture.mk, each unset variable was spawning a shell.
In buildapi.mk, each expansion was spawning a shell. Both
Michael has already replaced CFLAGS+=foo with DEB_CFLAGS_MAINT_APPEND:=foo
https://salsa.debian.org/samba-team/samba/-/commit/505e4ff2084280b09eb1ecea277de056ff62684a
Ironically, the debian/rules for samba contains the exact same
optimization we are talking about:
# Fast version of dpkg/architec
Hello.
> Hmm, at this point I'm starting to ponder whether to revert the
> optimization commit for the Makefile fragment files, because this
> is starting to feel like too much breakage, and then the fragment
> code is becoming too hard to debug, or even test.
This sentence seems a bit unfair. T
e it.
>From d713c8b47b16cee20e6bfe66aa5ba5b43d8129d6 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Thu, 25 Jul 2024 10:48:30 +0200
Subject: [PATCH 1/2] Revert "scripts/mk: Fix pkg-info.mk evaluation by adding
new DEB_TIMESTAMP variable"
This reverts commit c05f82972018d182fa296ef38384a1add
:00 2001
From: Nicolas Boulenguez
Date: Fri, 19 Jul 2024 13:20:06 +0200
Subject: [PATCH 1/3] scripts/mk: ensure dpkg_datadir is computed once
dpkg_datadir ?= $(dir $(lastword $(MAKEFILE_LIST)))
is equivalent to
ifndef dpkg_datadir
dpkg_datadir = $(..)
endif
$(..) is computed each time dpkg_datadir
$(MAKEFILE_LIST))),
but, thinking about it again, there seems to be no problem with a
double path component separator.
>From 467d7aa41c95796f6d7ef43bb4c8fda925728791 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Tue, 2 Jul 2024 11:54:55 +0200
Subject: scripts/mk: Stop hard-coding d
Package: dpkg-dev
Followup-For: Bug #872381
Hello again.
My last message was confusing.
I am suggesting to improve commit f1175056 with
0001-build-spare-an-unneeded-subst-handling-in-pkg-info.m.patch.
I have only quoted 0001-scripts-mk-stop-hard-coding-dpkg_datadir.patch
for context. Please igno
artifacts).
Ironically, f1175056 seems to introduce the exact kind of human error
that dynamic generation would prevent.
0001-build-spare-an-unneeded-subst-handling-in-pkg-info.m.patch
>From 36e98fdd10b1896f8fa89733b5e0c1781c0cce4c Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 6
been present in pkg-info.mk since 2011.
>From 5b3d75fb604dae497406f19073d03ea094da8d07 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Wed, 10 Apr 2024 00:41:42 +0200
Subject: [PATCH 01/10] scripts/t/mk/buildflags.mk: fix test of _MAINT_APPEND
when TEST_ is empty
When TEST_CPPFLAGS is em
NT_APPEND to fail because the correct result is
not a concatenation, Make strips a space. This issue can also be
seen with 1.22.5.
>From 37f1089c450fca16d06d586cf390a05642af25f0 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 4 Mar 2024 13:23:56 +0100
Subject: [PATCH 01/11] scripts/mk: only use AS
already computed in default.mk).
* removes non-ASCII characters from comments
>From e29be20064687eee52fa9b6c1ee1cb722867d590 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH 01/10] scripts/mk: protect scripts from double inclusion
Two s
rom: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH 1/8] scripts/mk: stop hard-coding dpkg_datadir, protect from
double inclusion
The Makefile snippets include each other from their common directory,
but the path differ during tests and after installation. Instead
Package: dpkg-dev
Followup-For: Bug #689062
Hello.
I took the absence of answer to my messages here and the ITP as an
agreement that an external tool, if somewhat redundant, is preferable
to a change in the dpkg-gencontrol public interface, where any change
has wide repercussions.
So here is the
Hello.
I have written a tool inspired by this bug report.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035888
A full description is available at
https://salsa.debian.org/debian/dh-builtusing/-/blob/master/dh_builtusing.pod
This is a proof of concept, any suggestion or critic is welcome
(esp
tails in documentation
> I've left this one out for now. The version information was added on
> purpose to help people know when each interface or file was added, so
Fixed in the attached commit (sorry, I thought that we were not
supporting anything before oldoldstable).
Thanks for th
should be
easyer to review.
>From 5852b310ea8cdd519a0f7d6e1099c3c54db026ed Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH 01/10] scripts/mk: stop hard-coding dpkg_datadir
The Makefile snippets include each other from their common directory,
> > [in scripts/mk/Makefile.am], I suggest to rename
> > scripts/mk/{default,buildtools}.mk to scripts/mk/*.mk.sed or similar
> > (for example, .sed.mk in order to keep syntax highlighting). Distinct
> > source and object files would also simplify scripts/mk/Makefile a lot.
> Yeah, that would be
Package: dpkg-dev
Followup-For: Bug #872381
(CCing Guillem as the author of the commits referenced below)
Hello.
The changes introduced by 1947fef8 and 981d5acb are basically
incompatible with the first patch in bug report #872381 [1].
For the record, commits a49f0a9c and f28cbcc4 also require
Package: dpkg-dev
Followup-For: Bug #872381
One more suggestion is attached.
>From 95a908b270a533fc5d4a58a45deb929ce0d6159e Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 1 Nov 2021 10:08:08 +0100
Subject: [PATCH 8/8] scripts/mk/buildopts.mk: small optimisations
Ass
Package: dpkg-dev
Version: 1.20.9
Followup-For: Bug #968963
Control: severity 872381 normal
Control: tags -1 patch
Control: merge -1 872381
This bug duplicates 872381, which carries a patch.
Package: dpkg-dev
Version: 1.20.9
Followup-For: Bug #872381
The attached commits are, once more, manually rebased on the current
HEAD.
>From ad7a566e7966f7c8062a044d0c2df0b07b0011d7 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH
Package: dpkg-dev
Followup-For: Bug #985980
A space-separated list of enabled features may be useful on its own,
and would not increase the complexity in Makefiles.
features := $(shell dpkg-buildflags --enabled-features optimize)
ifneq (,$(filter lto,$(features)))
...
endif
ifneq (,$(filter pgo
Package: dpkg-dev
Followup-For: Bug #990073
Control: tags -1 + patch
Here is a proof of concept passing the following tests.
gcc -> gcc-defaults (= .*)
bla (= 1), gcc, foo (= 2) -> bla (= 1), foo (= 2), gcc-defaults
(= .*)
bla (= 1), gcc, g++,
Package: dpkg-dev
Version: 1.20.9
Severity: wishlist
Hello.
This pattern seems common:
debian/rules:
override_dh_gencontrol:
dh_gencontrol -- "-VBuilt-Using:P1=`dpkg-query -Wf'$${source:Package}
(= $${source:Version})' P2`"
debian/control:
Package: P1
Built-Using: ${Built-Using:P1}
Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH 1/7] scripts/mk: simplify Makefile.am with sed --in-place
option
---
scripts/mk/Makefile.am | 18 --
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/scripts
Please replace 0003.patch with the attached version (changes are
cosmetic but should use review and merge).
>From a93a87581dbe90bd15822f11f374ae6d76263ca4 Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 19:03:16 +0200
Subject: [PATCH 3 (v2)/3] scripts/mk: impr
tests, slightly faster.
How can I help?
Thanks.
>From 55c1f85f2f371b94aa36db098cf5408213a8295c Mon Sep 17 00:00:00 2001
From: Nicolas Boulenguez
Date: Mon, 29 Jul 2019 14:38:32 +0200
Subject: [PATCH 1/3] scripts/mk: simplify Makefile.am with sed --in-place
option
---
scripts/mk/Makefile.am |
Package: dpkg-dev
Version: 1.19.2
Followup-For: Bug #872381
Hi.
This new version improves the readability in various aspects,
and should be easyer to review.
It fixes a difference with the current version in dpkg-dev by
exporting all dpkg-architecture variables.
Is there anything that I can do to
Package: dpkg-dev
Version: 1.18.24
Severity: wishlist
Tags: patch
Hello.
A new implementation of
/usr/share/dpkg/architecture.mk
/usr/share/dpkg/buildflags.mk
/usr/share/dpkg/pkg-info.mk
is attached. You may use run_tests.sh to check that the behaviour
remains the same in most circumstance
Package: dpkg
Version: 1.18.22
Severity: wishlist
Tags: patch
Hello.
Dpkg-source rightfully ignores the "_MTN" directory, used by the
Monotone version control system.
It should also ignore the ".mtn-ignore" file.
The attached patch fixes this.
Thanks.
--- a/scripts/Dpkg/Source/Package.pm
+++ b/scr
Package: dpkg-dev
Version: 1.15.8.10
Severity: wishlist
When upstream modifications are detected outside the debian/ subdirectory,
dpkg-source will automatically add a patch to debian/patches/series.
If the user has set the --abort-on-upstream-changes option, he/she
certainly wants to handle the
31 matches
Mail list logo