Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-29 Thread Jonathan Nieder
Guillem Jover wrote: On Sun, 2012-10-28 at 02:53:57 -0700, Jonathan Nieder wrote: Here's another try at putting it in the description of --export. What do you think? Certainly an improvement, although I'm not yet sold on the embedded examples, it would probably also make more sense to

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-28 Thread Jonathan Nieder
Guillem Jover wrote: Yeah, one of the things I checked was if an EXAMPLE section was present in the man page at all, or more detail about the quoting, given the confusion. So I think this really makes sense. But the QUOTING section seems a bit strange That's fair. I first tried putting this

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-28 Thread Guillem Jover
On Sun, 2012-10-28 at 02:53:57 -0700, Jonathan Nieder wrote: Guillem Jover wrote: Yeah, one of the things I checked was if an EXAMPLE section was present in the man page at all, or more detail about the quoting, given the confusion. So I think this really makes sense. But the QUOTING

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-27 Thread Jonathan Nieder
tags 691449 + patch quit Matthias Klose wrote: is there a reason not to escape the whitespace by default for --export=configure? --export=configure is designed to be used like this: conf_opts := $(shell dpkg-buildflags --export=configure) conf_opts += --prefix=/usr etc

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-27 Thread Guillem Jover
Hi! On Sat, 2012-10-27 at 17:28:57 -0700, Jonathan Nieder wrote: How about this patch? Yeah, one of the things I checked was if an EXAMPLE section was present in the man page at all, or more detail about the quoting, given the confusion. So I think this really makes sense. But the QUOTING

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-26 Thread Matthias Klose
On 25.10.2012 21:20, Guillem Jover wrote: On Thu, 2012-10-25 at 11:53:47 -0700, Jonathan Nieder wrote: Matthias Klose wrote: A lot of rules files uses loops around configure calls, however there's no export mode which escapes the spaces in the output. Please add one. The sh mode won't work

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-26 Thread Matthias Klose
A lot of rules files uses loops around configure calls, however there's no export mode which escapes the spaces in the output. Please add one. The sh mode won't work either for this case. is there a reason not to escape the whitespace by default for --export=configure? -- To UNSUBSCRIBE,

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-26 Thread Guillem Jover
On Fri, 2012-10-26 at 10:54:51 +0200, Matthias Klose wrote: On 25.10.2012 21:20, Guillem Jover wrote: Or just “$(shell dpkg-buildflags --export=configure)”? I do not really see a problem here. I might be missing something else going on, but otherwise I'll be closing this report in a bit.

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-25 Thread Matthias Klose
Package: dpkg A lot of rules files uses loops around configure calls, however there's no export mode which escapes the spaces in the output. Please add one. The sh mode won't work either for this case. $ debian/rules x set -ex; for v in 1.8 \ ; do \ if [ $v = 1.8 ]; then

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-25 Thread Jonathan Nieder
Hi Matthias, Matthias Klose wrote: A lot of rules files uses loops around configure calls, however there's no export mode which escapes the spaces in the output. Please add one. The sh mode won't work either for this case. Doesn't set -e; \ eval $$(dpkg-buildflags

Bug#691449: dpkg-buildflags should have an export mode for shell scripts

2012-10-25 Thread Guillem Jover
On Thu, 2012-10-25 at 11:53:47 -0700, Jonathan Nieder wrote: Matthias Klose wrote: A lot of rules files uses loops around configure calls, however there's no export mode which escapes the spaces in the output. Please add one. The sh mode won't work either for this case. Doesn't