Re: RFS: soju

2023-10-24 Thread Nilesh Patra
On Tue, Oct 24, 2023 at 11:53:52PM +0300, Taavi Väänänen wrote: > On 10/23/23 00:17, Nilesh Patra wrote:> Please comment on the d/dirs thingy > and then we could wind it up! > > I did check, and we can indeed have adduser create the home directory. I did > that in commit 1de808aa[0]. I, however,

Re: RFS: soju

2023-10-24 Thread Taavi Väänänen
On 10/23/23 00:17, Nilesh Patra wrote:> Please comment on the d/dirs thingy and then we could wind it up! I did check, and we can indeed have adduser create the home directory. I did that in commit 1de808aa[0]. I, however, didn't figure out a way to make adduser create the directory with the

Re: RFS: soju

2023-10-22 Thread Nilesh Patra
On Mon, Oct 23, 2023 at 02:43:32AM +0530, Nilesh Patra wrote: > On Sun, Oct 22, 2023 at 02:46:00AM +0530, Nilesh Patra wrote: > > On Sat, Oct 21, 2023 at 11:57:14PM +0300, Taavi Väänänen wrote: > > > On 10/21/23 17:28, Nilesh Patra wrote: > > > > I have pushed a small change with reasoning to

Re: RFS: soju

2023-10-22 Thread Nilesh Patra
On Sun, Oct 22, 2023 at 02:46:00AM +0530, Nilesh Patra wrote: > On Sat, Oct 21, 2023 at 11:57:14PM +0300, Taavi Väänänen wrote: > > On 10/21/23 17:28, Nilesh Patra wrote: > > > I have pushed a small change with reasoning to properly fix those. > > > However, I have two > > > questions to ask: > >

Re: RFS: soju

2023-10-21 Thread Nilesh Patra
On Sat, Oct 21, 2023 at 11:57:14PM +0300, Taavi Väänänen wrote: > On 10/21/23 17:28, Nilesh Patra wrote: > > I have pushed a small change with reasoning to properly fix those. However, > > I have two > > questions to ask: > > > > * Why is the groupname of soju user names "ssl-cert" and not soju

Re: RFS: soju

2023-10-21 Thread Taavi Väänänen
On 10/21/23 17:28, Nilesh Patra wrote: I have pushed a small change with reasoning to properly fix those. However, I have two questions to ask: * Why is the groupname of soju user names "ssl-cert" and not soju itself? * Do we expect a "ssl-group" to be commonly present in linux systems? If

Re: RFS: soju

2023-10-21 Thread Nilesh Patra
On Sat, Oct 21, 2023 at 01:54:45PM +0300, Taavi Väänänen wrote: > On 10/18/23 23:01, Nilesh Patra wrote: > > * Will the "soju" user and corresponding group be automatically deleted > >once the package is removed? > >I don't really know if sysuser handles that by default. > > Good point, I

Re: RFS: soju

2023-10-21 Thread Taavi Väänänen
On 10/18/23 23:01, Nilesh Patra wrote: A couple of comments/questions not an exhaustive review before I go AFK (to sleep, it is 1:30AM here) Thank you! * Shouldn't "/var/lib/soju" be removed in a postrm script? Yes, done. * Will the "soju" user and corresponding group be automatically

Re: RFS: soju

2023-10-18 Thread Nilesh Patra
On Wed, Oct 18, 2023 at 10:36:47PM +0300, Taavi Väänänen wrote: > I've prepared packaging for the soju IRC bouncer, and pushed it to Salsa: > > https://salsa.debian.org/go-team/packages/soju > > Could someone review it and upload to NEW if it looks good? Please note this > is my first time

RFS: soju

2023-10-18 Thread Taavi Väänänen
Hi, I've prepared packaging for the soju IRC bouncer, and pushed it to Salsa: https://salsa.debian.org/go-team/packages/soju Could someone review it and upload to NEW if it looks good? Please note this is my first time packaging a new daemon, so it's likely I've made some stupid mistake on