Bug#655948: visudo: segfault on hurd-i386 due to calling unlink with null pointer

2012-01-14 Thread Steven McDonald
Package: sudo Version: 1.8.3p1-3sjm1 Severity: normal Tags: upstream patch User: debian-hurd@lists.debian.org Usertags: hurd Hello, After applying the patches in bugs #655883 and #655894, visudo successfully edits /etc/sudoers, but then segfaults after moving the new sudoers file into place. gdb

Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Steven McDonald
Hi, Thanks for the responses. On Sat, 14 Jan 2012 20:28:40 +0100 Pino Toscano wrote: > I did a bit of debug, and it seems sudo needs a fix, but a different > one. > Basically, when parsing the specified sudoers file (or the default one), > the "sudoerslist" list is populated with the file bei

Re: New version of function mkdirhier()

2012-01-14 Thread Samuel Thibault
Svante Signell, le Sun 15 Jan 2012 01:23:02 +0100, a écrit : > On Sat, 2012-01-14 at 23:48 +0100, Samuel Thibault wrote: > > Svante Signell, le Fri 13 Jan 2012 14:43:06 +0100, a écrit : > > > > No, but Guillem probably feels the same, and I do too: it's hard to tell > > > > you anything because you

Re: New version of function mkdirhier()

2012-01-14 Thread Svante Signell
On Sat, 2012-01-14 at 23:48 +0100, Samuel Thibault wrote: > Svante Signell, le Fri 13 Jan 2012 14:43:06 +0100, a écrit : > > > No, but Guillem probably feels the same, and I do too: it's hard to tell > > > you anything because you quickly get things personally. > > > > I don't consider my replies

Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Samuel Thibault
Pino Toscano, le Sat 14 Jan 2012 20:28:40 +0100, a écrit : > > Is this something that should be fixed in Hurd (or perhaps eglibc), > > I think we could also fix unlink() on the Hurd bits of glibc to give > EINVAL on NULL parameter, or that would be considered (too) broken code > anyway? As Thom

Re: New version of function mkdirhier()

2012-01-14 Thread Samuel Thibault
Svante Signell, le Fri 13 Jan 2012 14:43:06 +0100, a écrit : > > No, but Guillem probably feels the same, and I do too: it's hard to tell > > you anything because you quickly get things personally. > > I don't consider my replies to be personal I should have said "you quickly take things personal

Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Pino Toscano
Hi, Alle sabato 14 gennaio 2012, Steven McDonald ha scritto: > I've been looking at the problems with visudo as tracked on > alioth[1]. I've applied Justus's fix to use flock instead of lockf, > and created a patch that solves the segfault issue (see attached). > visudo now seems to work correctly

Re: Problems with Hurd's unlink in visudo

2012-01-14 Thread Thomas Bushnell, BSG
C != Java Which is to say, a null pointer is not a valid argument to unlink, and the Hurd's use of a signal instead of an error is allowed by Posix. Thomas On Jan 14, 2012 8:48 AM, "Steven McDonald" wrote: > Hi, > > I've been looking at the problems with visudo as tracked on alioth[1]. > I've a

Problems with Hurd's unlink in visudo

2012-01-14 Thread Steven McDonald
Hi, I've been looking at the problems with visudo as tracked on alioth[1]. I've applied Justus's fix to use flock instead of lockf, and created a patch that solves the segfault issue (see attached). visudo now seems to work correctly on Hurd. However, I'm uncertain whether the segfault should act

Re: Boot stops at Avahi-daemon

2012-01-14 Thread Samuel Thibault
pe...@kahn.nu, le Fri 13 Jan 2012 10:57:35 +0100, a écrit : > when i try to boot it the boot sequence freezes at the Avahi-daemon. This works for me. Do you have network configured and running? > Is this a known issue? Do any of you guys have any idea on how to get past > this? You can enter the