Re: Netsurf build failure: 'PATH_MAX' undeclared (patch)

2021-06-26 Thread João Pedro Malhado
Hello Guillem, Apologies for the late reply. Many thanks for the thorough comments on the patch. I have tried to address the issues that you pointed out in the attached new version of the patch. For those interested in tracking this issue, I had file a bug report upstream with the original

Re: Netsurf build failure: 'PATH_MAX' undeclared (patch)

2021-06-06 Thread Samuel Thibault
Guillem Jover, le dim. 06 juin 2021 23:21:52 +0200, a ecrit: > On Sat, 2021-05-29 at 19:16:57 +0100, João Pedro Malhado wrote: > > > --- netsurf-3.10.orig/libnsutils/src/time.c > > +++ netsurf-3.10/libnsutils/src/time.c > > @@ -16,11 +16,11 @@ > > #include > > #include > > > > -#if

Re: Netsurf build failure: 'PATH_MAX' undeclared (patch)

2021-06-06 Thread Guillem Jover
Hi! On Sat, 2021-05-29 at 19:16:57 +0100, João Pedro Malhado wrote: > I don't know if upstream would accept such a patch as they need to worry about > platforms like RISC OS and AmigaOS, and I don't know if this would work there. > It might be ok for Debian though. If there are no

Re: Netsurf build failure: 'PATH_MAX' undeclared (patch)

2021-06-04 Thread João Pedro Malhado
Hello Jeff, (Writing this from the hurd-console. Does utf-8 work? ã õ á à ê) On Sat, May 29, 2021 at 03:31:52PM -0400, Jeffrey Walton wrote: > On Sat, May 29, 2021 at 2:33 PM João Pedro Malhado wrote: > > > > The size of the filepaths are now allocated dynamically using asprintf() > > type of

Re: Netsurf build failure: 'PATH_MAX' undeclared (patch)

2021-05-29 Thread Jeffrey Walton
On Sat, May 29, 2021 at 2:33 PM João Pedro Malhado wrote: > > "With a little help from my friends", I came up with a patch for the Netsurf > build. The size of the filepaths are now allocated dynamically using > asprintf() > type of functions and realpath(). > ... > I don't know if upstream

Re: Netsurf build failure: 'PATH_MAX' undeclared (patch)

2021-05-29 Thread João Pedro Malhado
Hello everyone, "With a little help from my friends", I came up with a patch for the Netsurf build. The size of the filepaths are now allocated dynamically using asprintf() type of functions and realpath(). Note that if on the gtk version you try to open a local file via the widget, the

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-28 Thread Marcin Laszewski
https://eklitzke.org/path-max-is-tricky

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-27 Thread squid3
On 2021-04-28 09:36, Jeffrey Walton wrote: On Tue, Apr 27, 2021 at 5:12 PM wrote: On 2021-04-27 20:40, Jeffrey Walton wrote: > On Tue, Apr 27, 2021 at 4:35 AM William ML Leslie wrote: >> >> On Tue, 27 Apr 2021, 6:13 am Samuel Thibault wrote: >>> >>> It's not because something is economical

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-27 Thread Jeffrey Walton
On Tue, Apr 27, 2021 at 5:12 PM wrote: > > On 2021-04-27 20:40, Jeffrey Walton wrote: > > On Tue, Apr 27, 2021 at 4:35 AM William ML Leslie wrote: > >> > >> On Tue, 27 Apr 2021, 6:13 am Samuel Thibault wrote: > >>> > >>> It's not because something is economical that one should want to do > >>>

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-27 Thread squid3
On 2021-04-27 20:40, Jeffrey Walton wrote: On Tue, Apr 27, 2021 at 4:35 AM William ML Leslie wrote: On Tue, 27 Apr 2021, 6:13 am Samuel Thibault wrote: It's not because something is economical that one should want to do it. You don't even seem to realize that defining PATH_MAX *does* pose

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-27 Thread Jeffrey Walton
On Tue, Apr 27, 2021 at 4:35 AM William ML Leslie wrote: > > On Tue, 27 Apr 2021, 6:13 am Samuel Thibault, wrote: >> >> It's not because something is economical that one should want to do it. >> >> You don't even seem to realize that defining PATH_MAX *does* pose >> problem, notably with the

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-27 Thread William ML Leslie
On Tue, 27 Apr 2021, 6:13 am Samuel Thibault, wrote: > It's not because something is economical that one should want to do it. > > You don't even seem to realize that defining PATH_MAX *does* pose > problem, notably with the actual semantic of realpath(), due to the > semantic that posix

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Samuel Thibault
Jeffrey Walton, le lun. 26 avril 2021 15:25:23 -0400, a ecrit: > On Mon, Apr 26, 2021 at 3:12 PM Samuel Thibault wrote: > > > > Jeffrey Walton, le lun. 26 avril 2021 15:08:28 -0400, a ecrit: > > > On Mon, Apr 26, 2021 at 2:58 PM Samuel Thibault > > > wrote: > > > > > > > > Jeffrey Walton, le

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Jeffrey Walton
On Mon, Apr 26, 2021 at 3:12 PM Samuel Thibault wrote: > > Jeffrey Walton, le lun. 26 avril 2021 15:08:28 -0400, a ecrit: > > On Mon, Apr 26, 2021 at 2:58 PM Samuel Thibault > > wrote: > > > > > > Jeffrey Walton, le lun. 26 avril 2021 14:48:32 -0400, a ecrit: > > > > On Mon, Apr 26, 2021 at

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Samuel Thibault
Jeffrey Walton, le lun. 26 avril 2021 15:08:28 -0400, a ecrit: > On Mon, Apr 26, 2021 at 2:58 PM Samuel Thibault wrote: > > > > Jeffrey Walton, le lun. 26 avril 2021 14:48:32 -0400, a ecrit: > > > On Mon, Apr 26, 2021 at 6:57 AM João Pedro Malhado > > > wrote: > > > > > > > > On Thu, Apr 22,

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Jeffrey Walton
On Mon, Apr 26, 2021 at 2:58 PM Samuel Thibault wrote: > > Jeffrey Walton, le lun. 26 avril 2021 14:48:32 -0400, a ecrit: > > On Mon, Apr 26, 2021 at 6:57 AM João Pedro Malhado > > wrote: > > > > > > On Thu, Apr 22, 2021 at 01:39:58PM +0200, Samuel Thibault wrote: > > > > João Pedro Malhado, le

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Samuel Thibault
Jeffrey Walton, le lun. 26 avril 2021 14:48:32 -0400, a ecrit: > On Mon, Apr 26, 2021 at 6:57 AM João Pedro Malhado wrote: > > > > On Thu, Apr 22, 2021 at 01:39:58PM +0200, Samuel Thibault wrote: > > > João Pedro Malhado, le jeu. 22 avril 2021 13:10:04 +0200, a ecrit: > > > > > src/time.c:25:10:

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Jeffrey Walton
On Mon, Apr 26, 2021 at 6:57 AM João Pedro Malhado wrote: > > On Thu, Apr 22, 2021 at 01:39:58PM +0200, Samuel Thibault wrote: > > João Pedro Malhado, le jeu. 22 avril 2021 13:10:04 +0200, a ecrit: > > > > src/time.c:25:10: fatal error: mach/clock.h: No such file or directory > > > > > >

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Povl Ole Haarlev Olsen
On Mon, 26 Apr 2021, Mark Dymek wrote: Unsubscribe me from the list You need to send an email to: mailto:debian-hurd-requ...@lists.debian.org?subject=unsubscribe -- Povl Ole

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread João Pedro Malhado
Hello everyone, Replacing all PATH_MAX by _POSIX_PATH_MAX on all files concerned in the build rules does result in a successful build and a browser that loads pages from the web. If we can decide on what is a reasonable technical solution in this case, we would then have another ported package

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread Samuel Thibault
João Pedro Malhado, le lun. 26 avril 2021 12:51:34 +0200, a ecrit: > On Mon, Apr 26, 2021 at 12:40:25PM +0200, João Pedro Malhado wrote: > > I made some simple changes to the time.c file and the build went on, only to > > fail at some later stage. The error that I'm getting is: > > > >

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread João Pedro Malhado
Apologies for the consecutive emails. On Mon, Apr 26, 2021 at 12:40:25PM +0200, João Pedro Malhado wrote: > I made some simple changes to the time.c file and the build went on, only to > fail at some later stage. The error that I'm getting is: > > frontends/gtk/fetch.c: In function

Re: Netsurf build failure: 'PATH_MAX' undeclared

2021-04-26 Thread João Pedro Malhado
On Thu, Apr 22, 2021 at 01:39:58PM +0200, Samuel Thibault wrote: > João Pedro Malhado, le jeu. 22 avril 2021 13:10:04 +0200, a ecrit: > > > src/time.c:25:10: fatal error: mach/clock.h: No such file or directory > > > > https://buildd.debian.org/status/package.php?p=netsurf > > > > Is this