Bug#518412: linux-2.6 install errors due to incompatible depmod files [was Re: Bug#518412: initramfs-tools: must support relative paths in modules.dep ]

2009-03-20 Thread Michal Marek
Frans Pop napsal(a): > The use case here, which I suspect is not all that uncommon, is that I > built a kernel from upstream source on a (Debian unstable) system with > the new version of depmod and then installed that kernel on a (Debian > stable) system that has an older version of modprobe [1

Re: [PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-04 Thread Michal Marek
On 4.11.2010 13:29, Asbjørn Sloth Tønnesen wrote: > No, not if you are cross compiling since ARCH=x86 isn't specific to > either, we would have to look at the config. In that case it is better > to do something like: > > x86|i386|x86_64) > debarch=$(grep -q CONFIG_64BIT=y .config && No, you

Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path

2017-04-03 Thread Michal Marek
On 2017-04-03 09:42, Masahiro Yamada wrote: > Each Makefile knows it wants to see > additional headers in the source tree, or objtree. > > I am guessing the right approach in a long run is, > we require -I to specify $(srctree) or $(objtree) explicitly. > > ccflags-y := -I$(srctree)/foo/bar/baz >

Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path

2017-04-04 Thread Michal Marek
Dne 3.4.2017 v 22:20 Sam Ravnborg napsal(a): > On Mon, Apr 03, 2017 at 03:25:10PM +0200, Michal Marek wrote: >> On 2017-04-03 09:42, Masahiro Yamada wrote: >>> Each Makefile knows it wants to see >>> additional headers in the source tree, or objtree. >>> >&

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 03:31 Nicholas Piggin napsal(a): > On Tue, 29 Nov 2016 01:15:48 + > Ben Hutchings wrote: > >> [I've had to guess at the cc list for this, because we no longer have >> mail archives that preserve them.] > > You got it about right. > >> On Fri, 2016-11-25 at 10:01 -0800, Linu

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 16:27 Linus Torvalds napsal(a): > On Nov 29, 2016 5:51 AM, "Adam Borowski" > wrote: >> > >> > >> > (a) tested >> >> By many people. > > No. > > I've tested the build *without* this, and it works fine. > >> > (b) explains it >> >> The actual logic

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-11-29 Thread Michal Marek
Dne 29.11.2016 v 18:10 Linus Torvalds napsal(a): > How about this stupid patch? It weakens modversions, but that may be > ok for Debian, and a better alternative than just saying "we don't > support it at all". [...] > - pr_warn("%s: no symbol version for %s\n", mod->name, symname); > - ret

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 04:39, Nicholas Piggin wrote: > On Thu, 01 Dec 2016 02:35:54 + > Ben Hutchings wrote: >> As I understand it, genksyms incorporates the definitions of a >> function's parameter and return types - not just their names - and all >> the types they refer to, recursively. So a structu

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 05:13, Don Zickus wrote: > Sorry for chiming in late, but yes RHEL is a big user of MODVERSIONS for our > kabi protection work. Despite our best intentions we still have lots of > partners and customers that provide value-add out-of-tree drivers to their > customers. These module bu

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-01 Thread Michal Marek
On 2016-12-01 14:58, Arnd Bergmann wrote: > On Tuesday, November 29, 2016 9:14:46 AM CET Linus Torvalds wrote: >> On Tue, Nov 29, 2016 at 9:10 AM, Linus Torvalds >> wrote: >>> >>> So quite frankly, I don't want to make our kernel sources worse due to >>> broken shit tools getting something wrong t

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-13 Thread Michal Marek
Dne 9.12.2016 v 23:46 Dodji Seketeli napsal(a): > Hello, > > Nicholas Piggin a écrit: > > [...] > >> That said, a dwarf based checker tool should be able to do as good a job >> (maybe a bit better because report is very informative and it may pick up >> compiler alignments or padding options).

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 09:58, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> Does the abidiff tool handle the case when an exported symbol is moved >> between .c files? This is always a mess with genksyms, because the two >> .c files have different includ

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:15, Michal Marek wrote: > A minimal example would be > > t1.c: > struct s1; > struct s2 { > int i; > } > struct s3 { > struct s1 *ptr1; > struct s2 *ptr2; > } > void foo(struct s3*); > EXPORT_SYMBOL(foo); > > t2.c:

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 10:36, Dodji Seketeli wrote: > Michal Marek a écrit: > > [...] > >> A minimal example would be >> >> t1.c: >> struct s1; >> struct s2 { >> int i; >> } >> struct s3 { >> struct s1 *ptr1; >>

Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm

2016-12-14 Thread Michal Marek
On 2016-12-14 11:02, Dodji Seketeli wrote: > Michal Marek a écrit: > >>> Libabigail does a "whole binary" analysis of types. >>> >>> So, consider the point of use of the type 'struct s1*'. Even if 'struct >>> s' is

Re: [PATCH 1/2] deb-pkg: simplify directory creation

2015-08-19 Thread Michal Marek
On 2015-05-28 11:11, riku.voi...@linaro.org wrote: > From: Riku Voipio > > Every package needs /usr/share/doc/$package_name and > DEBIAN directory, so create them as part of create_package > function. > > Signed-off-by: Riku Voipio Applied to kbuild.git#misc. Michal

Re: [PATCH v3] deb-pkg: add source package

2015-08-19 Thread Michal Marek
On 2015-06-11 10:11, riku.voi...@linaro.org wrote: > From: Riku Voipio > > Make deb-pkg build both source and binary package like make rpm-pkg does. > For people who only need binary kernel package, there is now bindeb-pkg > target, same target also used to build the .deb files if built from the

Re: [PATCH v3] deb-pkg: add source package

2015-08-21 Thread Michal Marek
On Fri, Aug 21, 2015 at 11:08:44AM +0200, Ben Hutchings wrote: > I've gone through this with Riku and found a couple of problems: > > - The 'clean' rule in the generated debian/rules calls 'make clean', > but scripts/package/Makefile includes debian/ in clean-dirs. > Currently that directory d

Bug#750925: [PATCH v2 2/2] deb-pkg: Add automatic support for s390x architecture

2014-06-10 Thread Michal Marek
On 2014-06-09 02:24, Ben Hutchings wrote: > The Debian s390x architecture has 64-bit userland whereas s390 has > 32-bit userland. A 64-bit kernel can be used with either. Now that > Debian supports multiarch and officially supports s390x, it makes more > sense to assign a 64-bit kernel package to

Re: [PATCH 1/4] deb-pkg: Add automatic support for armhf architecture

2015-04-02 Thread Michal Marek
On 2015-04-02 15:14, Riku Voipio wrote: > On 2 April 2015 at 15:01, Arnaud Patard wrote: >> riku.voi...@linaro.org writes: >>> --- a/scripts/package/builddeb >>> +++ b/scripts/package/builddeb >>> @@ -45,7 +45,16 @@ create_package() { >>> arm64) >>> debarch=arm64 ;; >>> a

Re: [PATCH 1/2] deb-pkg: move setting debarch for a separate function

2015-04-15 Thread Michal Marek
On 2015-04-10 15:15, riku.voi...@linaro.org wrote: > From: Riku Voipio > > create_package() function tries to resolve used architecture > for everry package. Split the setting the architecture to a > new function, set_debarch(), called once on startup. > > This allows using debarch from other pa

Re: [PATCH] deb-pkg: v2: move setting debarch for a separate function

2015-04-22 Thread Michal Marek
On 2015-04-16 15:42, riku.voi...@linaro.org wrote: > From: Riku Voipio > > create_package() function tries to resolve used architecture > for everry package. Split the setting the architecture to a > new function, set_debarch(), called once on startup. > > This allows using debarch from other pa

Re: [PATCH] deb-pkg: Inhibit initramfs builders if CONFIG_BLK_DEV_INITRD is not set

2013-11-18 Thread Michal Marek
On Fri, Nov 15, 2013 at 03:03:25AM +, Ben Hutchings wrote: > The kernel postinst hook for initramfs-tools will build an initramfs > on installation unless $INITRD is set to 'No'. make-kpkg generates a > postinst script that sets this variable appropriately, but we don't. > Set it based on CONF

Re: [PATCH 2/2] deb-pkg: Fix building for MIPS big-endian or ARM OABI

2014-01-03 Thread Michal Marek
On 2013-12-05 15:39, Ben Hutchings wrote: > These commands will mysteriously fail: > > $ make ARCH=arm versatile_defconfig > [...] > $ make ARCH=arm deb-pkg > [...] > make[1]: *** [deb-pkg] Error 1 > make: *** [deb-pkg] Error 2 > > The Debian architecture selection for these kernel architectures

Re: [PATCH 1/2] deb-pkg: Fix cross-building linux-headers package

2014-01-03 Thread Michal Marek
On 2013-12-06 05:20, Niew, Sh. wrote: >>> On Thu, Dec 5, 2013 at 10:37 PM, Ben Hutchings >>> wrote: builddeb generates a control file that says the linux-headers package can only be built for the build system primary architecture. This breaks cross-building con

Re: [PATCH] kbuild, deb-pkg: support overriding userland architecture

2010-11-25 Thread Michal Marek
On Sat, Nov 06, 2010 at 07:05:20PM +, Asbjoern Sloth Toennesen wrote: > Usefull if building for sparc64 userland, because the > sparc and sparc64 userlands use the same 64-bit kernel, > making it impossible to always select the correct userland > architecture for the resulting debian package. >

Re: [PATCH] kbuild, deb-pkg: select userland architecture based on UTS_MACHINE

2010-11-25 Thread Michal Marek
On Fri, Nov 05, 2010 at 01:30:08PM +, Asbjoern Sloth Toennesen wrote: > Instead of creating the debian package for the compiling userland, > create it for a userland matching the kernel thats being compiled. > > This patch supports all Lenny release architectures, > and Linux-based architectur

Re: [PATCH] Kbuild: kconfig: Verbose version of --listnewconfig

2010-12-03 Thread Michal Marek
case S_BOOLEAN: > + case S_TRISTATE: > + switch (sym_get_tristate_value(sym)) { > + case no: > + printf("# CONFIG_%s is not set\n", > sym->name); > +

Re: [PATCH v3] kbuild, deb-pkg: support overriding userland architecture

2010-12-09 Thread Michal Marek
On 9.12.2010 16:24, Asbjoern Sloth Toennesen wrote: > Usefull if building for sparc64 userland, because the > sparc and sparc64 userlands use the same 64-bit kernel, > making it impossible to always select the correct userland > architecture for the resulting debian package. > > Might also be usef

Re: [PATCHv3] Kbuild: kconfig: Verbose version of --listnewconfig

2010-12-20 Thread Michal Marek
On 6.12.2010 01:50, Ben Hutchings wrote: > If the KCONFIG_VERBOSE environment variable is set, show the default > values of new symbols and not just their names. > > Based on work by Bastian Blank and > maximilian attems . Simplified by Michal Marek > . > > Sign

Re: [PATCHv3] Kbuild: kconfig: Verbose version of --listnewconfig

2010-12-20 Thread Michal Marek
On 20.12.2010 16:23, Arnaud Lacombe wrote: > Hi, > > On Mon, Dec 20, 2010 at 9:32 AM, Michal Marek wrote: >> On 6.12.2010 01:50, Ben Hutchings wrote: >>> If the KCONFIG_VERBOSE environment variable is set, show the default >>> values of new symbols and not just t

Re: [PATCH v4] kbuild, deb-pkg: support overriding userland architecture

2010-12-20 Thread Michal Marek
On Sun, Dec 12, 2010 at 05:39:40PM +, Asbjoern Sloth Toennesen wrote: > Usefull if building for sparc64 userland, because the > sparc and sparc64 userlands use the same 64-bit kernel, > making it impossible to always select the correct userland > architecture for the resulting debian package. >

Bug#636029: [PATCH] kbuild: Fix missing '\n' for NEW symbols in yes "" | make oldconfig >conf.new

2013-02-19 Thread Michal Marek
On 19.2.2013 06:39, Ben Hutchings wrote: > On Tue, 2013-02-19 at 02:24 +0200, Regid Ichira wrote: >> From: Ben Hutchings >> >> According to Documentation/kbuild/kconfig.txt, the commands: >> >> yes "" | make oldconfig >conf.new >> grep "(NEW)" conf.new >> >> should list the new config symb

Re: [opensuse-kernel] Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Michal Marek
On 17.7.2012 10:03, Geert Uytterhoeven wrote: > On Mon, Jul 16, 2012 at 10:56 PM, Linus Torvalds > wrote: >> On Mon, Jul 16, 2012 at 12:26 PM, wrote: >>> Some of the proposed ways to implement the minimum distro kernel would not >>> allow you to override the distro defaults because they would be

Re: [PATCH] builddeb: Don't create files in /tmp with predictable names

2012-02-18 Thread Michal Marek
On Wed, Feb 15, 2012 at 02:17:29PM +, Ben Hutchings wrote: > The current use of /tmp for file lists is insecure. Put them under > $objtree/debian instead. > > Signed-off-by: Ben Hutchings > Cc: sta...@vger.kernel.org Thanks, applied. How could I have missed that bug :-/. Michal -- To UN

Re: [PATCH 1/2] kbuild: Fix link to headers in 'make deb-pkg'

2012-02-24 Thread Michal Marek
talled on a different machine. Fix > > this in by manually re-creating the link in the builddeb > > script. > > > > Cc: Michal Marek > > Cc: maximilian attems > > Cc: Ben Hutchings > > Cc: debian-kernel@lists.debian.org > > Cc: linux-kbu...@vger.k

Re: [PATCH 2/2] kbuild: Only build linux-image package for UML

2012-02-24 Thread Michal Marek
the package with the linux-image in it. > > > > > > Cc: Michal Marek > > > Cc: maximilian attems > > > Cc: Ben Hutchings > > > Cc: debian-kernel@lists.debian.org > > > Cc: linux-kbu...@vger.kernel.org > > > Signed-off-by: Joerg Roe

Re: [PATCH] kbuild: Fix out-of-tree build for 'make deb-pkg'

2012-02-24 Thread Michal Marek
ations > with the $MAKE variable to be consistent within the script. > > Cc: Michal Marek > Cc: maximilian attems > Cc: Ben Hutchings > Cc: debian-kernel@lists.debian.org > Cc: linux-kbu...@vger.kernel.org > Signed-off-by: Joerg Roedel > --- > scripts/package

Re: [PATCH v6 2/4] deb-pkg: split debug symbols in their own package

2013-07-10 Thread Michal Marek
Dne 10.7.2013 15:09, Anisse Astier napsal(a): > Michal, > > Every patch has now been reviewed, do you think it would be possible to > take this series for 3.12 ? Yes, I will merge it as soon as this merge window closes. Michal -- To UNSUBSCRIBE, email to debian-kernel-requ...@lists.debian.org

Re: [PATCH v6 2/4] deb-pkg: split debug symbols in their own package

2013-07-24 Thread Michal Marek
On 10.7.2013 16:21, Michal Marek wrote: > Dne 10.7.2013 15:09, Anisse Astier napsal(a): >> Michal, >> >> Every patch has now been reviewed, do you think it would be possible to >> take this series for 3.12 ? > > Yes, I will merge it as soon as this merge window c