Re: Random panic in load_balance() with 3.16-rc

2014-08-04 Thread Steven Rostedt
On Fri, 25 Jul 2014 11:29:06 -0700 Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Jul 25, 2014 at 7:02 AM, Steven Rostedt rost...@goodmis.org wrote: But wouldn't it be rather trivial to run a static analyzer on the final vmlinux to make sure there are no red zones? I mean, you

Re: Random panic in load_balance() with 3.16-rc

2014-07-25 Thread Steven Rostedt
On Thu, Jul 24, 2014 at 08:55:28PM -0700, Alexei Starovoitov wrote: -mno-red-zone only affected prologue emition in gcc. This part didn't change between the releases. So the bug is quite deep. What seems to be happening is that 2nd pass of instruction scheduler (after emit prologue and reg

Re: Random panic in load_balance() with 3.16-rc

2014-07-25 Thread Steven Rostedt
On Fri, 25 Jul 2014 11:29:06 -0700 Linus Torvalds torva...@linux-foundation.org wrote: On Fri, Jul 25, 2014 at 7:02 AM, Steven Rostedt rost...@goodmis.org wrote: But wouldn't it be rather trivial to run a static analyzer on the final vmlinux to make sure there are no red zones? I mean, you

Re: Random panic in load_balance() with 3.16-rc

2014-07-25 Thread Steven Rostedt
On Fri, 25 Jul 2014 13:01:11 -0700 Linus Torvalds torva...@linux-foundation.org wrote: For example, gcc will not create a small stack frame with sub $8,%rsp. No, what gcc does is to use a random push instruction. Fair enough, but that really makes things much harder to see. Here's an

Bug#709647: [75/88] genirq: Fix can_request_irq() for IRQs without an action

2013-08-13 Thread Steven Rostedt
/1372383630.23847.40.ca...@deadeye.wl.decadent.org.uk Signed-off-by: Thomas Gleixner t...@linutronix.de Signed-off-by: Steven Rostedt rost...@goodmis.org --- kernel/irq/manage.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index

Bug#700333: [ 059/136 ] clockevents: Set dummy handler on CPU_DEAD shutdown

2013-05-17 Thread Steven Rostedt
...@linutronix.de Signed-off-by: Steven Rostedt rost...@goodmis.org --- kernel/time/tick-broadcast.c |4 kernel/time/tick-common.c|1 + 2 files changed, 5 insertions(+) diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index a13987a..239a323 100644 --- a/kernel/time/tick

Re: PREEMPT_RT vs 'hrtimer: Prevent hrtimer_enqueue_reprogram race'

2013-03-21 Thread Steven Rostedt
On Fri, 2013-03-22 at 01:11 +, Ben Hutchings wrote: Commit b22affe0aef4 'hrtimer: Prevent hrtimer_enqueue_reprogram race' conflicts with the RT patches hrtimer-fixup-hrtimer-callback-changes-for-preempt-r.patch and peter_zijlstra-frob-hrtimer.patch, as they all change

Re: PREEMPT_RT vs 'hrtimer: Prevent hrtimer_enqueue_reprogram race'

2013-03-21 Thread Steven Rostedt
On Fri, 2013-03-22 at 03:24 +, Ben Hutchings wrote: Note, I posted a fix on Tuesday: https://lkml.org/lkml/2013/3/19/369 Thanks. I did search GMANE with some obvious terms but I think its index is lagging. It didn't help that my subject had no mention of -rt in it :-( I'm

Re: [opensuse-kernel] Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Sat, Jul 14, 2012 at 07:48:27PM +0200, Borislav Petkov wrote: Let's have an example: when I have to build upstream on a distro here, I take the distro config and use it despite that it takes a long time to build since everything is module - it is still better for me to wait that one time

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Fri, Jul 13, 2012 at 02:17:30PM -0700, Linus Torvalds wrote: The *two* requirements (and they're really the same theme) I personally think we should have for this are - I think every single select for these things should come with a comment about what it is about and why the distro

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 11:45 -0400, Josh Boyer wrote: Of course the kbuild system would need to verify that the selects exist, and perhaps warn if they do not. But the nice thing about this is that you would get the minconfig for the system you are running. When the system is updated to a

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 08:43 -0700, Linus Torvalds wrote: On Thu, Jul 19, 2012 at 8:26 AM, Steven Rostedt rost...@goodmis.org wrote: Side note, and this is for the 1%. If you want a true minconfig for your system, ktest can do that for you. Try it, it's actually much harder than it seems

Re: [opensuse-kernel] Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 18:48 +0200, Borislav Petkov wrote: Also, if you are building on another box than what the kernel is for, you can go to that box and run 'lsmod /tmp/lsmod'. Copy that file to the build machine (into /tmp/lsmod), and then run 'make LSMOD=/tmp/lsmod localmodconfig',

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 13:19 -0400, Josh Boyer wrote: What about older kernels? Say you installed Fedora 18 with an older kernel that doesn't know what to select? Having the distro tell the kernel what it needs seems to me the easiest for the 99% case. How is the above not telling the

Re: [opensuse-kernel] Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 19:34 +0200, Borislav Petkov wrote: I can pass the above to a allnoconfig, and the box will boot and allow ssh. Note, the reason for the serial config, is that this ktest run uses a serial port to see if the box booted. If the serial isn't there, then it thinks it

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 13:56 -0400, Josh Boyer wrote: Distros aren't stationary things. Exactly my point. I mean, some of them certainly aim for that goal, but userspace and kernels get upgraded all the time. So if this distro-Kconfig file is provided by some package _other_ than the

Re: [RFC] Simplifying kernel configuration for distro issues

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 18:35 -0400, Josh Boyer wrote: 2... yeah. I don't really know if that is going to pan out, but I am ever hopeful. I'd be mostly concerned with people that are coding userspace applications using every whiz-bang kernel feature. Or not paying attention at all to the

Re: About ARCH=sparc and what to pass to recordmcount.pl

2011-08-15 Thread Steven Rostedt
On Mon, 2011-08-15 at 17:21 +0200, Uwe Kleine-König wrote: Hello, when I enable CONFIG_FUNCTION_TRACER and CONFIG_DYNAMIC_FTRACE for the Debian kernel the build fails with: CC init/do_mounts_initrd.o Arch sparc is not supported with CONFIG_FTRACE_MCOUNT_RECORD at

Re: About ARCH=sparc and what to pass to recordmcount.pl

2011-08-15 Thread Steven Rostedt
On Mon, 2011-08-15 at 11:33 -0400, Steven Rostedt wrote: On Mon, 2011-08-15 at 17:21 +0200, Uwe Kleine-König wrote: Hello, when I enable CONFIG_FUNCTION_TRACER and CONFIG_DYNAMIC_FTRACE for the Debian kernel the build fails with: CC init/do_mounts_initrd.o Arch sparc

Re: About ARCH=sparc and what to pass to recordmcount.pl

2011-08-15 Thread Steven Rostedt
On Mon, 2011-08-15 at 12:44 -0700, David Miller wrote: From: Steven Rostedt rost...@goodmis.org Date: Mon, 15 Aug 2011 11:40:23 -0400 Actually, I think option d) is the best. d) have sparc support recordmcount.c Maybe you misunderstand what these guys are doing

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-19 Thread Steven Rostedt
After applying David's remove align patch, I got it to boot on x86_64 with the following two patches. I thought just adding the align to the structure declaration would work, but it still failed on the syscall for init_module. By removing the double declaration of event_exit_##sname, removed this

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-19 Thread Steven Rostedt
On Wed, 2011-01-19 at 11:15 -0500, Mathieu Desnoyers wrote: * Steven Rostedt (rost...@goodmis.org) wrote: After applying David's remove align patch, I got it to boot on x86_64 with the following two patches. I thought just adding the align to the structure declaration would work

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-19 Thread Steven Rostedt
On Wed, 2011-01-19 at 13:40 -0800, David Miller wrote: My concern is that if there is ever a u64 or similarly long long typed member in these tracing structures, it will not be aligned sufficiently to avoid unaligned access traps on 32-bit systems. The structure that gets placed in this

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-18 Thread Steven Rostedt
On Mon, 2011-01-17 at 22:27 -0800, David Miller wrote: I'm beginning to think that the align directive is there purposely to down-align the structure so that the amount of space that tracing information consumes is minimized. I honestly can't tell, only Steven Rostedt can tell us for sure

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-18 Thread Steven Rostedt
On Mon, 2011-01-17 at 22:35 -0800, David Miller wrote: From: Steven Rostedt rost...@goodmis.org Date: Mon, 17 Jan 2011 09:15:41 -0500 Again, this is to help the linker keep arrays in tacked. Tracepoints are allocated into the tracepoint section, and then read like an array. If the linker

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-18 Thread Steven Rostedt
On Tue, 2011-01-18 at 11:46 -0500, Mathieu Desnoyers wrote: * David Miller (da...@davemloft.net) wrote: From: David Miller da...@davemloft.net Date: Mon, 17 Jan 2011 22:00:39 -0800 (PST) ftrace: Remove unnecessary alignment tag from ftrace_event_call. It's completely unnecessary

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-18 Thread Steven Rostedt
On Tue, 2011-01-18 at 12:33 -0500, Steven Rostedt wrote: On Tue, 2011-01-18 at 11:46 -0500, Mathieu Desnoyers wrote: Also align TRACE_PRINTKS on 8 bytes to make sure the beginning of the section is aligned on pointer size. If I can make it crash without the alignments and this fixes

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-18 Thread Steven Rostedt
On Tue, 2011-01-18 at 13:16 -0500, Steven Rostedt wrote: On Tue, 2011-01-18 at 12:33 -0500, Steven Rostedt wrote: On Tue, 2011-01-18 at 11:46 -0500, Mathieu Desnoyers wrote: Also align TRACE_PRINTKS on 8 bytes to make sure the beginning of the section is aligned on pointer size

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-18 Thread Steven Rostedt
On Tue, 2011-01-18 at 15:13 -0500, Mathieu Desnoyers wrote: * Steven Rostedt (rost...@goodmis.org) wrote: On Tue, 2011-01-18 at 13:16 -0500, Steven Rostedt wrote: On Tue, 2011-01-18 at 12:33 -0500, Steven Rostedt wrote: On Tue, 2011-01-18 at 11:46 -0500, Mathieu Desnoyers wrote

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-17 Thread Steven Rostedt
[ Added Mathieu on Cc, since he likes alignments ;-) ] On Sun, 2011-01-16 at 11:39 -0800, David Miller wrote: From: Richard Mortimer ri...@oldelvet.org.uk Date: Sun, 16 Jan 2011 14:17:49 + I'm wondering if gcc is just getting better at honouring the source code. The DEFINE_EVENT

Bug#609371: linux-image-2.6.37-trunk-sparc64: module scsi_mod: Unknown relocation: 36

2011-01-17 Thread Steven Rostedt
On Mon, 2011-01-17 at 10:22 +, Richard Mortimer wrote: On Sun, 2011-01-16 at 22:07 -0800, David Miller wrote: From: David Miller da...@davemloft.net Date: Sat, 15 Jan 2011 21:17:22 -0800 (PST) I think the problem we have here is that the _ftrace_events section is not aligned