Re: [PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-04 Thread Asbjørn Sloth Tønnesen
On 11/04/2010 12:36 PM, Michal Marek wrote: > On 4.11.2010 13:29, Asbjørn Sloth Tønnesen wrote: >> No, not if you are cross compiling since ARCH=x86 isn't specific to >> either, we would have to look at the config. In that case it is better >> to do something like: >> >> x86|i386|x86_64) >> de

Re: [PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-04 Thread Michal Marek
On 4.11.2010 13:29, Asbjørn Sloth Tønnesen wrote: > No, not if you are cross compiling since ARCH=x86 isn't specific to > either, we would have to look at the config. In that case it is better > to do something like: > > x86|i386|x86_64) > debarch=$(grep -q CONFIG_64BIT=y .config && No, you

Re: [PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-04 Thread Asbjørn Sloth Tønnesen
On 11/04/2010 05:58 AM, Sam Ravnborg wrote: > On Thu, Nov 04, 2010 at 03:44:04AM +, Asbjoern Sloth Toennesen wrote: >> [...] >> +# Attempt to find the correct Debian architecture >> +local forcearch="" debarch="" >> +case "$ARCH" in >> +i386|ia64) >> +debarch="$ARCH"

Re: [PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-03 Thread Sam Ravnborg
On Thu, Nov 04, 2010 at 03:44:04AM +, Asbjoern Sloth Toennesen wrote: > Attempt to guess the correct value of the Architecture control > field, based on the ARCH environment variable. Fallback to letting > deb-gencontrol use the host platform's architecture. > > With this patch the following m

[PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-03 Thread Asbjoern Sloth Toennesen
Attempt to guess the correct value of the Architecture control field, based on the ARCH environment variable. Fallback to letting deb-gencontrol use the host platform's architecture. With this patch the following make command: make ARCH=i386 deb-pkg will output an i386 Debian package ins

Re: [PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-03 Thread Asbjørn Sloth Tønnesen
On 11/04/2010 02:42 AM, Asbjoern Sloth Toennesen wrote: > + case "$SUBARCH" in > + arm) debarch=$(grep -q CONFIG_AEABI=y .config \ > + && echo armel || echo arm) ;; > + esac Hmm, didn't

[PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-03 Thread Asbjoern Sloth Toennesen
Attempt to guess the correct value of the Architecture control field, based on the ARCH environment variable. Fallback to letting deb-gencontrol use the host platform's architecture. With this patch the following make command: make ARCH=i386 deb-pkg will output an i386 Debian package ins

Re: [PATCH] kbuild, deb-pkg: fix Architecture field when cross compiling

2010-11-03 Thread Asbjørn Sloth Tønnesen
On 11/03/2010 10:57 PM, Michal Marek wrote: > I know very little about debian packaging, but shouldn't this be done in > all cases, regardless of CROSS_COMPILE being set or not? You even show > in the above example that in some cases you don't need CROSS_COMPILE to > build a kernel for a different