Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-11-01 Thread James Addison
Source: firmware-nonfree Followup-For: Bug #1035505 X-Debbugs-Cc: didi.deb...@cknow.org, 1029...@bugs.debian.org, k...@debian.org Control: forwarded -1 https://salsa.debian.org/kernel-team/firmware-nonfree/-/merge_requests/65 Control: tags -1 patch Please find an updated attempt to handle spaces

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread James Addison
Followup-For: Bug #1035505 X-Debbugs-Cc: didi.deb...@cknow.org, 1029...@bugs.debian.org, k...@debian.org Yep, those two issues seem accurate to me: splitting the config file list (a trickier prospect than it seemed it should be, because newlines have been converted into spaces), and then quoting

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Cyril Brulebois
Cyril Brulebois (2023-05-04): > The problem is the next stage, distributing the relevant files into the > appropriate binary packages. That part is controlled by the defines, and > that's what needs to be adjusted (file format and/or how it's used). > > A quick look suggests files_orig isn't set

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Diederik de Haas
On Thursday, 4 May 2023 12:25:29 CEST Diederik de Haas wrote: > While trying to prepare a MR to fix bug #1029843, I encountered a > failure which seems to be `gencontrol.py`'s inability to deal with > spaces and/or backslashes (used to escape the spaces). Here's the branch that I created:

Bug#1029843: Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Cyril Brulebois
James Addison (2023-05-04): > I think that the edits to 'debian/config/brcm80211/defines' may be the cause > of the space-escaping issue (noticed that in your fork on Salsa). > > Building locally without modifications from firmware-nonfree_20230210-5 I get: > lrwxrwxrwx 1 jka jka 44 May 4

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread James Addison
Source: firmware-nonfree Followup-For: Bug #1035505 X-Debbugs-Cc: didi.deb...@cknow.org, 1029...@bugs.debian.org, k...@debian.org Looks like a silently-handled exception here:

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread James Addison
Source: firmware-nonfree Followup-For: Bug #1035505 X-Debbugs-Cc: didi.deb...@cknow.org, 1029...@bugs.debian.org, k...@debian.org Hey Diederik, I think that the edits to 'debian/config/brcm80211/defines' may be the cause of the space-escaping issue (noticed that in your fork on Salsa). Building

Bug#1035505: firmware-nonfree: debian/bin/gencontrol.py fails on spaces and backslashes

2023-05-04 Thread Diederik de Haas
Source: firmware-nonfree Version: 20230210-5 Severity: normal X-Debbugs-Cc: 1029...@bugs.debian.org, k...@debian.org -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 While trying to prepare a MR to fix bug #1029843, I encountered a failure which seems to be `gencontrol.py`'s inability to deal