Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-19 Thread James Bottomley
On Tue, 2011-04-19 at 11:20 +0200, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH v2] pata_cmd64x: add enablebits checking > > Fixes IDE -> libata regression. > > IDE's cmd64x host driver has been supporting enablebits checking > since the initial driver's m

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-19 Thread Alan Cox
On Tue, 19 Apr 2011 13:50:12 +0200 Bartlomiej Zolnierkiewicz wrote: > On Tue, Apr 19, 2011 at 12:08 PM, Alan Cox wrote: > >> From: Bartlomiej Zolnierkiewicz > >> Subject: [PATCH v2] pata_cmd64x: add enablebits checking > >> > >> Fixes IDE -> libata regression. > > > > And causes a regression to

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-19 Thread Bartlomiej Zolnierkiewicz
On Tue, Apr 19, 2011 at 12:08 PM, Alan Cox wrote: >> From: Bartlomiej Zolnierkiewicz >> Subject: [PATCH v2] pata_cmd64x: add enablebits checking >> >> Fixes IDE -> libata regression. > > And causes a regression too Could you be more explicit? Regression in this patch would mean that old driver

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-19 Thread Alan Cox
> From: Bartlomiej Zolnierkiewicz > Subject: [PATCH v2] pata_cmd64x: add enablebits checking > > Fixes IDE -> libata regression. And causes a regression too With the check for parent bridge not being a split bridge I think however it'll do the job nicely. Alan -- To UNSUBSCRIBE, email to d

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-19 Thread Bartlomiej Zolnierkiewicz
Hi, Sergei Shtylyov wrote: > Hello. > > James Bottomley wrote: > > >>> I can get all of this working by fixing up all the hard coded knowledge > >>> in libata-sff only to use a single port. > >>> However, I can't fix the libata-sff driver until I know how to tell > >>> there's only one port wi

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-18 Thread Sergei Shtylyov
Hello. James Bottomley wrote: I can get all of this working by fixing up all the hard coded knowledge in libata-sff only to use a single port. However, I can't fix the libata-sff driver until I know how to tell there's only one port wired. Does anyone with cmd649 knowledge have any idea how I

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-18 Thread James Bottomley
On Mon, 2011-04-18 at 14:12 +0400, Sergei Shtylyov wrote: > Hello. > > On 18-04-2011 3:58, James Bottomley wrote: > > > I've got a parisc system where the DVD drive is hardwired to a silicon > > image controller: > > > 00:02.0 IDE interface: Silicon Image, Inc. SiI 0649 Ultra ATA/100 PCI to > >

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-18 Thread Sergei Shtylyov
Hello. On 18-04-2011 3:58, James Bottomley wrote: I've got a parisc system where the DVD drive is hardwired to a silicon image controller: 00:02.0 IDE interface: Silicon Image, Inc. SiI 0649 Ultra ATA/100 PCI to ATA Host Controller (rev 02) (prog-if 8f [Master SecP SecO PriP PriO])

Bug#622997: libata-sff/pata_cmd64x problem with hardwired configurations

2011-04-17 Thread James Bottomley
I've got a parisc system where the DVD drive is hardwired to a silicon image controller: 00:02.0 IDE interface: Silicon Image, Inc. SiI 0649 Ultra ATA/100 PCI to ATA Host Controller (rev 02) (prog-if 8f [Master SecP SecO PriP PriO]) Subsystem: Silicon Image, Inc. SiI 0649 Ultra ATA/100 PCI