Felix Lechner pushed to branch master at lintian / lintian


Commits:
2dc42ac0 by Felix Lechner at 2022-01-13T06:26:12-08:00
Exempt backports to bullseye from changelog-file-missing-explicit-entry. 
(Closes: #941656)

This check has seen repeated work over the years, but has not worked well since
before I started working on Lintian. Some small fixes such as this one [1] may,
however, make a difference already.

With the current development version, I cannot reproduce the reports for 
'ddd'
or 'shc'. The relevant Lintian output for those sources from 
snapshots.d.o is
attached below.

The version of xplanet 1.3.1-0.1 does not appear to have been released publicly
and was not available for review.

For the backport issue reported by Shengjing Zhu for 'golang-1.15' I 
made the
same adjustment as generations of Lintian maintainers before, which is the only
fix committed here. I consider that solution inferior because it merely
postpones the issue into the next release cycle.

A smarter, although still incomplete, fix might be to rely on information from
'distro-info' for the release names. That idea has been mentioned for 
Lintian in
a related context [2] but has not been implemented.

As a side note, while versions seem so intuitive to most of us, parsing them is
by many accounts one of the more challenging tasks in Debian. [3] Patches are
welcome.

Thanks to everyone for reporting on this recurring issue! It probably won't 
be
your last time.

* * *

[1] 
https://salsa.debian.org/lintian/lintian/-/commit/f7f4ac033fcc0939fe26ac59732878c7ad46be3b
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1001399#6
[3] 
https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Changelog/Version.pm#L72-172

➤ ../../git/bin/lintian shc_4.0.3-0.1.dsc
I: shc source: patch-not-forwarded-upstream 
[debian/patches/010_fix-rc-path.patch]
P: shc source: package-uses-old-debhelper-compat-version 12
X: shc source: debian-watch-does-not-check-gpg-signature [debian/watch]
X: shc source: upstream-metadata-file-is-missing

➤ ../../git/bin/lintian ddd_3.3.12-5.2.dsc
I: ddd source: debian-watch-uses-insecure-uri 
ftp://ftp.gnu.org/gnu/ddd/ddd-([0-9.]*)\.tar\.gz [debian/watch:3]
I: ddd source: older-debian-watch-file-standard 3 [debian/watch]
I: ddd source: out-of-date-standards-version 4.4.0 (released 2019-07-07) 
(current is 4.6.0.2)
I: ddd source: quilt-patch-missing-description 
[debian/patches/001_debian_paths.diff]
I: ddd source: quilt-patch-missing-description 
[debian/patches/002_sensible_editor.diff]
I: ddd source: quilt-patch-missing-description 
[debian/patches/003_data_path.diff]
I: ddd source: quilt-patch-missing-description ... use --no-tag-display-limit 
to see all (or pipe to a file/program)
P: ddd source: homepage-field-uses-insecure-uri http://www.gnu.org/software/ddd/
P: ddd source: no-dep5-copyright [debian/copyright]
P: ddd source: package-uses-old-debhelper-compat-version 12
P: ddd source: silent-on-rules-requiring-root [debian/control]
P: ddd source: trailing-whitespace [debian/changelog:196]
P: ddd source: trailing-whitespace [debian/changelog:201]
P: ddd source: trailing-whitespace [debian/changelog:242]
P: ddd source: trailing-whitespace ... use --no-tag-display-limit to see all 
(or pipe to a file/program)
P: ddd source: very-long-line-length-in-source-file line 186 is 609 characters 
long (>512) [ddd/PICS/ddd-console.xpm]
P: ddd source: very-long-line-length-in-source-file line 255 is 1349 characters 
long (>512) [ddd/PICS/ddd-define-command.xpm]
P: ddd source: very-long-line-length-in-source-file line 261 is 609 characters 
long (>512) [ddd/PICS/ddd-display.xpm]
P: ddd source: very-long-line-length-in-source-file ... use 
--no-tag-display-limit to see all (or pipe to a file/program)
X: ddd source: debian-rules-uses-as-needed-linker-flag [debian/rules:5]
X: ddd source: debian-watch-does-not-check-gpg-signature [debian/watch]
X: ddd source: upstream-metadata-file-is-missing

➤ ../../git/bin/lintian golang-1.15_1.15.15-1\%7Edeb11u2.dsc
E: golang-1.15 source: source-is-missing [misc/trace/trace_viewer_full.html]
E: golang-1.15 source: source-is-missing [misc/trace/webcomponents.min.js]
E: golang-1.15 source: source-is-missing 
[src/debug/dwarf/testdata/line-clang.elf]
E: golang-1.15 source: source-is-missing ... use --no-tag-display-limit to see 
all (or pipe to a file/program)
E: golang-1.15 source: unknown-file-in-debian-source 
[debian/source/lintian-overrides.in]
E: golang-1.15 source: unpack-message-for-orig golang-1.15_1.15.15.orig.tar.gz 
. ar failed for 
go/src/go/internal/gcimporter/testdata/versions/test_go1.11_999b.a
E: golang-1.15 source: unpack-message-for-orig golang-1.15_1.15.15.orig.tar.gz 
. ar failed for go/src/go/internal/gcimporter/testdata/versions/test_go1.8_4.a
E: golang-1.15 source: unpack-message-for-orig golang-1.15_1.15.15.orig.tar.gz 
. ar failed for go/src/go/internal/gcimporter/testdata/versions/test_go1.8_5.a
W: golang-1.15 source: mismatched-override source-contains-prebuilt-binary 
src/cmd/internal/buildid/testdata/a.elf [debian/source/lintian-overrides:5]
W: golang-1.15 source: mismatched-override source-contains-prebuilt-binary 
src/cmd/vendor/github.com/google/pprof/internal/report/testdata/sample.bin 
[debian/source/lintian-overrides:6]
W: golang-1.15 source: mismatched-override source-contains-prebuilt-binary 
src/debug/dwarf/testdata/cycle.elf [debian/source/lintian-overrides:7]
W: golang-1.15 source: mismatched-override ... use --no-tag-display-limit to 
see all (or pipe to a file/program)
W: golang-1.15 source: no-nmu-in-changelog [debian/changelog:1]
W: golang-1.15 source: source-contains-prebuilt-windows-binary 
[src/debug/dwarf/testdata/line-gcc-win.bin]
W: golang-1.15 source: source-contains-prebuilt-windows-binary 
[src/debug/pe/testdata/gcc-386-mingw-exec]
W: golang-1.15 source: source-contains-prebuilt-windows-binary 
[src/debug/pe/testdata/gcc-386-mingw-no-symbols-exec]
W: golang-1.15 source: source-contains-prebuilt-windows-binary ... use 
--no-tag-display-limit to see all (or pipe to a file/program)
W: golang-1.15 source: source-nmu-has-incorrect-version-number 
1.15.15-1~deb11u2 [debian/changelog:1]
W: golang-1.15 source: superfluous-file-pattern 
src/cmd/vendor/golang.org/x/arch/x86/x86asm/testdata/libmach8db.c 
[debian/copyright:9]
I: golang-1.15 source: debian-rules-parses-dpkg-parsechangelog 
[debian/rules:127]
I: golang-1.15 source: debian-rules-parses-dpkg-parsechangelog [debian/rules:5]
I: golang-1.15 source: out-of-date-standards-version 4.5.1 (released 
2020-11-17) (current is 4.6.0.2)
I: golang-1.15 source: public-upstream-key-not-minimal has 2 extra signature(s) 
for keyid 7721F63BD38B4796 [debian/upstream/signing-key.asc]
I: golang-1.15 source: unpack-message-for-source ar failed for 
src/go/internal/gcimporter/testdata/versions/test_go1.11_999b.a
I: golang-1.15 source: unpack-message-for-source ar failed for 
src/go/internal/gcimporter/testdata/versions/test_go1.8_4.a
I: golang-1.15 source: unpack-message-for-source ar failed for 
src/go/internal/gcimporter/testdata/versions/test_go1.8_5.a
P: golang-1.15 source: embedded-script-includes-copyright-statement extract of 
copyright statement: copyright 2015 the chromium authors. all rights reserved. 
[misc/trace/trace_viewer_full.html]
P: golang-1.15 source: source-contains-browserified-javascript code 
fragment:if("object"==typeof 
exports&&"undefined"!=typeof module)module.exports=t();else 
if("fu [misc/trace/trace_viewer_full.html]
P: golang-1.15 source: source-contains-prebuilt-binary 
[src/debug/dwarf/testdata/cppunsuptypes.elf]
P: golang-1.15 source: source-contains-prebuilt-binary 
[src/debug/dwarf/testdata/cycle.elf]
P: golang-1.15 source: source-contains-prebuilt-binary 
[src/debug/dwarf/testdata/line-clang.elf]
P: golang-1.15 source: source-contains-prebuilt-binary ... use 
--no-tag-display-limit to see all (or pipe to a file/program)
P: golang-1.15 source: source-contains-prebuilt-javascript-object 
[misc/trace/trace_viewer_full.html]
P: golang-1.15 source: source-contains-prebuilt-javascript-object 
[misc/trace/webcomponents.min.js]
P: golang-1.15 source: update-debian-copyright 2019 vs 2021 
[debian/copyright:218]
P: golang-1.15 source: very-long-line-length-in-source-file line 1 is 100002 
characters long (>512) [src/compress/testdata/e.txt]
P: golang-1.15 source: very-long-line-length-in-source-file line 1 is 100002 
characters long (>512) [src/compress/testdata/pi.txt]
P: golang-1.15 source: very-long-line-length-in-source-file line 1 is 1024 
characters long (>512) [src/archive/tar/testdata/nil-uid.tar]
P: golang-1.15 source: very-long-line-length-in-source-file ... use 
--no-tag-display-limit to see all (or pipe to a file/program)
X: golang-1.15 source: upstream-metadata-file-is-missing

- - - - -


1 changed file:

- lib/Lintian/Check/Debian/Changelog.pm


Changes:

=====================================
lib/Lintian/Check/Debian/Changelog.pm
=====================================
@@ -264,8 +264,8 @@ sub source {
                 $latest_version->literal
               )
               unless $previous_version->literal eq $expected_previous
-              || $latest_entry->Distribution eq 'buster'
-              || $previous_entry->Distribution eq 'buster'
+              || $latest_entry->Distribution eq 'bullseye'
+              || $previous_entry->Distribution eq 'bullseye'
               || $latest_entry->Distribution =~ /-security$/i;
 
             if (   $latest_version->epoch eq $previous_version->epoch



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/2dc42ac0dc2073d6537203cbb4fb82d82460d7ef

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/2dc42ac0dc2073d6537203cbb4fb82d82460d7ef
You're receiving this email because of your account on salsa.debian.org.


Reply via email to