Re: [RFC/PATCH] New Lintian::Output module

2008-09-23 Thread Raphael Geissert
Frank Lichtenheld wrote: > On Mon, Sep 22, 2008 at 06:40:15PM -0500, Raphael Geissert wrote: >> >> Hmm, right. Maybe output "formaters" should be able to indicate at what >> point of the process they want to act/be called. > > Nah, no need to expose that to the outside. As I said, adding > calls

Re: [RFC/PATCH] New Lintian::Output module

2008-09-22 Thread Frank Lichtenheld
On Mon, Sep 22, 2008 at 06:40:15PM -0500, Raphael Geissert wrote: > Jordà Polo wrote: > > On Sun, Sep 21, 2008 at 12:51:44PM -0500, Raphael Geissert wrote: > >> Btw, why would it be any useful to print them until the whole package is > >> processed? I would find printing them after every check scri

Re: [RFC/PATCH] New Lintian::Output module

2008-09-22 Thread Raphael Geissert
Jordà Polo wrote: > On Sun, Sep 21, 2008 at 12:51:44PM -0500, Raphael Geissert wrote: >> Btw, why would it be any useful to print them until the whole package is >> processed? I would find printing them after every check script is run >> better. > > The current lintian output is thought to be hum

Re: [RFC/PATCH] New Lintian::Output module

2008-09-22 Thread Jordà Polo
On Sun, Sep 21, 2008 at 12:51:44PM -0500, Raphael Geissert wrote: > Btw, why would it be any useful to print them until the whole package is > processed? I would find printing them after every check script is run > better. The current lintian output is thought to be human-readable _and_ machine-pa

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Frank Lichtenheld
On Sun, Sep 21, 2008 at 02:06:46PM -0700, Russ Allbery wrote: > Frank Lichtenheld <[EMAIL PROTECTED]> writes: > > > I agree. > > > > Maybe it could also be used to rate limiting like we currently do for > > e.g. hyphen-used-as-minus-sign. > > > > Patches in this direction are welcome. > > Maybe w

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Russ Allbery
Frank Lichtenheld <[EMAIL PROTECTED]> writes: > I agree. > > Maybe it could also be used to rate limiting like we currently do for > e.g. hyphen-used-as-minus-sign. > > Patches in this direction are welcome. Maybe we could lift the rate limiting up into metadata in the *.desc file, too? I don't

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Frank Lichtenheld
On Sun, Sep 21, 2008 at 12:51:44PM -0500, Raphael Geissert wrote: > Jordà Polo wrote: > ... > > > > One of the outputs I thought about involved printing after processing > > the packages instead of printing as tags are found. > > This could also help avoid the usage of $warned{tag-name} and simi

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Frank Lichtenheld
On Sun, Sep 21, 2008 at 05:58:27PM +0200, Jordà Polo wrote: > On Sat, Sep 20, 2008 at 01:57:45PM +0200, Frank Lichtenheld wrote: > > A patch series to bundle all the output logic of lintian into > > modules and to make it easier to define new output formats. > > > > Comments welcome. > > Good. I

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Raphael Geissert
Jordà Polo wrote: ... > > One of the outputs I thought about involved printing after processing > the packages instead of printing as tags are found. This could also help avoid the usage of $warned{tag-name} and similar kind of checks to avoid issuing duplicated tags. Of course it also depends o

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Jordà Polo
On Sat, Sep 20, 2008 at 01:57:45PM +0200, Frank Lichtenheld wrote: > A patch series to bundle all the output logic of lintian into > modules and to make it easier to define new output formats. > > Comments welcome. Good. I think it is better than the current way of doing it, just a few comments:

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Adam D. Barratt
On Sat, 2008-09-20 at 13:57 +0200, Frank Lichtenheld wrote: > A patch series to bundle all the output logic of lintian into > modules and to make it easier to define new output formats. > > Comments welcome. Sounds good to me. Adam -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject

Re: [RFC/PATCH] New Lintian::Output module

2008-09-21 Thread Frank Lichtenheld
On Sat, Sep 20, 2008 at 06:57:17PM -0700, Russ Allbery wrote: > Frank Lichtenheld <[EMAIL PROTECTED]> writes: > > > A patch series to bundle all the output logic of lintian into > > modules and to make it easier to define new output formats. > > > > Comments welcome. > > Looks like a great idea t

Re: [RFC/PATCH] New Lintian::Output module

2008-09-20 Thread Russ Allbery
Frank Lichtenheld <[EMAIL PROTECTED]> writes: > A patch series to bundle all the output logic of lintian into > modules and to make it easier to define new output formats. > > Comments welcome. Looks like a great idea to me. I'd like to add POD documentation to all of Lintian's internal modules,

[RFC/PATCH] New Lintian::Output module

2008-09-20 Thread Frank Lichtenheld
A patch series to bundle all the output logic of lintian into modules and to make it easier to define new output formats. Comments welcome. Gruesse, -- Frank Lichtenheld <[EMAIL PROTECTED]> www: http://www.djpig.de/ >From 86dd77bd3dff8cc9d0399875aa0db3e7a201187c Mon Sep 17 00:00:00 2001 From: Fr