Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-15 Thread Russ Allbery
Niels Thykier ni...@thykier.net writes: I usually buy the All caps as global variables, but I still like to differ between exported/public variables and internal global variables. [...] My second reason is that I like to know that if I want to change (the format of) a variable, I know I

Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-14 Thread Niels Thykier
On 2011-08-14 00:56, Russ Allbery wrote: Niels Thykier ni...@thykier.net writes: Turns out this particular these two were not Perlcritic issues (I applied these fixes from my memory of previous Perlcritic issues). Oh! Okay. I'm actually surprised on the variable one, as I've seen things

Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-14 Thread Niels Thykier
On 2011-08-14 00:11, Jeremiah C. Foster wrote: [...] On the other issue, I thought the $C, @C-thing was covered by the re-use of same variable in lexical scope, but it turns out it isn't (probably due to the types being different). I can see the idea behind it now, sort of like a C-string

[SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-13 Thread Niels Thykier
The following commit has been merged in the master branch: commit 39af0d703f0a562a6734c1425c137d856e7bf02c Author: Niels Thykier ni...@thykier.net Date: Sat Aug 13 18:15:53 2011 +0200 Perlcritic cleaned c/standards-version diff --git a/checks/standards-version b/checks/standards-version

Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-13 Thread Russ Allbery
Niels Thykier ni...@thykier.net writes: Perlcritic cleaned c/standards-version -our $STANDARDS = Lintian::Data-new('standards-version/release-dates', '\s+'); +my $STANDARDS = Lintian::Data-new('standards-version/release-dates', qr/\s+/o); These are file globals -- why would one use

Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-13 Thread Niels Thykier
On 2011-08-13 23:13, Russ Allbery wrote: Niels Thykier ni...@thykier.net writes: Perlcritic cleaned c/standards-version -our $STANDARDS = Lintian::Data-new('standards-version/release-dates', '\s+'); +my $STANDARDS = Lintian::Data-new('standards-version/release-dates', qr/\s+/o);

Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-13 Thread Jeremiah C. Foster
On Aug 13, 2011, at 23:57, Niels Thykier wrote: On 2011-08-13 23:13, Russ Allbery wrote: Niels Thykier ni...@thykier.net writes: Perlcritic cleaned c/standards-version -our $STANDARDS = Lintian::Data-new('standards-version/release-dates', '\s+'); +my $STANDARDS =

Re: [SCM] Debian package checker branch, master, updated. 2.5.2-11-g39af0d7

2011-08-13 Thread Russ Allbery
Niels Thykier ni...@thykier.net writes: Turns out this particular these two were not Perlcritic issues (I applied these fixes from my memory of previous Perlcritic issues). Oh! Okay. I'm actually surprised on the variable one, as I've seen things like that from perlcritic before. So the