Re: Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-08 Thread Raphael Geissert
Russ Allbery wrote: > > I used readdir and a regex match. The glob is probably also about as fast > with a current version of Perl that doesn't fork a shell to do the glob, > though. I learned my aversion to using globs in Perl back when they > involved forking an external csh binary, and probab

Re: Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-08 Thread Russ Allbery
Raphael Geissert writes: > Right, I don't know why I didn't think about using unlink <.${coll}*>; > instead. I used readdir and a regex match. The glob is probably also about as fast with a current version of Perl that doesn't fork a shell to do the glob, though. I learned my aversion to using

Re: Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-08 Thread Raphael Geissert
Russ Allbery wrote: > Raphael Geissert writes: > >> # info already available? >> -next if (-e "$base/$ci->{'output'}"); >> +next if (-l "$base/.${coll}$ci->{'version'}"); >> +system('sh', '-c', 'rm -f '."'$base'/.${coll}*"); > > Ew. We can do this in native Perl in jus

Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-08 Thread Russ Allbery
Raphael Geissert writes: > # info already available? > - next if (-e "$base/$ci->{'output'}"); > + next if (-l "$base/.${coll}$ci->{'version'}"); > + system('sh', '-c', 'rm -f '."'$base'/.${coll}*"); Ew. We can do this in native Perl in just a few lines of code

Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-04 Thread Raphael Geissert
tag 517650 patch thanks Attached mbox should do it. It would help me a lot if you could merge the collection-related changes (this one, the one about running them in parallel, and any other I might be missing) so that I can make the necessary changes to drop the Order field and smartly run the

Processed: Re: Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-04 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > tag 517650 patch Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes There were no tags set. Tags added: patch > thanks Stopping processing here. Please contact me if you need assistance.

Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-01 Thread Russ Allbery
Raphael Geissert writes: > Russ Allbery wrote: >> The one tweak that I'd make is to list all of the files that a given >> collection script creates in the Output field still, but use that only >> to determine which files to remove when the version is out of date. > > I didn't consider that becaus

Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-01 Thread Raphael Geissert
Russ Allbery wrote: > Raphael Geissert writes: > >> When a collection script is modified, the changes are not reflected even >> if the same package is re-unpacked or re-processed. This could lead to >> certain temporary miss behaviours. > > That's why you're supposed to increase the lab format v

Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-03-01 Thread Russ Allbery
Raphael Geissert writes: > When a collection script is modified, the changes are not reflected even > if the same package is re-unpacked or re-processed. This could lead to > certain temporary miss behaviours. That's why you're supposed to increase the lab format version when you change collect

Bug#517650: lintian: changes made to collection scripts are not reflected unless a package changes

2009-02-28 Thread Raphael Geissert
Package: lintian Version: 2.2.6 Severity: minor When a collection script is modified, the changes are not reflected even if the same package is re-unpacked or re-processed. This could lead to certain temporary miss behaviours. IMHO the most reasonable way to make sure the data generated by the