Hi Niels,
Niels Thykier writes:
> I thought this was safe, but it does have an issue as well. Consider
> symlink chaining:
>
> safe-symlink -> unsafe-symlink
> unsafe-symlink -> ../../../../etc/passwd
>
> $path->link_resolved will approve "safe-symlink" because it can be
> resolved safely.
On 2013-04-06 18:33, Michael Stapelberg wrote:
> Hi Niels,
>
> [...]
> Okay, so how about this?
>
> sub check_init_script {
> my ($pkg, $info, $file) = @_;
>
> my $lsb_source_seen;
> my $path = $info->index ($file);
> unless ($path->is_regular_file ||
> ($path->is_sym
Hi Niels,
Thanks for your prompt reply.
Niels Thykier writes:
> Tests! Once there are tests for all the new tags (and none of the
> existing tests breaks) we are usually ready to accept the checks.
Cool.
Find attached two git format-patch files. The first adds the latest
version of my systemd
On 2013-04-06 20:44, Michael Stapelberg wrote:
> Hi Niels,
>
> Niels Thykier writes:
>> I think you are missing a return here?
> Indeed, thanks.
>
> New files are attached, here is the list of things that I know need to
> be fixed:
>
> 1) We don’t have any documentation references in the .desc
Hi Niels,
Niels Thykier writes:
> I think you are missing a return here?
Indeed, thanks.
New files are attached, here is the list of things that I know need to
be fixed:
1) We don’t have any documentation references in the .desc file yet.
2) I need to switch to lab_data_path in check_maintainer
On 2013-04-06 18:33, Michael Stapelberg wrote:
> Hi Niels,
>
> Niels Thykier writes:
>> [...]
>> Almost; it definitely plugs the issues I mentioned. That said, I
>> believe we prefer to emit tags instead of erroring out when we see an
>> unexpected file type (e.g. see control-file-is-not-a-file)
Hi Niels,
Niels Thykier writes:
>> sub check_init_script {
>> my ($pkg, $info, $file) = @_;
>>
>> my $lsb_source_seen;
>> my $path = $info->index ($file);
>> fail "$file is neither a regular file nor a resolvable symlink"
>> unless ($path->is_regular_file || defined($path
On 2013-03-29 15:24, Michael Stapelberg wrote:
> Hi Niels,
>
> Thanks for the super-fast review. New version is attached, I have fixed
> everything you mentioned, and for the other things I commented inline:
>
You are welcome :) I have not reviewed your revised version yet, but I
will try to lo
Michael Stapelberg writes:
> Niels Thykier writes:
>> guidelines. I know Lintian's code style is a mess in general, so it
>> describes the style I hope we will eventually reach[1]. :)
> Have you tried using perltidy for Lintian? I loathe manual source code
> formatting after working with gofm
Hi Niels,
Thanks for the super-fast review. New version is attached, I have fixed
everything you mentioned, and for the other things I commented inline:
Niels Thykier writes:
> guidelines. I know Lintian's code style is a mess in general, so it
> describes the style I hope we will eventually re
On 2013-03-29 11:11, Michael Stapelberg wrote:
> Package: lintian
> Version: 2.5.10.4
> Severity: wishlist
>
> Attached you can find my first stab at systemd-related checks for
> lintian. While some details in parsing the service files are not
> implemented (see the TODOs in the code), I’d like yo
Package: lintian
Version: 2.5.10.4
Severity: wishlist
Attached you can find my first stab at systemd-related checks for
lintian. While some details in parsing the service files are not
implemented (see the TODOs in the code), I’d like you to have a look at
the checks in general. Is there anything
12 matches
Mail list logo
