Hi Niels,
Niels Thykier ni...@thykier.net writes:
I thought this was safe, but it does have an issue as well. Consider
symlink chaining:
safe-symlink - unsafe-symlink
unsafe-symlink - ../../../../etc/passwd
$path-link_resolved will approve safe-symlink because it can be
resolved
On 2013-04-06 18:33, Michael Stapelberg wrote:
Hi Niels,
[...]
Okay, so how about this?
sub check_init_script {
my ($pkg, $info, $file) = @_;
my $lsb_source_seen;
my $path = $info-index ($file);
unless ($path-is_regular_file ||
($path-is_symlink
Hi Niels,
Thanks for your prompt reply.
Niels Thykier ni...@thykier.net writes:
Tests! Once there are tests for all the new tags (and none of the
existing tests breaks) we are usually ready to accept the checks.
Cool.
Find attached two git format-patch files. The first adds the latest
On 2013-04-06 20:44, Michael Stapelberg wrote:
Hi Niels,
Niels Thykier ni...@thykier.net writes:
I think you are missing a return here?
Indeed, thanks.
New files are attached, here is the list of things that I know need to
be fixed:
1) We don’t have any documentation references in the
Hi Niels,
Niels Thykier ni...@thykier.net writes:
sub check_init_script {
my ($pkg, $info, $file) = @_;
my $lsb_source_seen;
my $path = $info-index ($file);
fail $file is neither a regular file nor a resolvable symlink
unless ($path-is_regular_file ||
Hi Niels,
Niels Thykier ni...@thykier.net writes:
I think you are missing a return here?
Indeed, thanks.
New files are attached, here is the list of things that I know need to
be fixed:
1) We don’t have any documentation references in the .desc file yet.
2) I need to switch to lab_data_path in
On 2013-03-29 15:24, Michael Stapelberg wrote:
Hi Niels,
Thanks for the super-fast review. New version is attached, I have fixed
everything you mentioned, and for the other things I commented inline:
You are welcome :) I have not reviewed your revised version yet, but I
will try to look
Package: lintian
Version: 2.5.10.4
Severity: wishlist
Attached you can find my first stab at systemd-related checks for
lintian. While some details in parsing the service files are not
implemented (see the TODOs in the code), I’d like you to have a look at
the checks in general. Is there anything
On 2013-03-29 11:11, Michael Stapelberg wrote:
Package: lintian
Version: 2.5.10.4
Severity: wishlist
Attached you can find my first stab at systemd-related checks for
lintian. While some details in parsing the service files are not
implemented (see the TODOs in the code), I’d like you to
Hi Niels,
Thanks for the super-fast review. New version is attached, I have fixed
everything you mentioned, and for the other things I commented inline:
Niels Thykier ni...@thykier.net writes:
guidelines. I know Lintian's code style is a mess in general, so it
describes the style I hope we
Michael Stapelberg stapelb...@debian.org writes:
Niels Thykier ni...@thykier.net writes:
guidelines. I know Lintian's code style is a mess in general, so it
describes the style I hope we will eventually reach[1]. :)
Have you tried using perltidy for Lintian? I loathe manual source code
11 matches
Mail list logo
