Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-31 Thread Niels Thykier
On 2015-08-30 21:49, Axel Beckert wrote: > Hi, > > [...] > > But where to make the cut? Just because a regexp uses "(?!…)"? Surely > not! Or because it is too long? Doesn't sound like a valid reason > either. > Personally, I would like to see fewer regexs myself. Not because we use weird

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-31 Thread Axel Beckert
Hi Niels, Niels Thykier wrote: > > Anyway: I think we should _generally_ improve the situation and not > > duplicating functionality for a single tag. > > Flip-side: There is no much gain in it for us to have 20 distinct > "foo-installs-bar" tags when 1 could do. It is certainly a trade-off >

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-30 Thread Axel Beckert
Hi, Axel Beckert wrote: 'adduser --home /var/lib/saned --quiet --system --no-create-home --group saned || true' Lintian uses this regexp (see data/scripts/maintainer-script-bad-command): (adduser(?:\s.*)?\s--system(?=\s)(?!.*\s--home\s+(?:[']?/(?!home/)|?\$[\(\[\{]?)).*)

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-30 Thread Axel Beckert
Hi, Jakub Wilk wrote: * Axel Beckert a...@debian.org, 2015-08-30, 21:08: The regexp is now surely uglier and less readable than before. So I wonder what we could do to improve the situation inside data/scripts/maintainer-script-bad-command I'd suggest removing the tag from the data file,

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-30 Thread Jakub Wilk
Hi Axel! * Axel Beckert a...@debian.org, 2015-08-30, 21:08: The regexp is now surely uglier and less readable than before. So I wonder what we could do to improve the situation inside data/scripts/maintainer-script-bad-command I'd suggest removing the tag from the data file, and

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-30 Thread Jörg Frings-Fürst
Package: lintian Version: 2.5.36.1 Severity: important -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, I use at a maintainer script this line: 'adduser --home /var/lib/saned --quiet --system --no-create-home --group saned || true' Then lintian says: N:The maintainer script

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-30 Thread Axel Beckert
Hi, Jakub Wilk wrote: I use at a maintainer script this line: 'adduser --home /var/lib/saned --quiet --system --no-create-home --group saned || true' Lintian uses this regexp (see data/scripts/maintainer-script-bad-command):

Bug#797395: [maintainer-script-should-not-use-adduser-system-without-home] false positivies

2015-08-30 Thread Jakub Wilk
Control: tags 1 + confirmed Hi Jörg! * Jörg Frings-Fürst deb...@jff-webhosting.net, 2015-08-30, 13:38: I use at a maintainer script this line: 'adduser --home /var/lib/saned --quiet --system --no-create-home --group saned || true' Lintian uses this regexp (see