Re: Some more patches

2008-06-28 Thread Russ Allbery
Raphael Geissert <[EMAIL PROTECTED]> writes: > Ok, I see your point. What about lowering its severity to just Info? Well, like I said, I'm not sure that it's worth the noise, given that findstring does work now. The most likely case when it might stop working is if some new flag were introduced

Re: Some more patches

2008-06-28 Thread Raphael Geissert
Russ Allbery wrote: > Raphael Geissert <...> writes: >> Russ Allbery wrote: > >> But now policy states: >> >>> If multiple flags are given, they must be separated by whitespace >> >>> The only time it would break is if someone used some other build option >>> that contained the string searched f

Re: Some more patches

2008-06-28 Thread Russ Allbery
Raphael Geissert <[EMAIL PROTECTED]> writes: > Russ Allbery wrote: > But now policy states: > >> If multiple flags are given, they must be separated by whitespace > >> The only time it would break is if someone used some other build option >> that contained the string searched for, which seems ex

Re: Some more patches

2008-06-28 Thread Raphael Geissert
[CC'ing ftp-masters] Russ Allbery wrote: > Russ Allbery <...> writes: > >> The PHP 2.x tag saying that it's non-free bothers me without a reference >> from ftp-master that it's non-free, and I don't see anything about PHP >> 2.x >> specifically in the REJECT FAQ. I'm personally not very comfort

Re: Some more patches

2008-06-28 Thread Raphael Geissert
Russ Allbery wrote: > >> lintian_findstrin_DEB_BUILD_OPTIONS.patch: >> Adds two checks, one for the usage of 'findstring' on DEB_BUILD_OPTIONS >> instead of 'find', and another one for the usage of DEB_BUILD_OPTS. > > The DEB_BUILD_OPTS part is okay. > > I don't like the findstring check. Using

Re: Some more patches

2008-06-28 Thread Russ Allbery
Russ Allbery <[EMAIL PROTECTED]> writes: > The PHP 2.x tag saying that it's non-free bothers me without a reference > from ftp-master that it's non-free, and I don't see anything about PHP 2.x > specifically in the REJECT FAQ. I'm personally not very comfortable with > Lintian making any judgemen

Re: Some more patches

2008-06-28 Thread Russ Allbery
Raphael Geissert <[EMAIL PROTECTED]> writes: > lintian_bad_php-licenses.patch: > I couldn't find a clear reference where it is stated that the PHP licences > v2.x are non-free, but using any of those licences is a pseudo-automatic > REJECT when uploading to new. The check for version 3.0 just comp

Some more patches

2008-06-28 Thread Raphael Geissert
Hi all, Attached there are a couple more patches. lintian_bad_php-licenses.patch: I couldn't find a clear reference where it is stated that the PHP licences v2.x are non-free, but using any of those licences is a pseudo-automatic REJECT when uploading to new. The check for version 3.0 just comple