Re: more patches

On Sat, Aug 30, 2008 at 06:32:29PM -0500, Raphael Geissert wrote: > Frank Lichtenheld wrote: > > On Sat, Aug 30, 2008 at 05:23:34PM -0500, Raphael Geissert wrote: > >> Frank Lichtenheld wrote: > >> > On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: > >> >> lintian_embedded-php-libr

Re: more patches

On Sun, 2008-08-31 at 01:04 +0200, Frank Lichtenheld wrote: > I've no idea against which tree you make these patches but it certainly > is not master. > > >From your patch (checks/files.desc): > " Please depend on the respective PEAR package providing the module and > make sure the library can

Re: more patches

Frank Lichtenheld wrote: > On Sat, Aug 30, 2008 at 05:23:34PM -0500, Raphael Geissert wrote: >> Frank Lichtenheld wrote: >> > On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: >> >> lintian_embedded-php-library: >> >> yet another PHP-related check for embedded copies, none making p

Re: more patches

On Sat, Aug 30, 2008 at 05:23:34PM -0500, Raphael Geissert wrote: > Frank Lichtenheld wrote: > > On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: > >> lintian_embedded-php-library: > >> yet another PHP-related check for embedded copies, none making part of > >> PEAR, based on the e

Re: more patches

W: djpig should-not-send-copy-of-message to atomo64 Frank Lichtenheld wrote: > On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: >> lintian_embedded-php-library: >> yet another PHP-related check for embedded copies, none making part of >> PEAR, based on the embedded-code-copies li

Re: more patches

On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: > lintian_xinha: > adds a, currently commented, entry for xinha, which is already packaged but > not yet in the archive; so it can be kept as a reminder to enable it as > soon as the package reaches the archive. applied -- Frank Li

Re: more patches

On Sat, Aug 30, 2008 at 03:52:51PM -0500, Raphael Geissert wrote: > lintian_embedded-php-library: > yet another PHP-related check for embedded copies, none making part of PEAR, > based on the embedded-code-copies list. Note that there's also another > disabled line which is for a package that is al

more patches

Hi all, lintian_xinha: adds a, currently commented, entry for xinha, which is already packaged but not yet in the archive; so it can be kept as a reminder to enable it as soon as the package reaches the archive. lintian_embedded-php-library: yet another PHP-related check for embedded copies, none

Re: More patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > I suggested m,/pear[/.], as it would also match > $Header: /repository/pear/Log/Log.php,v 1.69 2008/01/19 22:20:55 jon Exp $ > > which is what php-log's Log.php use. Done. -- Russ Allbery ([EMAIL PROTECTED])

Re: More patches

Russ Allbery wrote: > Raphael Geissert <[EMAIL PROTECTED]> > writes: > >> well, some files do have a string that would be matched, but probably >> m,/pear[/.], is a better regex. That's the main drawnback: there's no >> easy way to tell whether it is a PEAR module or not. "PHP, the world of >> in

Re: More patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > well, some files do have a string that would be matched, but probably > m,/pear[/.], is a better regex. That's the main drawnback: there's no > easy way to tell whether it is a PEAR module or not. "PHP, the world of > inconsistencies" :) I'm currentl

Re: More patches

Russ Allbery wrote: > Raphael Geissert <[EMAIL PROTECTED]> > writes: > >> That part was done in pourpose (not even /Filename is required on all >> cases) because some times some people do rename the files and add a >> comment or two but the code remains intact. Not even as an experimental >> tag

Re: More patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > That part was done in pourpose (not even /Filename is required on all > cases) because some times some people do rename the files and add a > comment or two but the code remains intact. Not even as an experimental > tag using m,/pear/,? Er, this stri

Re: More patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > That part was done in pourpose (not even /Filename is required on all > cases) because some times some people do rename the files and add a > comment or two but the code remains intact. Not even as an experimental > tag using m,/pear/,? Oh, hey, good

Re: More patches

Russ Allbery wrote: > Raphael Geissert <[EMAIL PROTECTED]> > writes: > >> and adds another tag checking for embedded copies of PHP PEAR modules >> (there are lots of those in the wild). > > I think I'm going to decline to apply this one in its current form, or > with m/pear/, since the false pos

Re: More patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > Attached is a git-am-friendly mbox file containing the patches making > lintian check for embedded copies of jsjac and jsMath, This part is applied. Thanks! > and adds another tag checking for embedded copies of PHP PEAR modules > (there are lots o

Re: More patches

Russ Allbery wrote: > Raphael Geissert <[EMAIL PROTECTED]> > writes: > >> Attached is a git-am-friendly mbox file containing the patches making >> lintian check for embedded copies of jsjac and jsMath, and adds another >> tag checking for embedded copies of PHP PEAR modules (there are lots of >>

Re: More patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > Attached is a git-am-friendly mbox file containing the patches making > lintian check for embedded copies of jsjac and jsMath, and adds another > tag checking for embedded copies of PHP PEAR modules (there are lots of > those in the wild). > + #

More patches

, there are some more patches here: <[EMAIL PROTECTED]>). Thanks. Cheers, -- Atomo64 - Raphael Please avoid sending me Word, PowerPoint or Excel attachments. See http://www.gnu.org/philosophy/no-word-attachments.html lintian-patches.mbox Description: application/mbox

Re: more patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > Russ Allbery wrote: >> Raphael Geissert <[EMAIL PROTECTED]> writes: >>> Adds a check for maintainer scripts modifying the php.ini file (only >>> checks the preinst script as it is "safe" if done on the postrm to >>> rollback the changes). I believe th

Re: more patches

Russ Allbery wrote: > Raphael Geissert <[EMAIL PROTECTED]> > writes: > >> lintian_improvedpatch: >> >> I made a couple of changes so it matches "bla bla bla" at the same time, >> and to make it catch all of the duplicated lines on the same line. > > Applied with a few fixes: Thanks! :) >

Re: more patches

Russ Allbery wrote: > Raphael Geissert <[EMAIL PROTECTED]> > writes: > >> lintian_maintpatch: >> >> Adds a check for maintainer scripts modifying the php.ini file (only >> checks the preinst script as it is "safe" if done on the postrm to >> rollback the changes). I believe the description of

Re: more patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > lintian_improvedpatch: > > I made a couple of changes so it matches "bla bla bla" at the same time, > and to make it catch all of the duplicated lines on the same line. Applied with a few fixes: > --- a/checks/description > +++ b/checks/descript

Re: more patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > lintian_maintpatch: > > Adds a check for maintainer scripts modifying the php.ini file (only > checks the preinst script as it is "safe" if done on the postrm to > rollback the changes). I believe the description of the new tag is clear > enough.

more patches

Hi again, lintian_improvedpatch: I made a couple of changes so it matches "bla bla bla" at the same time, and to make it catch all of the duplicated lines on the same line. lintian_maintpatch: Adds a check for maintainer scripts modifying the php.ini file (only checks the preinst script

Re: Some more patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > Ok, I see your point. What about lowering its severity to just Info? Well, like I said, I'm not sure that it's worth the noise, given that findstring does work now. The most likely case when it might stop working is if some new flag were introduced

Re: Some more patches

Russ Allbery wrote: > Raphael Geissert <...> writes: >> Russ Allbery wrote: > >> But now policy states: >> >>> If multiple flags are given, they must be separated by whitespace >> >>> The only time it would break is if someone used some other build option >>> that contained the string searched f

Re: Some more patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > Russ Allbery wrote: > But now policy states: > >> If multiple flags are given, they must be separated by whitespace > >> The only time it would break is if someone used some other build option >> that contained the string searched for, which seems ex

Re: Some more patches

[CC'ing ftp-masters] Russ Allbery wrote: > Russ Allbery <...> writes: > >> The PHP 2.x tag saying that it's non-free bothers me without a reference >> from ftp-master that it's non-free, and I don't see anything about PHP >> 2.x >> specifically in the REJECT FAQ. I'm personally not very comfort

Re: Some more patches

Russ Allbery wrote: > >> lintian_findstrin_DEB_BUILD_OPTIONS.patch: >> Adds two checks, one for the usage of 'findstring' on DEB_BUILD_OPTIONS >> instead of 'find', and another one for the usage of DEB_BUILD_OPTS. > > The DEB_BUILD_OPTS part is okay. > > I don't like the findstring check. Using

Re: Some more patches

Russ Allbery <[EMAIL PROTECTED]> writes: > The PHP 2.x tag saying that it's non-free bothers me without a reference > from ftp-master that it's non-free, and I don't see anything about PHP 2.x > specifically in the REJECT FAQ. I'm personally not very comfortable with > Lintian making any judgemen

Re: Some more patches

Raphael Geissert <[EMAIL PROTECTED]> writes: > lintian_bad_php-licenses.patch: > I couldn't find a clear reference where it is stated that the PHP licences > v2.x are non-free, but using any of those licences is a pseudo-automatic > REJECT when uploading to new. The check for version 3.0 just comp

Some more patches

Hi all, Attached there are a couple more patches. lintian_bad_php-licenses.patch: I couldn't find a clear reference where it is stated that the PHP licences v2.x are non-free, but using any of those licences is a pseudo-automatic REJECT when uploading to new. The check for version 3.0