Re: Backwards-incompatible ABI change due to function rename

2019-03-04 Thread Andrey Rahmatullin
On Mon, Mar 04, 2019 at 05:03:30PM +0200, Andrius Merkys wrote: > On 2019-03-04 16:56, Adam Borowski wrote: > > But, are they actually available from the published API? > > Yes, they are; readelf --symbols prints them. readelf doesn't know about the API. The published API is in the docs and in

Re: Backwards-incompatible ABI change due to function rename

2019-03-04 Thread Andrey Rahmatullin
On Mon, Mar 04, 2019 at 01:37:51PM +0200, Andrius Merkys wrote: > The upstream says that the renamed functions are not documented, > therefore they are private-ish. However, strictly speaking these > functions are public, as they are accessible in the ABI. Please tell the upstream to not export

Re: Backwards-incompatible ABI change due to function rename

2019-03-04 Thread Andrius Merkys
On 2019-03-04 16:56, Adam Borowski wrote: > But, are they actually available from the published API? Yes, they are; readelf --symbols prints them. > And do reverse dependencies use those functions? Not that I am aware of. The renamed functions were introduced for the development only. Thanks,

Re: Backwards-incompatible ABI change due to function rename

2019-03-04 Thread Adam Borowski
On Mon, Mar 04, 2019 at 01:37:51PM +0200, Andrius Merkys wrote: > On 2019-03-04 13:32, Andrey Rahmatullin wrote: > > What does the upstream say about this? > > The upstream says that the renamed functions are not documented, > therefore they are private-ish. However, strictly speaking these >

Re: Backwards-incompatible ABI change due to function rename

2019-03-04 Thread Andrius Merkys
On 2019-03-04 13:32, Andrey Rahmatullin wrote: > What does the upstream say about this? The upstream says that the renamed functions are not documented, therefore they are private-ish. However, strictly speaking these functions are public, as they are accessible in the ABI. > The ideal way would

Re: Backwards-incompatible ABI change due to function rename

2019-03-04 Thread Andrey Rahmatullin
On Mon, Mar 04, 2019 at 01:29:44PM +0200, Andrius Merkys wrote: > I am maintaining a package which has recently endured a > backwards-incompatible ABI change due to a couple of function renames. I > could restore the ABI compatibility by providing aliases (via patches) > for the renamed functions.

Backwards-incompatible ABI change due to function rename

2019-03-04 Thread Andrius Merkys
Dear Mentors, I am maintaining a package which has recently endured a backwards-incompatible ABI change due to a couple of function renames. I could restore the ABI compatibility by providing aliases (via patches) for the renamed functions. My question is: would this be a viable solution, or