Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-09 Thread Eriberto
Thanks Roger! 2014-08-08 20:04 GMT-03:00 Roger Light : > Hi Eriberto, > 3. Is normal this issue? > >> I got this message in a clean jail and in cowbuilder/pbuilder. Please, >> try in cowbuilder: > > Ok, I did get these in normal building (tried it in cowbuilder as > well). I've checked and t

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-08 Thread Roger Light
Hi Eriberto, >>> 3. Is normal this issue? > I got this message in a clean jail and in cowbuilder/pbuilder. Please, > try in cowbuilder: Ok, I did get these in normal building (tried it in cowbuilder as well). I've checked and they're not important. There won't be any trace dumps in the next rele

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-08 Thread Eriberto
2014-08-08 11:29 GMT-03:00 Roger Light : Hi Roger! Thanks for your reply. >> 2. I found: >> >> # This product includes software developed by the OpenSSL Project for use in >> # the OpenSSL Toolkit. (http://www.openssl.org/) >> # This product includes cryptographic software written by Eric Young >

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-08 Thread Roger Light
Hi Eriberto, > 1. Update d/copyright. The current copyright for Troy is 2003-2013. Oh yes, I missed that. > 2. I found: > > # This product includes software developed by the OpenSSL Project for use in > # the OpenSSL Toolkit. (http://www.openssl.org/) > # This product includes cryptographic soft

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-06 Thread Eriberto
2014-08-05 20:58 GMT-03:00 Roger Light : Hi Roger, > > When the mosquitto broker runs as root, it will always attempt to drop > privileges to the mosquitto user by default, or another user if so > configured. If it is not running as root, this does not happen. I > don't believe that building pack

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-05 Thread Roger Light
Hi Eriberto, > 1. You need to put all changes in d/changelog. You can use your VCS to check > it. Ok, I have done this. > 2. In d/changelog, you should use urgency=medium, not high. Fixed. > 3. The cowbuilder builds the package. However, when building the > package in a new Sid environment (n

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-02 Thread Eriberto
2014-08-01 19:18 GMT-03:00 Roger Light : > Thanks for taking the time to start a review. Hi Roger! You're welcome. >> 4. All readmes should be put in /usr/share/doc/mosquitto. Do you have >> a reason to put them in /etc? > > These READMEs are simple explanations of empty directories, it doesn'

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-01 Thread Roger Light
Hi Eriberto, Thanks for taking the time to start a review. > 1. Update the Standards-Version from 3.9.4 to 3.9.5. Done > 2. d/copyright: please, update the years (include 2014, because I > found it in your upstream code). Done. > 3. d/docs: The final user doesn't compiles codes. So, send comp

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-01 Thread Eriberto Mota
Thanks Cameron! Upstart isn't familiar to me yet. Regards, Eriberto 2014-08-01 14:39 GMT-03:00 Cameron Norman : > El vie, 1 de ago 2014 a las 10:32 , Eriberto Mota > escribió: > > 6. There is a .conf in /etc/init. What is this? > > > That would be an Upstart job. > > Best, > -- > Cameron Norma

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-01 Thread Cameron Norman
El vie, 1 de ago 2014 a las 10:32 , Eriberto Mota escribió: 6. There is a .conf in /etc/init. What is this? That would be an Upstart job. Best, -- Cameron Norman

Bug#754793: RFS: mosquitto/1.2.1-2 RC

2014-08-01 Thread Eriberto Mota
tags 754793 moreinfo thanks Hi Roger, how are you? I will try help you. Please: 1. Update the Standards-Version from 3.9.4 to 3.9.5. 2. d/copyright: please, update the years (include 2014, because I found it in your upstream code). 3. d/docs: The final user doesn't compiles codes. So, send c