Hi Andrey,

> Please run tests at the build time.

I've looked into the tests now, and I'm not sure if it so easy to get
it to run during build of the Debian package. It requires an active
SSH server with a known username and password. It is not exactly unit
testing.. (See:
https://github.com/mwilliamson/spur.py/blob/master/CONTRIBUTING.rst)
:)  But I will remember to check if there are any tests the next time
I make a package.

> ALso, "$(RM) -r .pybuild" in override_dh_auto_clean looks strange.

Regarding RM -r .pybuild:  I don't like when the work folder isn't
restored completely when running "dh clean". Therefore I added this
rule. Perhaps there's a reason for keeping it there after "dh clean"?
Or is it supposed to disappear without any explicit rule?

Have a nice weekend!

Best regards,
Ruben


-- 
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Archive: 
https://lists.debian.org/ca+chnyxtazv4wc6bydbpk+mdyvlsxfnwk2hutoycxvbfwu-...@mail.gmail.com

Reply via email to