Re: Please review internal package using a lot of "new" tools

2010-05-24 Thread Marc Haber
On Mon, May 24, 2010 at 11:21:17PM +0900, Osamu Aoki wrote: > On Mon, May 24, 2010 at 10:53:54AM +0200, Marc Haber wrote: > > Hi, > > > > On Mon, May 24, 2010 at 09:27:29AM +0800, Paul Wise wrote: > > > On Mon, May 24, 2010 at 2:21 AM, Marc Haber > > > wrote: > > > > On Sun, May 23, 2010 at 11:12

Re: Please review internal package using a lot of "new" tools

2010-05-24 Thread Osamu Aoki
Hi, On Mon, May 24, 2010 at 10:53:54AM +0200, Marc Haber wrote: > Hi, > > On Mon, May 24, 2010 at 09:27:29AM +0800, Paul Wise wrote: > > On Mon, May 24, 2010 at 2:21 AM, Marc Haber > > wrote: > > > On Sun, May 23, 2010 at 11:12:40AM +0800, Paul Wise wrote: > I have uploaded a new package to > h

Re: Please review internal package using a lot of "new" tools

2010-05-24 Thread Marc Haber
Hi, On Mon, May 24, 2010 at 09:27:29AM +0800, Paul Wise wrote: > On Mon, May 24, 2010 at 2:21 AM, Marc Haber > wrote: > > On Sun, May 23, 2010 at 11:12:40AM +0800, Paul Wise wrote: > >> In dh_auto_install, does upstream's Makefile not support DESTDIR? > > > > Sadly, incorrectly. > > make install

Re: Please review internal package using a lot of "new" tools

2010-05-23 Thread Paul Wise
On Mon, May 24, 2010 at 2:21 AM, Marc Haber wrote: > On Sun, May 23, 2010 at 11:12:40AM +0800, Paul Wise wrote: >> In dh_auto_install, does upstream's Makefile not support DESTDIR? > > Sadly, incorrectly. > make install DESTDIR=$(CURDIR)/debian/${PACKAGENAME} > places the executeable in > debian/n

Re: Please review internal package using a lot of "new" tools

2010-05-23 Thread Marc Haber
Hi, I really appreciate your comments. On Sun, May 23, 2010 at 11:12:40AM +0800, Paul Wise wrote: > On Sun, May 23, 2010 at 6:14 AM, Marc Haber > wrote: > > > I would appreciate if you could comment. > > dh --with-quilt isn't needed if you're using dpkg-source v3 ok, removed. > If you call d

Re: Please review internal package using a lot of "new" tools

2010-05-22 Thread Paul Wise
On Sun, May 23, 2010 at 6:14 AM, Marc Haber wrote: > I would appreciate if you could comment. dh --with-quilt isn't needed if you're using dpkg-source v3 If you call dh_auto_configure -- ... instead of ./configure ... it will add --prefix for you. The test parts of override_dh_auto_build shoul

Please review internal package using a lot of "new" tools

2010-05-22 Thread Marc Haber
Hi, for an internal package of the Nagios plugin check_multi, I decided to familiarize myself with some new tools (debhelper 7, 3.0 format, quilt, git etc). The package itself is not going to be in Debian since the Nagios team has decided to place check_multi into the existing nagios-p