Bug#613046: debian-policy: please update example in 4.9.1 (debian/rules and DEB_BUILD_OPTIONS)

2012-01-30 Thread Russ Allbery
Raphael Hertzog writes: > No because $(shell ...) only gets environment variable that were > existing at the time make has been invoked. Variables exported by the > makefile itself are not forwarded. :-( Ah, indeed. I didn't realize that. Using `` instead of $(shell) would of course work, but

Bug#613046: debian-policy: please update example in 4.9.1 (debian/rules and DEB_BUILD_OPTIONS)

2012-01-30 Thread Raphael Hertzog
On Mon, 30 Jan 2012, Russ Allbery wrote: > > And you must take care because $(shell dpkg-buildflags ...) will not see > > the DEB_CFLAGS_MAINT_PREPEND that you have set in the rules > > files. Either you do $(shell > > DEB_CFLAGS_MAINT_PREPEND=... dpkg-buildflags ...) or you use > > /usr/share/dpkg

Bug#658009: debian-policy: dpkg-buildpackage -rroot-command out of date

2012-01-30 Thread Jonathan Nieder
Sam Morris wrote: > C.1.2 says: > > If no root-command is supplied then dpkg-buildpackage will take > no special action to gain root privilege, so that for most > packages it will have to be invoked as root to start with. > > This is wrong according to the dpkg-buildpackage man p

Bug#613046: debian-policy: please update example in 4.9.1 (debian/rules and DEB_BUILD_OPTIONS)

2012-01-30 Thread Russ Allbery
Raphael Hertzog writes: > Well, they are there so that you can tweak the output of dpkg-buildflags > when the call happens in lower layer and that you have no control over > the call and its output. > And you must take care because $(shell dpkg-buildflags ...) will not see > the DEB_CFLAGS_MAINT

Bug#658009: debian-policy: dpkg-buildpackage -rroot-command out of date

2012-01-30 Thread Sam Morris
Package: debian-policy Severity: minor C.1.2 says: If no root-command is supplied then dpkg-buildpackage will take no special action to gain root privilege, so that for most packages it will have to be invoked as root to start with. This is wrong according to the dpkg-bui

Bug#613046: debian-policy: please update example in 4.9.1 (debian/rules and DEB_BUILD_OPTIONS)

2012-01-30 Thread Matthijs Kooijman
Hi folks, just stumbled upon this report, and I have a small suggestion to improve Jonathan's patch: > --- a/policy.sgml > +++ b/policy.sgml > @@ -2256,18 +2256,13 @@ > massage this example in order to make it work for your > package. > > -CFLAGS = -Wall -g > INSTA

Bug#613046: debian-policy: please update example in 4.9.1 (debian/rules and DEB_BUILD_OPTIONS)

2012-01-30 Thread Raphael Hertzog
On Fri, 27 Jan 2012, Matthijs Kooijman wrote: > > -ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS))) > > -CFLAGS += -O0 > > -else > > -CFLAGS += -O2 > > -endif > > +CFLAGS := -Wall $(shell dpkg-buildflags --get CFLAGS) > > ifeq (,$(filter nostrip,$(DEB_BUILD_OPTIONS))) > > INSTALL_PROGRAM