Re: Request to review and upload unhide 20210124-4

2022-09-03 Thread Daichi Fukui
Hello Samuel, > It looks like you're not importing the new releases with "gbp > import-orig", as the commit adding the new sources to debian/master is > not a merge commit and the description looks different, I suggest > always importing new upstream releases with "gbp import-orig --uscan >

Re: Request to review and upload unhide 20210124-4

2022-09-02 Thread Samuel Henrique
Hello Fukui, > # But if you don't mind, please call me Fukui as you did in the latest email > ;) Surely, thanks for letting me know. > I have updated the draft source package of unhide. > Kindly find the source code for this version below. >

Re: Request to review and upload unhide 20210124-4

2022-09-01 Thread Daichi Fukui
Hello Samuel I have updated the draft source package of unhide. Kindly find the source code for this version below. https://salsa.debian.org/dfukui/unhide/-/tree/debian/master The main changes from the previous draft are: * New upstream version 20220611 * Drop Replaces+Breaks For more details

Re: Request to review and upload unhide 20210124-4

2022-08-30 Thread Daichi Fukui
Hello Samuel, # I have no preference in which I am called Daichi or Fukui. # But if you don't mind, please call me Fukui as you did in the latest email ;) Thanks for reviewing my source package draft. Okay, now I understand what Replaces+Breaks should be like in this case. In fact, I initially

Re: Request to review and upload unhide 20210124-4

2022-08-28 Thread Samuel Henrique
Hello Fukui (sorry I'm not sure if you prefer to be called Daichi or Fukui, I'm going by your email signature, but please let me know otherwise), All of the changes looks good, but I have a comment about the Break+Replaces change: I see that you followed the suggestion from the bug report [0] to