Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread David Miller
From: John Paul Adrian Glaubitz Date: Thu, 14 Apr 2016 01:22:37 +0200 > From 8d95bce6a35dc037d1e419896af19e12b3cda910 Mon Sep 17 00:00:00 2001 > From: John Paul Adrian Glaubitz > Date: Thu, 14 Apr 2016 01:16:14 +0200 > Subject: [PATCH 1/2] sparc/kernel/vio.c: implement modalias_show() > > Signe

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread David Miller
From: John Paul Adrian Glaubitz Date: Thu, 14 Apr 2016 01:22:37 +0200 > From 3515ad550f7b1db467664acc9bf0ed3d2aec9fdd Mon Sep 17 00:00:00 2001 > From: John Paul Adrian Glaubitz > Date: Thu, 14 Apr 2016 01:19:40 +0200 > Subject: [PATCH 2/2] sparc/kernel/vio.c: implement vio_hotplug and add it to

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread David Miller
From: John Paul Adrian Glaubitz Date: Thu, 14 Apr 2016 01:04:17 +0200 > On 04/14/2016 01:01 AM, David Miller wrote: >> Ok those are the block devices, where are the networking interfaces? > > Whoops, sorry: > > root@deb4g:/sys/devices/channel-devices# cat vdc*/mod* > vio:Tvdc-portSunknown > vio

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread Patrick Baggett
You guys are my heroes. Keep up the great work! On Wednesday, April 13, 2016, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > On 04/14/2016 01:01 AM, David Miller wrote: > > Ok those are the block devices, where are the networking interfaces? > > Whoops, sorry: > > root@deb4g:/

Re: Bug#815977: closed by Ben Hutchings (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread John Paul Adrian Glaubitz
Control: tags -1 patch Hi Ben! On 04/13/2016 05:40 PM, Ben Hutchings wrote: > Try deleting the 'if (!cp)' block. That wasn't enough. I invested some more time and now have a patch that does the trick. Module aliases are created correctly and module autoloading is working as expected. This has be

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread John Paul Adrian Glaubitz
On 04/14/2016 01:04 AM, John Paul Adrian Glaubitz wrote: > Testing a much simpler version now. Second. Attaching two patches which add modalias_show and vio_hotplug. With the patches applied, module autoloading works as expected. Going to bed now, it's past midnight here. Adrian -- .''`. Joh

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread David Miller
From: John Paul Adrian Glaubitz Date: Thu, 14 Apr 2016 00:44:19 +0200 > Yeah, I modified Ben's patch and it works: > > root@deb4g:/sys/devices/channel-devices# cat vdc*/mod* > vio:Tvdc-portSunknown > vio:Tvdc-portSunknown > vio:Tvdc-portSunknown > vio:Tvdc-portSunknown > vio:Tvdc-portSunknown O

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread John Paul Adrian Glaubitz
On 04/14/2016 01:01 AM, David Miller wrote: > Ok those are the block devices, where are the networking interfaces? Whoops, sorry: root@deb4g:/sys/devices/channel-devices# cat vdc*/mod* vio:Tvdc-portSunknown vio:Tvdc-portSunknown vio:Tvdc-portSunknown vio:Tvdc-portSunknown vio:Tvdc-portSunknown ro

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread David Miller
From: John Paul Adrian Glaubitz Date: Thu, 14 Apr 2016 00:35:58 +0200 > On 04/14/2016 12:23 AM, David Miller wrote: >> The missing bit is probably having the individual sparc64 VIO drivers >> define proper module aliases. > > I'm actually currently working on a patch. The aliases are already > w

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread David Miller
From: David Miller Date: Wed, 13 Apr 2016 18:23:49 -0400 (EDT) > From: John Paul Adrian Glaubitz > Date: Wed, 13 Apr 2016 17:33:25 +0200 > >> On 04/11/2016 09:04 PM, David Miller wrote: >>> Either way, I'll look at this patch, thanks. >> >> Just as a heads-up: >> >> The suggested patch does n

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread John Paul Adrian Glaubitz
On 04/14/2016 12:37 AM, David Miller wrote: > Are you sure? See my other email, VIO devices don't come from the > Openfirmware device tree at all. Yeah, I modified Ben's patch and it works: root@deb4g:/sys/devices/channel-devices# cat vdc*/mod* vio:Tvdc-portSunknown vio:Tvdc-portSunknown vio:Tvd

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread David Miller
From: John Paul Adrian Glaubitz Date: Wed, 13 Apr 2016 17:33:25 +0200 > On 04/11/2016 09:04 PM, David Miller wrote: >> Either way, I'll look at this patch, thanks. > > Just as a heads-up: > > The suggested patch does not work unfortunately. Modules are not > loaded automatically and it seems mo

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread John Paul Adrian Glaubitz
On 04/14/2016 12:23 AM, David Miller wrote: > The missing bit is probably having the individual sparc64 VIO drivers > define proper module aliases. I'm actually currently working on a patch. The aliases are already working, now it's just the actual hotplug handler which is missing. Adrian -- .

Re: Bug#815977: closed by Ben Hutchings (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread Ben Hutchings
Control: reopen -1 Control: retitle -1 vio devices on SPARC do not have modaliases On Wed, 2016-04-13 at 17:27 +0200, John Paul Adrian Glaubitz wrote: > On 04/13/2016 02:03 PM, John Paul Adrian Glaubitz wrote: > > > > On 04/11/2016 01:32 AM, Ben Hutchings wrote: > > > > > > The attached patch mi

Re: Enable module aliases for vio on sparc/sparc64

2016-04-13 Thread John Paul Adrian Glaubitz
On 04/11/2016 09:04 PM, David Miller wrote: > Either way, I'll look at this patch, thanks. Just as a heads-up: The suggested patch does not work unfortunately. Modules are not loaded automatically and it seems modaliases are not generated properly. It seems that the vio implementation for sparc

Re: Bug#815977 closed by Ben Hutchings (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread John Paul Adrian Glaubitz
On 04/13/2016 02:03 PM, John Paul Adrian Glaubitz wrote: > On 04/11/2016 01:32 AM, Ben Hutchings wrote: >> The attached patch might fix that, though the correct fix would >> presumably be to merge the two implementations. > > Thanks a lot for the explanation and the patch. I will test the > patch

Re: Bug#815977 closed by Ben Hutchings (Re: Bug#815977: kernel-image-4.4.0-1-sparc64-di: Please add sunvnet and sunvdc for d-i)

2016-04-13 Thread John Paul Adrian Glaubitz
On 04/11/2016 01:32 AM, Ben Hutchings wrote: > The attached patch might fix that, though the correct fix would > presumably be to merge the two implementations. Thanks a lot for the explanation and the patch. I will test the patch and then we can maybe decide if we include it as a work around. I