Bug#1007025: git-multimail 1.6.0 package review

2022-09-22 Thread Antoine Beaupré
On 2022-09-22 17:03:24, Bo YU wrote: > Hi, > On Tue, Sep 20, 2022 at 10:56:05AM -0400, Antoine Beaupré wrote: >>> https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1245009306 >>> (To avoid bring noisy for upstream, i just recorded it in a issue) >> >>I don't think pull requests

Bug#1007025: git-multimail 1.6.0 package review

2022-09-22 Thread Bo YU
Hi, On Tue, Sep 20, 2022 at 10:56:05AM -0400, Antoine Beaupré wrote: https://github.com/git-multimail/git-multimail/issues/221#issuecomment-1245009306 (To avoid bring noisy for upstream, i just recorded it in a issue) I don't think pull requests are noisy... you should probably just submit this

Bug#1007025: git-multimail 1.6.0 package review

2022-09-20 Thread Antoine Beaupré
On 2022-09-18 11:10:24, Bo YU wrote: > Hi, > On Thu, Sep 15, 2022 at 05:32:33PM +0100, Antoine Beaupré wrote: >>Hi! >> >>I've done a quick review of the 1.6.0 package on salsa as of commit >>d5bd184a1cf73b752f80dea46d8080493a5e663b. [...] >>Also, I didn't quite follow the work on the test cases,

Bug#1007025: git-multimail 1.6.0 package review

2022-09-17 Thread Bo YU
Hi, On Thu, Sep 15, 2022 at 05:32:33PM +0100, Antoine Beaupré wrote: Hi! I've done a quick review of the 1.6.0 package on salsa as of commit d5bd184a1cf73b752f80dea46d8080493a5e663b. It looks like there's some leftover stuff in debian/copyright, i would remove this: modified debian/copyright

Bug#1007025: git-multimail 1.6.0 package review

2022-09-15 Thread Antoine Beaupré
On 2022-09-15 17:32:33, Antoine Beaupré wrote: > Hi! > > I've done a quick review of the 1.6.0 package on salsa as of commit > d5bd184a1cf73b752f80dea46d8080493a5e663b. [...] > Also, I didn't quite follow the work on the test cases, but why did you > replace pep8 by pycodestyle in the patch in de

Bug#1007025: git-multimail 1.6.0 package review

2022-09-15 Thread Antoine Beaupré
Hi! I've done a quick review of the 1.6.0 package on salsa as of commit d5bd184a1cf73b752f80dea46d8080493a5e663b. It looks like there's some leftover stuff in debian/copyright, i would remove this: modified debian/copyright @@ -2,8 +2,6 @@ Format: https://www.debian.org/doc/packaging-manuals/