Hello Dimitry,
Could you review golang-github-mattn-go-sqlite3?
It is available on Alioth:
- git.debian.org:/git/pkg-go/packages/golang-github-mattn-go-sqlite3
If you upload the package, please tag the repository <3
Thanks :)
--
Alexandre Viau
alexan...@alexandreviau.net
signature.asc
Des
On Wednesday 02 September 2015 22:22:04 Alexandre Viau wrote:
> Could you review golang-github-mattn-go-sqlite3?
I'm still looking at it and I've noticed that you are using weird GitHub
"watch" files in your packages... Why not use something like this:
http://anonscm.debian.org/cgit/pkg-go/
Hello,
On 02/09/15 10:35 PM, Dmitry Smirnov wrote:
> I'm still looking at it and I've noticed that you are using weird GitHub
> "watch" files in your packages... Why not use something like this:
>
>
> http://anonscm.debian.org/cgit/pkg-go/packages/golang-gogoprotobuf.git/commit/?id=f70e004c
On Wednesday 02 September 2015 22:42:27 Alexandre Viau wrote:
> On 02/09/15 10:35 PM, Dmitry Smirnov wrote:
> > Why not use something like this:
> > http://anonscm.debian.org/cgit/pkg-go/packages/golang-gogoprotobuf.gi
> > t/commit/?id=f70e004c
> Are you talking about the filenamemangle? I
Control: tag -1 moreinfo
On Wednesday 02 September 2015 22:22:04 Alexandre Viau wrote:
> Could you review golang-github-mattn-go-sqlite3?
"debian/copyright" is incomplete. Please document
_example/mod_vtable/picojson.h
and
code/*
sqlite3-binding.c, sqlite3-binding.h, sqlite3ext.h
T
On 02/09/15 10:57 PM, Dmitry Smirnov wrote:
> On Wednesday 02 September 2015 22:42:27 Alexandre Viau wrote:
>> On 02/09/15 10:35 PM, Dmitry Smirnov wrote:
>>> Why not use something like this:
>>> http://anonscm.debian.org/cgit/pkg-go/packages/golang-gogoprotobuf.gi
>>> t/commit/?id=f70e004
On Wednesday 02 September 2015 23:13:19 Alexandre Viau wrote:
> Looks like /tags contains more than /releases. I'm not sure if one is
> better than the other. This is somewhat documented here:
> -
> https://developer.github.com/v3/repos/releases/#list-releases-for-a-reposit
> ory
I've seen reposi
Hello,
On 02/09/15 11:12 PM, Dmitry Smirnov wrote:
> Control: tag -1 moreinfo
>
> "debian/copyright" is incomplete. Please document
>
> _example/mod_vtable/picojson.h
Fixed
> and
> code/*
> sqlite3-binding.c, sqlite3-binding.h, sqlite3ext.h
>
> The latter is "amalgamation code tha
On Thursday 03 September 2015 01:20:32 Alexandre Viau wrote:
> I have excluded code/* from the tarball, added libsqlite3-dev as a
> dependency and written a patch.
Awesome. :)
> Let me know if that works for you :)
Hmm, I'm getting "empty-binary-package" and second build fails due to local
ch
On 03/09/15 01:49 AM, Dmitry Smirnov wrote:
> Hmm, I'm getting "empty-binary-package"
That is due to me working too late! There was a missing dh_auto_install
call. I have just fixed it.
> and second build fails due to local
> changes in "go-sqlite3-1.0.0/sqlite3.go"...
You cannot build twice wit
On Thursday 03 September 2015 01:20:32 Alexandre Viau wrote:
> I have excluded code/* from the tarball, added libsqlite3-dev as a
> dependency and written a patch.
>
> Let me know if that works for you :)
It seems to work when I drop "override_dh_auto_install" section from "rules".
What were you
On 03/09/15 02:04 AM, Dmitry Smirnov wrote:
> It seems to work when I drop "override_dh_auto_install" section from "rules".
> What were you trying to do in this override?
Looks like we are sending mails at the same time.
This override is to avoid having a huge quilt patch. quilt generates
huge p
On 03/09/15 02:13 AM, Dmitry Smirnov wrote:
> I don't understand what are you trying to do. Apparently your override do not
> work as I see no difference in resulting packages whether I build with or
> without override.
It looks like the patch that remove the build tag is enough. I have
removed
On Thursday 03 September 2015 02:08:53 Alexandre Viau wrote:
> This override is to avoid having a huge quilt patch. quilt generates
> huge patches for file renames.
>
> The go compiler uses build tags to determine which file to build,
> depending on the file name.
>
> In our case, we never want t
On 03/09/15 02:28 AM, Dmitry Smirnov wrote:
> Although package seems to work even without rename.
Indeed, you are perfectly right. I have removed the override in my last
commit, as the patch is enough.
--
Alexandre Viau
alexan...@alexandreviau.net
signature.asc
Description: OpenPGP digital
On Thursday 03 September 2015 02:20:39 Alexandre Viau wrote:
> It looks like the patch that remove the build tag is enough. I have
> removed the override.
It is enough and lintian no longer complains about bundled SQLite3 in
grafana. :) Very nice.
> > If package FTBFS on second build is a bug
On Thursday 03 September 2015 02:32:03 Alexandre Viau wrote:
> Indeed, you are perfectly right. I have removed the override in my last
> commit, as the patch is enough.
Thank you very much. All good (grafana works) and package builds nicely so
I've just uploaded it. Well done. :)
--
Cheers,
Dm
On 03/09/15 02:45 AM, Dmitry Smirnov wrote:
> On Thursday 03 September 2015 02:32:03 Alexandre Viau wrote:
>> Indeed, you are perfectly right. I have removed the override in my last
>> commit, as the patch is enough.
>
> Thank you very much. All good (grafana works) and package builds nicely so
>
18 matches
Mail list logo
