On Wed, Apr 21, 2004 at 11:45:28PM +0200, Christoph Hellwig wrote:
> On Wed, Apr 21, 2004 at 04:11:49PM -0500, Branden Robinson wrote:
> > Err, when pasting source code regarding an issue like this, where we
> > need a clean-room reimplementation, please identify the origin of every
> > line.
>
>
On Wed, Apr 21, 2004 at 11:02:12PM +0200, Fabio Massimo Di Nitto wrote:
> > So what about the following unutested patch:
>
> Sorry but i can't accept an untested patch. Would you mind to give it a
> shot at least?
I don't think I have the time for a full blown X build, sorry.
On Wed, Apr 21, 2004 at 04:11:49PM -0500, Branden Robinson wrote:
> Err, when pasting source code regarding an issue like this, where we
> need a clean-room reimplementation, please identify the origin of every
> line.
The surrounding code is from XFree CVS when I last updated (about two
weeks bef
Hi Christoph
On Wed, 21 Apr 2004, Christoph Hellwig wrote:
> Okay, I looked over lnx_kbd.c, there's two thing that sprang to my mind:
>
> - the ifndef sparc and comment below is obviously wrong, the ioctl is
>implemented in Linux common code, specifically vt_ioctl.c.
> - fd 0 for the ioctl
On Wed, 21 Apr 2004, Keith Packard wrote:
>
> Around 22 o'clock on Apr 21, Fabio Massimo Di Nitto wrote:
>
> > Would you have the time to do it straight ahead? Can you give me an
> > estimated ETA?
>
> I haven't seen the description from Branden yet, but I expect it will take
> only a moment or tw
On Wed, Apr 21, 2004 at 09:50:21PM +0200, Christoph Hellwig wrote:
> Okay, I looked over lnx_kbd.c, there's two thing that sprang to my mind:
>
> - the ifndef sparc and comment below is obviously wrong, the ioctl is
>implemented in Linux common code, specifically vt_ioctl.c.
> - fd 0 for the
Around 22 o'clock on Apr 21, Fabio Massimo Di Nitto wrote:
> Would you have the time to do it straight ahead? Can you give me an
> estimated ETA?
I haven't seen the description from Branden yet, but I expect it will take
only a moment or two to implement the fix. However, I'll be away from
21
On Wed, 21 Apr 2004, Branden Robinson wrote:
> Fabio, it's up to you how long we should wait for a reply from Mr. Dawes
> before going ahead with the clean-room rewrite (or dropping the patch).
> Except for this one issue I'm all ready to go with the merge -- the
> whole thing.
Let's keep going p
On Wed, 21 Apr 2004, Keith Packard wrote:
>
> Around 14 o'clock on Apr 21, Branden Robinson wrote:
>
> > Also, if there is a C programmer present who is willing to perform such
> > a clean-room rewrite should it come to that, please speak up.
>
> I can do that.
Would you have the time to do it st
Okay, I looked over lnx_kbd.c, there's two thing that sprang to my mind:
- the ifndef sparc and comment below is obviously wrong, the ioctl is
implemented in Linux common code, specifically vt_ioctl.c.
- fd 0 for the ioctl seems bogus. These ioctls are on the console
device, and to my read
Around 14 o'clock on Apr 21, Branden Robinson wrote:
> Also, if there is a C programmer present who is willing to perform such
> a clean-room rewrite should it come to that, please speak up.
I can do that.
-keith
pgpmYsbU7wwMY.pgp
Description: PGP signature
On Wed, Apr 21, 2004 at 02:17:05PM -0500, Branden Robinson wrote:
> Also, if there is a C programmer present who is willing to perform such
> a clean-room rewrite should it come to that, please speak up. Please
> note that it's just the *change* that needs to be rewritten, not the
> entire files.
On Wed, Apr 21, 2004 at 02:06:33PM -0500, Branden Robinson wrote:
> Revision ChangesPath
> 3.3162+5 -1 xc/programs/Xserver/hw/xfree86/CHANGELOG
> 3.27 +5 -5
> xc/programs/Xserver/hw/xfree86/os-support/linux/lnx_io.c
> 1.6 +5 -5
> xc/progr
Hi David,
Back in March you made the following commit:
CVSROOT:/home/x-cvs
Module name:xc
Changes by: [EMAIL PROTECTED] 04/03/03 10:53:42
Log message:
6. Do the Linux KDKBDREP ioctl on the correct fd. This prevents the
fallback that tries to directly program t
14 matches
Mail list logo
