thx christian!
regards,
gerhard
2012/1/18 Christian Kaltepoth christ...@kaltepoth.de
Hi @all,
I've just added a first version of the workflow description to the
corresponding wiki page:
https://cwiki.apache.org/confluence/display/DeltaSpike/Suggested+Git+Workflows
Christian
annotation literals for std. cdi annotations
Key: DELTASPIKE-53
URL: https://issues.apache.org/jira/browse/DELTASPIKE-53
Project: DeltaSpike
Issue Type: New Feature
Components: Core
dynamic literal builder for simple annotations
--
Key: DELTASPIKE-54
URL: https://issues.apache.org/jira/browse/DELTASPIKE-54
Project: DeltaSpike
Issue Type: New Feature
Components: Core
The idea behind the redefiner was to allow the use of a limited form of a
closure to work over the class. Every annotation on the class will receive a
callback to the function, in which you can decide how to use the annotation
(replace, keep etc). This gives you access to the context in which
Say for example, the Foo class looked like:
public class Foo {
@Inject
public Foo(@Bar(name=Pete) String s) {
}
@Produces
public void produce(@Bar(name=Gerhard) String s) {
}
}
This is the kind of place where the closure based approach will help you.
Again, of course,
hi @ all,
while reviewing DELTASPIKE-45 i saw that some literal implementations for
std. cdi annotations got into deltaspike as well.
in myfaces codi we also have some literal implementations. esp. for
DELTASPIKE-45 they make a lot of sense imo.
- i created DELTASPIKE-53 and since there is just
+1
On 18 Jan 2012, at 16:47, Gerhard Petracek wrote:
hi @ all,
while reviewing DELTASPIKE-45 i saw that some literal implementations for
std. cdi annotations got into deltaspike as well.
in myfaces codi we also have some literal implementations. esp. for
DELTASPIKE-45 they make a lot of
+1 for the annotation literals. IMO, the spec should have literals for all the
annotations it defines.
Sent from my iPhone
On Jan 18, 2012, at 9:49, Pete Muir pm...@redhat.com wrote:
+1
On 18 Jan 2012, at 16:47, Gerhard Petracek wrote:
hi @ all,
while reviewing DELTASPIKE-45 i saw
hi @ all,
like DELTASPIKE-53 this ticket is also related to DELTASPIKE-45. for users
it might be useful to use: SimpleLiteral.of(MySimpleAnnotation.class) in
combination with the builder methods instead of implementing literals
manually (just for using them with the default values).
at [1] you
+1. Solder offers the same -
https://github.com/seam/solder/blob/master/api/src/main/java/org/jboss/solder/reflection/AnnotationInstanceProvider.java
Solder also allows you to pass in a map of values. Does CODI have a
ComplexLiteral that does this?
On 18 Jan 2012, at 17:08, Gerhard Petracek
My preference would be to take best of both here - I think a lot of time the
SimpleLiteral is enough (and AnnotationInstanceProvider should have such a
method) but that it can be useful to produce a literal with members as well. I
don't love the lack of type safety though, in the map of values,
ok - so let's proceed as usual. i'll update jira our jira tickets.
(the small tool of myfaces codi just came to my mind while reviewing
DELTASPIKE-45 - but back than i marked it as overlap already.)
@matt:
thx for the link
regards,
gerhard
2012/1/18 Matt Benson gudnabr...@gmail.com
On Wed,
[
https://issues.apache.org/jira/browse/DELTASPIKE-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerhard Petracek resolved DELTASPIKE-54.
Resolution: Won't Fix
Fix Version/s: 0.1
AnnotationInstanceProvider of
[
https://issues.apache.org/jira/browse/DELTASPIKE-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gerhard Petracek updated DELTASPIKE-54:
---
Fix Version/s: (was: 0.1)
Summary: review and discuss
fyi: please check [1] before you answer.
[2] is the implementation used in Solder. It also contains the
functionality of CODI's SimpleLiteral.
the basic concept:
Provide a way to create an instance of an annotation at runtime using
Proxy. This implementation is also able to provide values for
as mentioned by pete (earlier), the additional features (DELTASPIKE-54 vs
DELTASPIKE-55) aren't type-safe.
- +0.5 afaik we will need it for further features which need such a
generic approach (no +1 because we haven't discussed them so far)
regards,
gerhard
2012/1/18 Jason Porter
16 matches
Mail list logo
