Re: basic decisions - package and class naming
i agree with mark. regards, gerhard 2011/12/21 Mark Struberg strub...@yahoo.de As I see it we have 3 different options: 1.) .api.* + .impl.* because it's more easy to 'grab' any api package in e.g. an Arquillian test. If we don't have the modulename.api package name, then we cannot do something like this in Arquillian: Shrinkwrap.createArchive(JavaArchive.class).addPackages(true, ...modulename.api); Without the explicit .api package name we would not be able to add just the api module without also adding all the impl stuff as well. (This is needed if we e.g. like to test single features of the impl module). The very same will hit us with the maven-shade-plugin where we would not be able to explicitely shade all classes of the api modules. thus a +1 for this. 2.) noting + '.internal' possible, but with the downsides as noted above. -0.5 thus. LieGrue, strub - Original Message - From: Antoine Sabot-Durand anto...@sabot-durand.net To: deltaspike-dev@incubator.apache.org Cc: Sent: Tuesday, December 20, 2011 11:55 AM Subject: Re: basic decisions - package and class naming Social API: org.apache.deltaspike.social.* +1 the implementation org.apache.deltaspike.social.impl.* +0 (we don't have this in Seam and have the distinction in module name, but it's not a big deal for me) @SPI = +0 I'm not sure to use it but why not. Antoine SABOT-DURAND Le 15 déc. 2011 à 18:43, Matthias Wessendorf a écrit : On Thu, Dec 15, 2011 at 3:31 PM, Mark Struberg strub...@yahoo.de wrote: Well, we are now hitting the wall - so we need a resolution asap. For the core module we would have for core-api: org.apache.deltaspike.core. ? for core-impl: org.apache.deltaspike.core.impl. ? yes! And/or JPA API: org.apache.deltaspike.jpa.* the implementation org.apache.deltaspike.jpa.impl.* @SPI = fine for me! But please NO 'api' inside of the pkg names; (impl is a must, IMO (fine in naming it 'internal', but I guess impl is more 'standard') -M The problem is that by omitting the .api. package, we don't have any good handle to include/exclude all the classes from core.api, jsf.api, etc in the maven-shade-plugin or any other include/exclude mechanism. That could hurt a bit. Matze, you have not been fond of the api package, what do you suggest as an alternative option? LieGrue, strub
[jira] [Created] (DELTASPIKE-17) BeanManagerProvider
BeanManagerProvider --- Key: DELTASPIKE-17 URL: https://issues.apache.org/jira/browse/DELTASPIKE-17 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek original feature: https://issues.apache.org/jira/browse/EXTCDI-13 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-18) unit and integration tests for BeanManagerProvider
[ https://issues.apache.org/jira/browse/DELTASPIKE-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-18: --- Description: we need tests for: - after a container is bootstrapped, BeanManagerProvider.getInstance().getBeanManager() has to return a bm - usage in shared lib scenarios - shutdown of a container - cleanup has to be successful - the different config approaches unit and integration tests for BeanManagerProvider -- Key: DELTASPIKE-18 URL: https://issues.apache.org/jira/browse/DELTASPIKE-18 Project: DeltaSpike Issue Type: Sub-task Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek we need tests for: - after a container is bootstrapped, BeanManagerProvider.getInstance().getBeanManager() has to return a bm - usage in shared lib scenarios - shutdown of a container - cleanup has to be successful - the different config approaches -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DELTASPIKE-18) unit and integration tests for BeanManagerProvider
[ https://issues.apache.org/jira/browse/DELTASPIKE-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek reassigned DELTASPIKE-18: -- Assignee: Mark Struberg (was: Gerhard Petracek) unit and integration tests for BeanManagerProvider -- Key: DELTASPIKE-18 URL: https://issues.apache.org/jira/browse/DELTASPIKE-18 Project: DeltaSpike Issue Type: Sub-task Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg we need tests for: - after a container is bootstrapped, BeanManagerProvider.getInstance().getBeanManager() has to return a bm - usage in shared lib scenarios - shutdown of a container - cleanup has to be successful - the different config approaches -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DELTASPIKE-19) documentation for BeanManagerProvider
[ https://issues.apache.org/jira/browse/DELTASPIKE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek reassigned DELTASPIKE-19: -- Assignee: Mark Struberg (was: Gerhard Petracek) documentation for BeanManagerProvider - Key: DELTASPIKE-19 URL: https://issues.apache.org/jira/browse/DELTASPIKE-19 Project: DeltaSpike Issue Type: Sub-task Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DELTASPIKE-20) move util methods to CdiUtils
[ https://issues.apache.org/jira/browse/DELTASPIKE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek reassigned DELTASPIKE-20: -- Assignee: Mark Struberg (was: Gerhard Petracek) move util methods to CdiUtils - Key: DELTASPIKE-20 URL: https://issues.apache.org/jira/browse/DELTASPIKE-20 Project: DeltaSpike Issue Type: Sub-task Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg public T T getContextualReference(ClassT type, boolean optionalBeanAllowed, Annotation... qualifiers) public T T getContextualReference(String name, boolean optionalBeanAllowed, ClassT targetType) public T T getContextualReference(BeanT bean, boolean optionalBeanAllowed, ClassT targetType) public T ListT getContextualReferences(ClassT type, boolean optionalBeanAllowed, Annotation... qualifiers) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-4) review and discuss ProjectStage
[ https://issues.apache.org/jira/browse/DELTASPIKE-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved DELTASPIKE-4. --- Resolution: Fixed we agreed on adding it - see http://s.apache.org/is review and discuss ProjectStage --- Key: DELTASPIKE-4 URL: https://issues.apache.org/jira/browse/DELTASPIKE-4 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Gerhard Petracek -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (DELTASPIKE-21) ProjectStage
ProjectStage Key: DELTASPIKE-21 URL: https://issues.apache.org/jira/browse/DELTASPIKE-21 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-21) ProjectStage
[ https://issues.apache.org/jira/browse/DELTASPIKE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-21: --- Description: original feature: https://issues.apache.org/jira/browse/EXTCDI-9 ProjectStage Key: DELTASPIKE-21 URL: https://issues.apache.org/jira/browse/DELTASPIKE-21 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Mark Struberg original feature: https://issues.apache.org/jira/browse/EXTCDI-9 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (DELTASPIKE-23) documentation for ProjectStage
documentation for ProjectStage -- Key: DELTASPIKE-23 URL: https://issues.apache.org/jira/browse/DELTASPIKE-23 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Mark Struberg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [DISCUSS] [DELTASPIKE-5] Deactivatable
hi @ all, it looks like we have an agreement. i'm going to create the corresponding jira issues. (imo: since we haven't seen objections btw. a discussion about it and it isn't a formal vote, we can start right now.) regards, gerhard 2011/12/20 Marius Bogoevici marius.bogoev...@gmail.com +1 On 2011-12-19, at 2:49 PM, Gerhard Petracek wrote: hi @ all, fyi: please check [1] before you answer. [2] provides a short introduction as well as the basic usage. the basic concept: pre-configured cdi artifacts (like implementations of javax.enterprise.inject.spi.Extension) which can't be deactivated via ProcessAnnotatedType#veto are deactivatable via implementations of ClassDeactivator. please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://cwiki.apache.org/confluence/display/EXTCDI/Core+Config+and+SPI#CoreConfigandSPI-Deactivatingdefaultimplementations [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: basic decisions - package and class naming
On Wed, Dec 21, 2011 at 12:00 PM, Mark Struberg strub...@yahoo.de wrote: As I see it we have 3 different options: 1.) .api.* + .impl.* because it's more easy to 'grab' any api package in e.g. an Arquillian test. If we don't have the modulename.api package name, then we cannot do something like this in Arquillian: Shrinkwrap.createArchive(JavaArchive.class).addPackages(true, ...modulename.api); Without the explicit .api package name we would not be able to add just the api module without also adding all the impl stuff as well. (This is needed if we e.g. like to test single features of the impl module). Ok, I don't get the _why_; Do you mind to explain it to me (I know nothing about Arquillian and the shade plugin:-)) -M The very same will hit us with the maven-shade-plugin where we would not be able to explicitely shade all classes of the api modules. thus a +1 for this. 2.) noting + '.internal' possible, but with the downsides as noted above. -0.5 thus. LieGrue, strub - Original Message - From: Antoine Sabot-Durand anto...@sabot-durand.net To: deltaspike-dev@incubator.apache.org Cc: Sent: Tuesday, December 20, 2011 11:55 AM Subject: Re: basic decisions - package and class naming Social API: org.apache.deltaspike.social.* +1 the implementation org.apache.deltaspike.social.impl.* +0 (we don't have this in Seam and have the distinction in module name, but it's not a big deal for me) @SPI = +0 I'm not sure to use it but why not. Antoine SABOT-DURAND Le 15 déc. 2011 à 18:43, Matthias Wessendorf a écrit : On Thu, Dec 15, 2011 at 3:31 PM, Mark Struberg strub...@yahoo.de wrote: Well, we are now hitting the wall - so we need a resolution asap. For the core module we would have for core-api: org.apache.deltaspike.core. ? for core-impl: org.apache.deltaspike.core.impl. ? yes! And/or JPA API: org.apache.deltaspike.jpa.* the implementation org.apache.deltaspike.jpa.impl.* @SPI = fine for me! But please NO 'api' inside of the pkg names; (impl is a must, IMO (fine in naming it 'internal', but I guess impl is more 'standard') -M The problem is that by omitting the .api. package, we don't have any good handle to include/exclude all the classes from core.api, jsf.api, etc in the maven-shade-plugin or any other include/exclude mechanism. That could hurt a bit. Matze, you have not been fond of the api package, what do you suggest as an alternative option? LieGrue, strub -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
[jira] [Updated] (DELTASPIKE-23) documentation for ProjectStage
[ https://issues.apache.org/jira/browse/DELTASPIKE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-23: --- Component/s: (was: Core) Documentation documentation for ProjectStage -- Key: DELTASPIKE-23 URL: https://issues.apache.org/jira/browse/DELTASPIKE-23 Project: DeltaSpike Issue Type: Sub-task Components: Documentation Reporter: Gerhard Petracek Assignee: Mark Struberg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-19) documentation for BeanManagerProvider
[ https://issues.apache.org/jira/browse/DELTASPIKE-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-19: --- Component/s: (was: Core) Documentation documentation for BeanManagerProvider - Key: DELTASPIKE-19 URL: https://issues.apache.org/jira/browse/DELTASPIKE-19 Project: DeltaSpike Issue Type: Sub-task Components: Documentation Reporter: Gerhard Petracek Assignee: Mark Struberg -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-3) review and discuss BeanManagerProvider
[ https://issues.apache.org/jira/browse/DELTASPIKE-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-3: -- Fix Version/s: 1.0.0-incubating review and discuss BeanManagerProvider -- Key: DELTASPIKE-3 URL: https://issues.apache.org/jira/browse/DELTASPIKE-3 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Gerhard Petracek Fix For: 1.0.0-incubating -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DELTASPIKE-24) Deactivatable
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek reopened DELTASPIKE-24: Deactivatable - Key: DELTASPIKE-24 URL: https://issues.apache.org/jira/browse/DELTASPIKE-24 Project: DeltaSpike Issue Type: New Feature Components: Core Reporter: Gerhard Petracek Assignee: Gerhard Petracek Fix For: 1.0.0-incubating original feature: https://issues.apache.org/jira/browse/EXTCDI-66 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DELTASPIKE-10) review and discuss metadata implementations and utils
[ https://issues.apache.org/jira/browse/DELTASPIKE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek reassigned DELTASPIKE-10: -- Assignee: Jason Porter (was: Gerhard Petracek) review and discuss metadata implementations and utils --- Key: DELTASPIKE-10 URL: https://issues.apache.org/jira/browse/DELTASPIKE-10 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Jason Porter BeanBuilder - DELTASPIKE-16 NarrowingBeanBuilder - DELTASPIKE-16 AnnotatedTypeBuilder - DELTASPIKE-16 GenericBean - DELTASPIKE-14 DefaultBean - DELTASPIKE-15 Forward* -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-10) review and discuss metadata implementations and utils
[ https://issues.apache.org/jira/browse/DELTASPIKE-10?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek updated DELTASPIKE-10: --- Description: BeanBuilder - DELTASPIKE-16 NarrowingBeanBuilder - DELTASPIKE-16 AnnotatedTypeBuilder - DELTASPIKE-16 GenericBean - DELTASPIKE-14 DefaultBean - DELTASPIKE-15 Forward* Utils was: BeanBuilder - DELTASPIKE-16 NarrowingBeanBuilder - DELTASPIKE-16 AnnotatedTypeBuilder - DELTASPIKE-16 GenericBean - DELTASPIKE-14 DefaultBean - DELTASPIKE-15 Forward* review and discuss metadata implementations and utils --- Key: DELTASPIKE-10 URL: https://issues.apache.org/jira/browse/DELTASPIKE-10 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Jason Porter BeanBuilder - DELTASPIKE-16 NarrowingBeanBuilder - DELTASPIKE-16 AnnotatedTypeBuilder - DELTASPIKE-16 GenericBean - DELTASPIKE-14 DefaultBean - DELTASPIKE-15 Forward* Utils -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (DELTASPIKE-9) review and discuss @Requires
[ https://issues.apache.org/jira/browse/DELTASPIKE-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek reassigned DELTASPIKE-9: - Assignee: Jason Porter (was: Gerhard Petracek) review and discuss @Requires Key: DELTASPIKE-9 URL: https://issues.apache.org/jira/browse/DELTASPIKE-9 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Jason Porter -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (DELTASPIKE-27) review and discuss CodiConfig
review and discuss CodiConfig - Key: DELTASPIKE-27 URL: https://issues.apache.org/jira/browse/DELTASPIKE-27 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Gerhard Petracek -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (DELTASPIKE-28) review and discuss ServiceProvider
review and discuss ServiceProvider -- Key: DELTASPIKE-28 URL: https://issues.apache.org/jira/browse/DELTASPIKE-28 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Gerhard Petracek -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (DELTASPIKE-31) review and discuss StartupEventBroadcaster
review and discuss StartupEventBroadcaster -- Key: DELTASPIKE-31 URL: https://issues.apache.org/jira/browse/DELTASPIKE-31 Project: DeltaSpike Issue Type: Sub-task Reporter: Gerhard Petracek Assignee: Gerhard Petracek -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: git workflow
+1 rebase On Tue, Dec 20, 2011 at 6:48 PM, Mark Struberg strub...@yahoo.de wrote: It was only about git pull --rebase Which means that _your_ _own_ commits done in the meantime (and not pushed upwards) will get rebased to the tip of HEAD. If you don't do this, you will always get this ugly 'auto-merge with master' commits. This is something we should not do, because it doesn't reflect the reality. In all other situations, a rebase where some commits got pushed upwards already is forbidden anyway! LieGrue, strub - Original Message - From: Jason Porter lightguard...@gmail.com To: deltaspike-dev@incubator.apache.org deltaspike-dev@incubator.apache.org Cc: deltaspike-dev@incubator.apache.org deltaspike-dev@incubator.apache.org Sent: Tuesday, December 20, 2011 8:58 PM Subject: Re: git workflow Preference here, but -1 for rebase merging. I personally like seeing where everything came from. I get scared when I see people suggesting rebase all the time, not because I'm afraid of rebase, but for people new(er) to git, rebase is confusing and often leads to problems. If we want to rebase and fast-forward merge everything to the main repo, which is controlled by the main development team I'm okay with that. I just don't want to tell new contributors they need to understand rebase or have them come into irc or the mailing list saying their repo is fubar. Sent from my iPhone On Dec 20, 2011, at 7:35, Mark Struberg strub...@yahoo.de wrote: git pull --rebase would be appreciated. We should not get all our history polluted with this dumb 'merging blabla' commits. This can be made the default for new branches: git config --global branch.autosetuprebase always LieGrue, strub - Original Message - From: Gerhard Petracek gerhard.petra...@gmail.com To: deltaspike-dev@incubator.apache.org Cc: Sent: Tuesday, December 20, 2011 3:23 PM Subject: git workflow hi @ all, feel free to add your suggestions to [1]. regards, gerhard [1] https://cwiki.apache.org/confluence/display/DeltaSpike/Suggested+Git+Workflows
[DISCUSS] [DELTASPIKE-28] ServiceProvider
hi @ all, fyi: please check [1] before you answer. [2] is the implementation used in owb. i suggest to start with it (instead of the version of codi), because the version of codi provides additional mechanisms we might need later on (if we include the corresponding features). the basic concept: ServiceProvider (btw. DefaultLoaderService) is a custom implementation of the ServiceLoader mechanism which allows to use codi with java 1.5 (if the cdi container allows it as well). in case of java6+ the std. ServiceLoader gets used. please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.3/webbeans-impl/src/main/java/org/apache/webbeans/service/DefaultLoaderService.java [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: [DISCUSS] [DELTASPIKE-27] CodiConfig
+1 regards, gerhard 2011/12/21 Gerhard Petracek gerhard.petra...@gmail.com hi @ all, fyi: please check [1] before you answer. [2] shows how to provide custom config-values in a type-safe manner. the basic concept: CodiConfig itself is just a marker interface to find all config classes easily. a config class is a simple application scoped cdi-bean with getter methods. a config can be accessed easily via std. cdi injection. users see the default-values as well as custom configured values easily. to provide custom values, users just have to extend the config class, annotate it with @Specializes and to override the corresponding method. furthermore, it's possible to provide config modules which allow to use different kinds of config formats like xml files, property files,... (due to the @Specializes bug in weld, we had to introduce a workaround. however, since weld v1.1.4 it's fixed and so we don't need the workarounds we introduced for it and it's as simple as the previous description.) please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://cwiki.apache.org/confluence/display/EXTCDI/JSF+Config+and+SPI [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: [DISCUSS] [DELTASPIKE-28] ServiceProvider
+1 regards, gerhard 2011/12/21 Gerhard Petracek gerhard.petra...@gmail.com hi @ all, fyi: please check [1] before you answer. [2] is the implementation used in owb. i suggest to start with it (instead of the version of codi), because the version of codi provides additional mechanisms we might need later on (if we include the corresponding features). the basic concept: ServiceProvider (btw. DefaultLoaderService) is a custom implementation of the ServiceLoader mechanism which allows to use codi with java 1.5 (if the cdi container allows it as well). in case of java6+ the std. ServiceLoader gets used. please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.1.3/webbeans-impl/src/main/java/org/apache/webbeans/service/DefaultLoaderService.java [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
[DISCUSS] [DELTASPIKE-29] BeanNames
hi @ all, fyi: please check [1] before you answer. the basic concept: in myfaces codi all names for named beans (@Named of cdi) are placed as variables in an interface (one per module). to find such interfaces easily they implement a marker interface called BeanNames (see e.g. [2]) please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] http://s.apache.org/xu [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: [DISCUSS] [DELTASPIKE-29] BeanNames
+1 regards, gerhard 2011/12/21 Gerhard Petracek gerhard.petra...@gmail.com hi @ all, fyi: please check [1] before you answer. the basic concept: in myfaces codi all names for named beans (@Named of cdi) are placed as variables in an interface (one per module). to find such interfaces easily they implement a marker interface called BeanNames (see e.g. [2]) please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] http://s.apache.org/xu [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
[DISCUSS] [DELTASPIKE-30] startup logging of module config
hi @ all, fyi: please check [1] before you answer. the basic concept: during the startup of an application myfaces codi writes information about the current environment to the log. (e.g. the values configured via [2] and the detected version and implementation of cdi and other modules do the same e.g. for jsf, bv, jpa,...) users can deactivate the behaviour via CodiCoreConfig#isConfigurationLoggingEnabled please send +1, +0 or -1 because... for the basic idea. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://issues.apache.org/jira/browse/DELTASPIKE-27 [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: [DISCUSS] [DELTASPIKE-30] startup logging of module config
+1 regards, gerhard 2011/12/21 Gerhard Petracek gerhard.petra...@gmail.com hi @ all, fyi: please check [1] before you answer. the basic concept: during the startup of an application myfaces codi writes information about the current environment to the log. (e.g. the values configured via [2] and the detected version and implementation of cdi and other modules do the same e.g. for jsf, bv, jpa,...) users can deactivate the behaviour via CodiCoreConfig#isConfigurationLoggingEnabled please send +1, +0 or -1 because... for the basic idea. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://issues.apache.org/jira/browse/DELTASPIKE-27 [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: [DISCUSS] [DELTASPIKE-27] CodiConfig
+1 Please note that CodiConfig doesn't contain any logic! It's really just a marker interface to mark our SPI classes which are to be implemented/overwritten in a customer project to configure the provided functionality. LieGrue, strub - Original Message - From: Gerhard Petracek gerhard.petra...@gmail.com To: deltaspike-dev@incubator.apache.org Cc: Sent: Wednesday, December 21, 2011 9:41 PM Subject: Re: [DISCUSS] [DELTASPIKE-27] CodiConfig +1 regards, gerhard 2011/12/21 Gerhard Petracek gerhard.petra...@gmail.com hi @ all, fyi: please check [1] before you answer. [2] shows how to provide custom config-values in a type-safe manner. the basic concept: CodiConfig itself is just a marker interface to find all config classes easily. a config class is a simple application scoped cdi-bean with getter methods. a config can be accessed easily via std. cdi injection. users see the default-values as well as custom configured values easily. to provide custom values, users just have to extend the config class, annotate it with @Specializes and to override the corresponding method. furthermore, it's possible to provide config modules which allow to use different kinds of config formats like xml files, property files,... (due to the @Specializes bug in weld, we had to introduce a workaround. however, since weld v1.1.4 it's fixed and so we don't need the workarounds we introduced for it and it's as simple as the previous description.) please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://cwiki.apache.org/confluence/display/EXTCDI/JSF+Config+and+SPI [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: [DISCUSS] [DELTASPIKE-30] startup logging of module config
+0.8 nice to have, but we should broaden this to a general logging discussion imo. LieGrue, strub - Original Message - From: Gerhard Petracek gerhard.petra...@gmail.com To: deltaspike-dev@incubator.apache.org Cc: Sent: Wednesday, December 21, 2011 10:07 PM Subject: [DISCUSS] [DELTASPIKE-30] startup logging of module config hi @ all, fyi: please check [1] before you answer. the basic concept: during the startup of an application myfaces codi writes information about the current environment to the log. (e.g. the values configured via [2] and the detected version and implementation of cdi and other modules do the same e.g. for jsf, bv, jpa,...) users can deactivate the behaviour via CodiCoreConfig#isConfigurationLoggingEnabled please send +1, +0 or -1 because... for the basic idea. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] https://issues.apache.org/jira/browse/DELTASPIKE-27 [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
Re: [DISCUSS] [DELTASPIKE-29] BeanNames
combined with std. ide features it can be useful. it's a bit nicer than just searching for all usages of @Named, if you are interested only in the bean-names of codi (btw. if we add it of deltaspike) but it's a low priority topic (without a big impact). i just picked it right now because it's an easy topic. regards, gerhard 2011/12/22 Mark Struberg strub...@yahoo.de -0.8 I just don't see the benefit. Never used that in Codi. LieGrue, strub - Original Message - From: Gerhard Petracek gerhard.petra...@gmail.com To: deltaspike-dev@incubator.apache.org Cc: Sent: Wednesday, December 21, 2011 9:52 PM Subject: [DISCUSS] [DELTASPIKE-29] BeanNames hi @ all, fyi: please check [1] before you answer. the basic concept: in myfaces codi all names for named beans (@Named of cdi) are placed as variables in an interface (one per module). to find such interfaces easily they implement a marker interface called BeanNames (see e.g. [2]) please send +1, +0 or -1 because... for the basic idea as well as the basic concept. if there are basic objections, please also add them to [3] regards, gerhard [1] http://markmail.org/message/7yefspfuvtz4jvmp [2] http://s.apache.org/xu [3] https://cwiki.apache.org/confluence/display/DeltaSpike/SE+Feature+Ranking
