[ 
https://issues.apache.org/jira/browse/DELTASPIKE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Kaltepoth updated DELTASPIKE-49:
------------------------------------------

    Attachment: DELTASPIKE-49.patch

Hey there. I know that it is somehow silly to supply a patch for this issue as 
it is a one-liner. However I think this could be a great opportunity to 
experiment with the way patch submissions could work in the future. 

I think most of us are familiar with GitHub and the way pull request work. But 
as the ASF repository doesn't offer something similar we will have to find some 
other process.

Of cause ordinary patch files will be sufficient in many cases. But as soon as 
contributions consist of more than one commit this doesn't work very well any 
more.

For this issue I just created a local branch, committed the changes and created 
the patch with:

$ git format-patch --stdout master > ../DELTASPIKE-49.patch

This results in a patch in mailbox format. Applying it is very easy:

$ git am < ../DELTASPIKE-49.patch

The nice thing about this way of applying a patch is that it preserves the 
individual commits including the commit messages.

If this works fine we could add a page to the wiki describing this process.
                
> Remove -XX:+UseFastAccessorMethods as JVM argument for Jboss startup for 
> integration tests
> ------------------------------------------------------------------------------------------
>
>                 Key: DELTASPIKE-49
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-49
>             Project: DeltaSpike
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.1-SNAPSHOT
>            Reporter: Rudy De Busscher
>            Assignee: Gerhard Petracek
>            Priority: Minor
>         Attachments: DELTASPIKE-49.patch
>
>
> When running the integration tests on a JRockit JVM, the JBoss server isn't 
> starting up due to the parameter specified in arquillian.xml.
> On the mailing list there was a discussion and agreement to remove this 
> option.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to