Re: [Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-07 Thread Richard Shann
I have built your isolate_generated and refactor branches and they are both working fine - I do make clean, distclean autogen.sh configure for local build make and make install as a test all with a clean user. I have played around with the parts of the program that could be affected by the re-facto

Re: [Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-07 Thread Richard Shann
On Tue, 2013-05-07 at 11:46 +0200, Éloi Rivard wrote: > I made some refactoring on keyboard.c and splited it. XML parts are > now in keymapio.c. Let me know if it is mergeable. I can try later. > > Must all sources be direct children of src or subdirectories are ok to > you ? I think about isolati

Re: [Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-06 Thread Richard Shann
On Mon, 2013-05-06 at 17:54 +0200, Éloi Rivard wrote: > I idented src and utils directories with indent -nut -l500, to use > tabs instead of spaces so the code displays the same on every editors, > and to not break lines after 80 columns. > > This is on the 'indent' branch. Let me know if it is ok

Re: [Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-06 Thread Éloi Rivard
I idented src and utils directories with indent -nut -l500, to use tabs instead of spaces so the code displays the same on every editors, and to not break lines after 80 columns. This is on the 'indent' branch. Let me know if it is ok to you 2013/5/6 Éloi Rivard > That's what I mean :) > > > 20

Re: [Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-06 Thread Éloi Rivard
That's what I mean :) 2013/5/6 Richard Shann > On Mon, 2013-05-06 at 11:27 +0200, Éloi Rivard wrote: > > Indent is a GNU program that let you indent your code the way you > > want: http://www.gnu.org/software/indent/ > > > > I think most of linux distributions have a package for this. > Ah, yes

Re: [Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-06 Thread Richard Shann
On Mon, 2013-05-06 at 11:27 +0200, Éloi Rivard wrote: > Indent is a GNU program that let you indent your code the way you > want: http://www.gnu.org/software/indent/ > > I think most of linux distributions have a package for this. Ah, yes, I have it now, a separate package called indent ( :) ) on

Re: [Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-06 Thread Éloi Rivard
Indent is a GNU program that let you indent your code the way you want: http://www.gnu.org/software/indent/ I think most of linux distributions have a package for this. This let you chose the indentation policy you want (number of spaces, use of tabulations or not, braces at end of lines or at begi

[Denemo-devel] Indentation (was Re: Command generation mechanism)

2013-05-06 Thread Richard Shann
Indentation is often terrible in Denemo - I don't seem to have any indent command - this hook seems to refer to one, what would that be? I am not sure that automatic re-indenting on commit will be good - anything altering the programmer's text is controversial, but I would be very happy to adopt a