[PATCH] Derby-127

2005-05-05 Thread Jack Klebanoff
I have attached a patch that fixes Jira bug Derby-127 (http://issues.apache.org/jira/browse/DERBY-127). The problem is with select statements that use a correlation name in the select list, a group by clause, and an order by clause that refers to a column by its database name instead of its cor

Re: [PATCH] Derby-127

2005-05-10 Thread Army
Jack Klebanoff wrote: I have attached a patch that fixes Jira bug Derby-127 (http://issues.apache.org/jira/browse/DERBY-127). I reviewed this patch, applied it to a clean codeline without problem, and ran the orderby.sql test that was included. From what I can tell, everything looks good here.

Re: [PATCH] Derby-127

2005-05-11 Thread Jack Klebanoff
Army wrote: Jack Klebanoff wrote: I have attached a patch that fixes Jira bug Derby-127 (http://issues.apache.org/jira/browse/DERBY-127). I reviewed this patch, applied it to a clean codeline without problem, and ran the orderby.sql test that was included. From what I can tell, everything look

Re: [PATCH] Derby-127

2005-05-11 Thread Army
Jack Klebanoff wrote: I agree with Army's suggestion for an extra test. Should I wait for my original patch to be committed and submit the new test in a new patch, or should I revise and re-submit my patch? Not sure if that question was directed at me or not. If it was, then my answer is "Ummm.

Re: [PATCH] Derby-127

2005-05-12 Thread Satheesh Bandaram
Commited this patch. Sending    java\engine\org\apache\derby\impl\sql\compile\OrderByColumn.java Sending    java\engine\org\apache\derby\impl\sql\compile\ResultColumnList.java Sending    java\engine\org\apache\derby\impl\sql\compile\TableName.java Sending    java\engine\org\apa

Re: [PATCH] Derby-127

2005-05-12 Thread Satheesh Bandaram
I have committed this patch. If you would like to submit test updates later, that would be fine. Satheesh Jack Klebanoff wrote: > Army wrote: > >> Jack Klebanoff wrote: >> >>> I have attached a patch that fixes Jira bug Derby-127 >>> (http://issues.apache.org/jira/browse/DERBY-127). >> >> >> >>