The changes you suggested fixes the Derby5578 test. I've changed the
return type of examineTriggerNode to int[] and I've run quite a
few test suites without encountering any bugs.
Wonderful!
The problem that I was facing while running the tests suites was
because of the junit-html in the
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: workingPatch.patch
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
Hi Bryan,
The changes you suggested fixes the Derby5578 test. I've changed the return
type of examineTriggerNode to int[] and I've run quite a few test suites
without encountering any bugs.
The problem that I was facing while running the tests suites was because of
the junit-html in the command
Hi Abhinav,
I played around with TriggerTest.testDerby5578InvalidateAllStatementsProc()
for a while.
It seems like this test forces us through a slightly different code path
with respect to how we call DataDictionaryImpl.getTriggerActionString().
The trigger we are working with in that test
Hi Bryan,
I still feel like the return code of examineTriggerNodeAndCols
should not be String, but should instead be int [], but I think
we could address that separately.
I had changed that to int[] and it is a part of the diff 6783_newTests.diff
that I submitted 5 days ago. Since I was
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-6783:
---
Attachment: error-stacktrace.out
With the latest patch I get an error in
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-6783:
---
Attachment: cleanedUpDiff.patch
I realize that I suggested on the derby-dev list that we take
Hi Bryan,
The reason I had added the sortTriggerColsAndTriggerAction was that,
earlier when we had not separated the getTriggerActionString, during the
first call of getTriggerActionString, the array triggerColsAndTriggerAction
had values [1,2]
where 1 referenced to the ID field and 2 referenced
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: 6783_allTestsPass.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-6783:
---
Attachment: 6783_moreTests_bryan.diff
Slightly-tweaked copy of 6783_moreTests.diff; see the
Hi Abhinav,
I found a bit of time to experiment some more with your patch.
The additional tests you have added are very interesting, thank you
very much for constructing them!
I am a bit uncertain about the new method you added:
DataDictionaryImpl.sortTriggerColsAndTriggerActionCols()
I've edited the large inline comments in the latest patch. And added a few more
tests.
Hi Abhinav,
Thanks for the updated patch! It seems you've made quite a bit of progress.
I'll try to dig into your patch in more detail soon, but it may
be a couple days until I can get to it, because I
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: 6783_moreTests.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
Hi Bryan,
I've edited the large inline comments in the latest patch. And added a few
more tests.
I thought about it and I think the test cases can be divided on the number
of columns being referenced by trigger and the number of columns being
referenced by the update clause.
I tested quite a
I was trying to understand the truncation error, I changed the values of the
field marks1 and marks2 in the derbyTest-6783_1 and that '20' is basically the
value of the integer field marks1 that I think is being cast as a char value.
But I haven't been
able to track where this error is
At first I thought CHAR '20' meant a character string of length 20, but
then I looked again at the funny way that '20' was written, and perhaps
it is the hex representation of an ASCII space character which has the
character code 0x20.
I'm quite certain that '20' is arising from the value I
Hi Bryan,
I tried to find the reason for truncation error in the code but I couldn't
find any reason for it. Later I shifted my focus on the queries and I added
a new test that is similar in structure with the previous test I wrote.
And I noticed that for testDerby6783_1_1 if I change my query
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: 6783_newTests.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
Hi Bryan,
Another thing that I noticed, I forgot to mention it in the mail I just
sent.
The query does not run successfully if it has a trigger on more than one
field.
As in AFTER UPDATE OF FIELD1 , works while a query like AFTER UPDATE OF
FIELD1, FIELD2 , does not.
On Wed, Jun 17, 2015 at 7:32
Hi Bryan,
I was trying to understand the truncation error, I changed the values of
the field marks1 and marks2 in the derbyTest-6783_1 and that '20' is
basically the value of the integer field marks1 that I think is being cast
as a char value. But I haven't been able to track where this error is
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-6783:
---
Attachment: 6783_newTest_bryan.diff
Hi Abhinav, I spent some time today studying your latest
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: 6783_newTest.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: 6783.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: (was: 6783.diff)
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: (was: 6783.diff)
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: 6783.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: 6783.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql script
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: (was: sortFunction.diff)
WHEN clause in CREATE TRIGGER for UPDATE is not working
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: sortFunction.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: sortFunction.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working for the
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-6783:
---
Attachment: diagnostics.diff
Updated test case, together with print statements in the
trigger
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: (was: testTriggerWhenClause.diff)
WHEN clause in CREATE TRIGGER for UPDATE is
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: (was: TriggerTest.diff)
WHEN clause in CREATE TRIGGER for UPDATE is not working
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: testTriggerWhenClause.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: testTriggerWhenClause.diff
WHEN clause in CREATE TRIGGER for UPDATE is not working
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Gupta updated DERBY-6783:
-
Attachment: TriggerTest.diff
Test Case for Derby-6783.
WHEN clause in CREATE TRIGGER for UPDATE
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bryan Pendleton updated DERBY-6783:
---
Assignee: Abhinav Gupta
WHEN clause in CREATE TRIGGER for UPDATE is not working for the sql
[
https://issues.apache.org/jira/browse/DERBY-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mamta A. Satoor updated DERBY-6783:
---
Description:
Following sql script was shared on
38 matches
Mail list logo
